All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 5/6] arm64: Use __pa_symbol for kernel symbols
Date: Wed, 23 Nov 2016 09:48:47 +0000	[thread overview]
Message-ID: <20161123094847.GC24624@leverpostej> (raw)
In-Reply-To: <92635df6-9a58-02cf-3230-1a84c28370d1@redhat.com>

On Mon, Nov 21, 2016 at 09:40:06AM -0800, Laura Abbott wrote:
> On 11/18/2016 06:35 AM, Mark Rutland wrote:
> > On Thu, Nov 17, 2016 at 05:16:55PM -0800, Laura Abbott wrote:
> >>  	/* Grab the vDSO code pages. */
> >>  	for (i = 0; i < vdso_pages; i++)
> >> -		vdso_pagelist[i + 1] = pfn_to_page(PHYS_PFN(__pa(&vdso_start)) + i);
> >> +		vdso_pagelist[i + 1] = pfn_to_page(PHYS_PFN(__pa_symbol(&vdso_start)) + i);
> > 
> > Nit: phys_to_page() again.
> 
> I think it makes sense to keep this one as is. It's offsetting
> by pfn number and trying force phys_to_page would make it more
> difficult to read.

My bad; I failed to spot the + i.

That sounds good to me; sorry for the noise there.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: lorenzo.pieralisi@arm.com,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Will Deacon <will.deacon@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 5/6] arm64: Use __pa_symbol for kernel symbols
Date: Wed, 23 Nov 2016 09:48:47 +0000	[thread overview]
Message-ID: <20161123094847.GC24624@leverpostej> (raw)
In-Reply-To: <92635df6-9a58-02cf-3230-1a84c28370d1@redhat.com>

On Mon, Nov 21, 2016 at 09:40:06AM -0800, Laura Abbott wrote:
> On 11/18/2016 06:35 AM, Mark Rutland wrote:
> > On Thu, Nov 17, 2016 at 05:16:55PM -0800, Laura Abbott wrote:
> >>  	/* Grab the vDSO code pages. */
> >>  	for (i = 0; i < vdso_pages; i++)
> >> -		vdso_pagelist[i + 1] = pfn_to_page(PHYS_PFN(__pa(&vdso_start)) + i);
> >> +		vdso_pagelist[i + 1] = pfn_to_page(PHYS_PFN(__pa_symbol(&vdso_start)) + i);
> > 
> > Nit: phys_to_page() again.
> 
> I think it makes sense to keep this one as is. It's offsetting
> by pfn number and trying force phys_to_page would make it more
> difficult to read.

My bad; I failed to spot the + i.

That sounds good to me; sorry for the noise there.

Thanks,
Mark.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: lorenzo.pieralisi@arm.com,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Will Deacon <will.deacon@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 5/6] arm64: Use __pa_symbol for kernel symbols
Date: Wed, 23 Nov 2016 09:48:47 +0000	[thread overview]
Message-ID: <20161123094847.GC24624@leverpostej> (raw)
In-Reply-To: <92635df6-9a58-02cf-3230-1a84c28370d1@redhat.com>

On Mon, Nov 21, 2016 at 09:40:06AM -0800, Laura Abbott wrote:
> On 11/18/2016 06:35 AM, Mark Rutland wrote:
> > On Thu, Nov 17, 2016 at 05:16:55PM -0800, Laura Abbott wrote:
> >>  	/* Grab the vDSO code pages. */
> >>  	for (i = 0; i < vdso_pages; i++)
> >> -		vdso_pagelist[i + 1] = pfn_to_page(PHYS_PFN(__pa(&vdso_start)) + i);
> >> +		vdso_pagelist[i + 1] = pfn_to_page(PHYS_PFN(__pa_symbol(&vdso_start)) + i);
> > 
> > Nit: phys_to_page() again.
> 
> I think it makes sense to keep this one as is. It's offsetting
> by pfn number and trying force phys_to_page would make it more
> difficult to read.

My bad; I failed to spot the + i.

That sounds good to me; sorry for the noise there.

Thanks,
Mark.

  reply	other threads:[~2016-11-23  9:48 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  1:16 [PATCHv3 0/6] CONFIG_DEBUG_VIRTUAL for arm64 Laura Abbott
2016-11-18  1:16 ` Laura Abbott
2016-11-18  1:16 ` Laura Abbott
2016-11-18  1:16 ` [PATCHv3 1/6] lib/Kconfig.debug: Add ARCH_HAS_DEBUG_VIRTUAL Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  8:25   ` Ingo Molnar
2016-11-18  8:25     ` Ingo Molnar
2016-11-18  8:25     ` Ingo Molnar
2016-11-18  1:16 ` [PATCHv3 2/6] mm/cma: Cleanup highmem check Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  1:16 ` [PATCHv3 3/6] arm64: Move some macros under #ifndef __ASSEMBLY__ Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  1:16 ` [PATCHv3 4/6] arm64: Add cast for virt_to_pfn Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  1:16 ` [PATCHv3 5/6] arm64: Use __pa_symbol for kernel symbols Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18 14:35   ` Mark Rutland
2016-11-18 14:35     ` Mark Rutland
2016-11-18 14:35     ` Mark Rutland
2016-11-18 16:46     ` Mark Rutland
2016-11-18 16:46       ` Mark Rutland
2016-11-18 16:46       ` Mark Rutland
2016-11-21 17:40     ` Laura Abbott
2016-11-21 17:40       ` Laura Abbott
2016-11-21 17:40       ` Laura Abbott
2016-11-23  9:48       ` Mark Rutland [this message]
2016-11-23  9:48         ` Mark Rutland
2016-11-23  9:48         ` Mark Rutland
2016-11-18  1:16 ` [PATCHv3 6/6] arm64: Add support for CONFIG_DEBUG_VIRTUAL Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18  1:16   ` Laura Abbott
2016-11-18 17:53   ` Mark Rutland
2016-11-18 17:53     ` Mark Rutland
2016-11-18 17:53     ` Mark Rutland
2016-11-18 18:42     ` Laura Abbott
2016-11-18 18:42       ` Laura Abbott
2016-11-18 18:42       ` Laura Abbott
2016-11-18 19:05       ` Mark Rutland
2016-11-18 19:05         ` Mark Rutland
2016-11-18 19:05         ` Mark Rutland
2016-11-18 19:17         ` Laura Abbott
2016-11-18 19:17           ` Laura Abbott
2016-11-18 19:17           ` Laura Abbott
2016-11-18 18:25   ` Mark Rutland
2016-11-18 18:25     ` Mark Rutland
2016-11-18 18:25     ` Mark Rutland
2016-11-18 17:57 ` [PATCHv3 0/6] CONFIG_DEBUG_VIRTUAL for arm64 Mark Rutland
2016-11-18 17:57   ` Mark Rutland
2016-11-18 17:57   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161123094847.GC24624@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.