* [PATCH] libxl: fix creation of pkgconf install dir
@ 2016-11-23 16:56 Roger Pau Monne
2016-11-23 17:07 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Roger Pau Monne @ 2016-11-23 16:56 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Ian Jackson, Roger Pau Monne
When PKG_INSTALLDIR was introduced the creation of the previous pkgconf install
directory was not changed. Fix this by correctly using PKG_INSTALLDIR for the
directory creation in libxl Makefile.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
Not sure whether this should be considered for 4.8. IMHO, it's a harmless fix
for Linux (where PKG_INSTALLDIR is already $(SHAREDIR)/pkgconfig), but it might
be more important for FreeBSD.
---
tools/libxl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index f5053a0..ef01785 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -308,7 +308,7 @@ install: all
$(INSTALL_DIR) $(DESTDIR)$(includedir)
$(INSTALL_DIR) $(DESTDIR)$(BASH_COMPLETION_DIR)
$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
- $(INSTALL_DIR) $(DESTDIR)$(SHAREDIR)/pkgconfig
+ $(INSTALL_DIR) $(DESTDIR)$(PKG_INSTALLDIR)
$(INSTALL_PROG) xl $(DESTDIR)$(sbindir)
$(INSTALL_PROG) libxl-save-helper $(DESTDIR)$(LIBEXEC_BIN)
$(INSTALL_SHLIB) libxenlight.so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir)
--
2.9.3 (Apple Git-75)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libxl: fix creation of pkgconf install dir
2016-11-23 16:56 [PATCH] libxl: fix creation of pkgconf install dir Roger Pau Monne
@ 2016-11-23 17:07 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2016-11-23 17:07 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Ian Jackson, Wei Liu
On Wed, Nov 23, 2016 at 04:56:39PM +0000, Roger Pau Monne wrote:
> When PKG_INSTALLDIR was introduced the creation of the previous pkgconf install
> directory was not changed. Fix this by correctly using PKG_INSTALLDIR for the
> directory creation in libxl Makefile.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked + applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-23 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 16:56 [PATCH] libxl: fix creation of pkgconf install dir Roger Pau Monne
2016-11-23 17:07 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.