* [bug report] mlxsw: core: Implement thermal zone
@ 2016-11-23 22:42 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-11-23 22:42 UTC (permalink / raw)
To: kernel-janitors
Hello Ivan Vecera,
The patch a50c1e35650b: "mlxsw: core: Implement thermal zone" from
Nov 22, 2016, leads to the following static checker warning:
drivers/net/ethernet/mellanox/mlxsw/core_thermal.c:261 mlxsw_thermal_set_trip_temp()
warn: no lower bound on 'temp'
drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
252 static int mlxsw_thermal_set_trip_temp(struct thermal_zone_device *tzdev,
253 int trip, int temp)
254 {
255 struct mlxsw_thermal *thermal = tzdev->devdata;
256
257 if (trip < 0 || trip >= MLXSW_THERMAL_NUM_TRIPS ||
258 temp > MLXSW_THERMAL_MAX_TEMP)
259 return -EINVAL;
260
261 thermal->trips[trip].temp = temp;
Did you allow negative numbers intentionally? It feels like there
should be some kind of min temp.
262 return 0;
263 }
264
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-11-23 22:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 22:42 [bug report] mlxsw: core: Implement thermal zone Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.