* [patch] swim3: remove some dead code
@ 2016-11-24 11:34 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2016-11-24 11:34 UTC (permalink / raw)
To: linux-block, Jens Axboe; +Cc: kernel-janitors, Benjamin Herrenschmidt
The goto is correct. "rc" is already set to -EBUSY so there is no need
to do anything with that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index c264f2d..59b4a41 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1179,7 +1179,6 @@ static int swim3_add_device(struct macio_dev *mdev, int index)
swim3_err("%s", "Couldn't request interrupt\n");
pmac_call_feature(PMAC_FTR_SWIM3_ENABLE, swim, 0, 0);
goto out_unmap;
- return -EBUSY;
}
init_timer(&fs->timeout);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] swim3: remove some dead code
@ 2016-11-24 11:34 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2016-11-24 11:34 UTC (permalink / raw)
To: linux-block, Jens Axboe; +Cc: kernel-janitors, Benjamin Herrenschmidt
The goto is correct. "rc" is already set to -EBUSY so there is no need
to do anything with that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index c264f2d..59b4a41 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1179,7 +1179,6 @@ static int swim3_add_device(struct macio_dev *mdev, int index)
swim3_err("%s", "Couldn't request interrupt\n");
pmac_call_feature(PMAC_FTR_SWIM3_ENABLE, swim, 0, 0);
goto out_unmap;
- return -EBUSY;
}
init_timer(&fs->timeout);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-24 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 11:34 [patch] swim3: remove some dead code Dan Carpenter
2016-11-24 11:34 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.