All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/SVM: don't deliver #GP without error code
@ 2016-11-24 14:13 Jan Beulich
  2016-11-24 14:19 ` Andrew Cooper
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Jan Beulich @ 2016-11-24 14:13 UTC (permalink / raw)
  To: xen-devel; +Cc: Andrew Cooper, Boris Ostrovsky, Wei Liu, Suravee Suthikulpanit

[-- Attachment #1: Type: text/plain, Size: 2982 bytes --]

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -2029,7 +2029,7 @@ svm_vmexit_do_vmrun(struct cpu_user_regs
     if ( !nestedsvm_vmcb_map(v, vmcbaddr) )
     {
         gdprintk(XENLOG_ERR, "VMRUN: mapping vmcb failed, injecting #GP\n");
-        hvm_inject_hw_exception(TRAP_gp_fault, HVM_DELIVER_NO_ERROR_CODE);
+        hvm_inject_hw_exception(TRAP_gp_fault, 0);
         return;
     }
 
@@ -2068,7 +2068,6 @@ svm_vmexit_do_vmload(struct vmcb_struct
                      struct cpu_user_regs *regs,
                      struct vcpu *v, uint64_t vmcbaddr)
 {
-    int ret;
     unsigned int inst_len;
     struct page_info *page;
 
@@ -2078,8 +2077,8 @@ svm_vmexit_do_vmload(struct vmcb_struct
     if ( !nsvm_efer_svm_enabled(v) ) 
     {
         gdprintk(XENLOG_ERR, "VMLOAD: nestedhvm disabled, injecting #UD\n");
-        ret = TRAP_invalid_op;
-        goto inject;
+        hvm_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
+        return;
     }
 
     page = nsvm_get_nvmcb_page(v, vmcbaddr);
@@ -2087,8 +2086,8 @@ svm_vmexit_do_vmload(struct vmcb_struct
     {
         gdprintk(XENLOG_ERR,
             "VMLOAD: mapping failed, injecting #GP\n");
-        ret = TRAP_gp_fault;
-        goto inject;
+        hvm_inject_hw_exception(TRAP_gp_fault, 0);
+        return;
     }
 
     svm_vmload_pa(page_to_maddr(page));
@@ -2098,11 +2097,6 @@ svm_vmexit_do_vmload(struct vmcb_struct
     v->arch.hvm_svm.vmcb_in_sync = 0;
 
     __update_guest_eip(regs, inst_len);
-    return;
-
- inject:
-    hvm_inject_hw_exception(ret, HVM_DELIVER_NO_ERROR_CODE);
-    return;
 }
 
 static void
@@ -2110,7 +2104,6 @@ svm_vmexit_do_vmsave(struct vmcb_struct
                      struct cpu_user_regs *regs,
                      struct vcpu *v, uint64_t vmcbaddr)
 {
-    int ret;
     unsigned int inst_len;
     struct page_info *page;
 
@@ -2120,8 +2113,8 @@ svm_vmexit_do_vmsave(struct vmcb_struct
     if ( !nsvm_efer_svm_enabled(v) ) 
     {
         gdprintk(XENLOG_ERR, "VMSAVE: nestedhvm disabled, injecting #UD\n");
-        ret = TRAP_invalid_op;
-        goto inject;
+        hvm_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
+        return;
     }
 
     page = nsvm_get_nvmcb_page(v, vmcbaddr);
@@ -2129,18 +2122,13 @@ svm_vmexit_do_vmsave(struct vmcb_struct
     {
         gdprintk(XENLOG_ERR,
             "VMSAVE: mapping vmcb failed, injecting #GP\n");
-        ret = TRAP_gp_fault;
-        goto inject;
+        hvm_inject_hw_exception(TRAP_gp_fault, 0);
+        return;
     }
 
     svm_vmsave_pa(page_to_maddr(page));
     put_page(page);
     __update_guest_eip(regs, inst_len);
-    return;
-
- inject:
-    hvm_inject_hw_exception(ret, HVM_DELIVER_NO_ERROR_CODE);
-    return;
 }
 
 static int svm_is_erratum_383(struct cpu_user_regs *regs)




[-- Attachment #2: SVM-GP-error-code.patch --]
[-- Type: text/plain, Size: 3025 bytes --]

x86/SVM: don't deliver #GP without error code

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -2029,7 +2029,7 @@ svm_vmexit_do_vmrun(struct cpu_user_regs
     if ( !nestedsvm_vmcb_map(v, vmcbaddr) )
     {
         gdprintk(XENLOG_ERR, "VMRUN: mapping vmcb failed, injecting #GP\n");
-        hvm_inject_hw_exception(TRAP_gp_fault, HVM_DELIVER_NO_ERROR_CODE);
+        hvm_inject_hw_exception(TRAP_gp_fault, 0);
         return;
     }
 
@@ -2068,7 +2068,6 @@ svm_vmexit_do_vmload(struct vmcb_struct
                      struct cpu_user_regs *regs,
                      struct vcpu *v, uint64_t vmcbaddr)
 {
-    int ret;
     unsigned int inst_len;
     struct page_info *page;
 
@@ -2078,8 +2077,8 @@ svm_vmexit_do_vmload(struct vmcb_struct
     if ( !nsvm_efer_svm_enabled(v) ) 
     {
         gdprintk(XENLOG_ERR, "VMLOAD: nestedhvm disabled, injecting #UD\n");
-        ret = TRAP_invalid_op;
-        goto inject;
+        hvm_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
+        return;
     }
 
     page = nsvm_get_nvmcb_page(v, vmcbaddr);
@@ -2087,8 +2086,8 @@ svm_vmexit_do_vmload(struct vmcb_struct
     {
         gdprintk(XENLOG_ERR,
             "VMLOAD: mapping failed, injecting #GP\n");
-        ret = TRAP_gp_fault;
-        goto inject;
+        hvm_inject_hw_exception(TRAP_gp_fault, 0);
+        return;
     }
 
     svm_vmload_pa(page_to_maddr(page));
@@ -2098,11 +2097,6 @@ svm_vmexit_do_vmload(struct vmcb_struct
     v->arch.hvm_svm.vmcb_in_sync = 0;
 
     __update_guest_eip(regs, inst_len);
-    return;
-
- inject:
-    hvm_inject_hw_exception(ret, HVM_DELIVER_NO_ERROR_CODE);
-    return;
 }
 
 static void
@@ -2110,7 +2104,6 @@ svm_vmexit_do_vmsave(struct vmcb_struct
                      struct cpu_user_regs *regs,
                      struct vcpu *v, uint64_t vmcbaddr)
 {
-    int ret;
     unsigned int inst_len;
     struct page_info *page;
 
@@ -2120,8 +2113,8 @@ svm_vmexit_do_vmsave(struct vmcb_struct
     if ( !nsvm_efer_svm_enabled(v) ) 
     {
         gdprintk(XENLOG_ERR, "VMSAVE: nestedhvm disabled, injecting #UD\n");
-        ret = TRAP_invalid_op;
-        goto inject;
+        hvm_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
+        return;
     }
 
     page = nsvm_get_nvmcb_page(v, vmcbaddr);
@@ -2129,18 +2122,13 @@ svm_vmexit_do_vmsave(struct vmcb_struct
     {
         gdprintk(XENLOG_ERR,
             "VMSAVE: mapping vmcb failed, injecting #GP\n");
-        ret = TRAP_gp_fault;
-        goto inject;
+        hvm_inject_hw_exception(TRAP_gp_fault, 0);
+        return;
     }
 
     svm_vmsave_pa(page_to_maddr(page));
     put_page(page);
     __update_guest_eip(regs, inst_len);
-    return;
-
- inject:
-    hvm_inject_hw_exception(ret, HVM_DELIVER_NO_ERROR_CODE);
-    return;
 }
 
 static int svm_is_erratum_383(struct cpu_user_regs *regs)

[-- Attachment #3: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] x86/SVM: don't deliver #GP without error code
  2016-11-24 14:13 [PATCH] x86/SVM: don't deliver #GP without error code Jan Beulich
@ 2016-11-24 14:19 ` Andrew Cooper
  2016-11-24 14:33   ` Jan Beulich
  2016-11-24 15:40 ` [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD with an " Andrew Cooper
  2016-11-28 13:45 ` [PATCH] x86/SVM: don't deliver #GP without " Boris Ostrovsky
  2 siblings, 1 reply; 13+ messages in thread
From: Andrew Cooper @ 2016-11-24 14:19 UTC (permalink / raw)
  To: Jan Beulich, xen-devel; +Cc: Boris Ostrovsky, Wei Liu, Suravee Suthikulpanit

On 24/11/16 14:13, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

There is an opposite problem on the Intel side, delivering some #UD with
an error code (although the guest behaviour does appear to be correct,
so perhaps hardware swallows it).  I will do a companion fix.

As this interacts with my 191 series, shall I put this patch into my
series and rebase properly over it.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] x86/SVM: don't deliver #GP without error code
  2016-11-24 14:19 ` Andrew Cooper
@ 2016-11-24 14:33   ` Jan Beulich
  2016-11-24 14:36     ` Wei Liu
  2016-11-24 14:37     ` Andrew Cooper
  0 siblings, 2 replies; 13+ messages in thread
From: Jan Beulich @ 2016-11-24 14:33 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: xen-devel, Boris Ostrovsky, Wei Liu, Suravee Suthikulpanit

>>> On 24.11.16 at 15:19, <andrew.cooper3@citrix.com> wrote:
> On 24/11/16 14:13, Jan Beulich wrote:
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> There is an opposite problem on the Intel side, delivering some #UD with
> an error code (although the guest behaviour does appear to be correct,
> so perhaps hardware swallows it).  I will do a companion fix.

Oh - I did go through and checked the #GP-s, but didn't think of
also checking the other way around.

> As this interacts with my 191 series, shall I put this patch into my
> series and rebase properly over it.

Well, I would hope for the one here to still go in for 4.8, whereas
your series is targeting 4.9 only aiui.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] x86/SVM: don't deliver #GP without error code
  2016-11-24 14:33   ` Jan Beulich
@ 2016-11-24 14:36     ` Wei Liu
  2016-11-24 14:37     ` Andrew Cooper
  1 sibling, 0 replies; 13+ messages in thread
From: Wei Liu @ 2016-11-24 14:36 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Andrew Cooper, Boris Ostrovsky, Wei Liu, Suravee Suthikulpanit,
	xen-devel

On Thu, Nov 24, 2016 at 07:33:48AM -0700, Jan Beulich wrote:
> >>> On 24.11.16 at 15:19, <andrew.cooper3@citrix.com> wrote:
> > On 24/11/16 14:13, Jan Beulich wrote:
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> > Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > 
> > There is an opposite problem on the Intel side, delivering some #UD with
> > an error code (although the guest behaviour does appear to be correct,
> > so perhaps hardware swallows it).  I will do a companion fix.
> 
> Oh - I did go through and checked the #GP-s, but didn't think of
> also checking the other way around.
> 
> > As this interacts with my 191 series, shall I put this patch into my
> > series and rebase properly over it.
> 
> Well, I would hope for the one here to still go in for 4.8, whereas
> your series is targeting 4.9 only aiui.

Release-acked-by: Wei Liu <wei.liu2@citrix.com>

Please apply this by Friday, otherwise it needs to be backported.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] x86/SVM: don't deliver #GP without error code
  2016-11-24 14:33   ` Jan Beulich
  2016-11-24 14:36     ` Wei Liu
@ 2016-11-24 14:37     ` Andrew Cooper
  1 sibling, 0 replies; 13+ messages in thread
From: Andrew Cooper @ 2016-11-24 14:37 UTC (permalink / raw)
  To: Jan Beulich; +Cc: xen-devel, Boris Ostrovsky, Wei Liu, Suravee Suthikulpanit

On 24/11/16 14:33, Jan Beulich wrote:
>>>> On 24.11.16 at 15:19, <andrew.cooper3@citrix.com> wrote:
>> On 24/11/16 14:13, Jan Beulich wrote:
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
>> There is an opposite problem on the Intel side, delivering some #UD with
>> an error code (although the guest behaviour does appear to be correct,
>> so perhaps hardware swallows it).  I will do a companion fix.
> Oh - I did go through and checked the #GP-s, but didn't think of
> also checking the other way around.
>
>> As this interacts with my 191 series, shall I put this patch into my
>> series and rebase properly over it.
> Well, I would hope for the one here to still go in for 4.8, whereas
> your series is targeting 4.9 only aiui.

Either way, it is now currently in my series and I have rebased over
it.  If it goes in earlier, git will DTRT when rebasing onto a newer
staging.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD with an error code
  2016-11-24 14:13 [PATCH] x86/SVM: don't deliver #GP without error code Jan Beulich
  2016-11-24 14:19 ` Andrew Cooper
@ 2016-11-24 15:40 ` Andrew Cooper
  2016-11-24 15:40   ` [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC " Andrew Cooper
                     ` (2 more replies)
  2016-11-28 13:45 ` [PATCH] x86/SVM: don't deliver #GP without " Boris Ostrovsky
  2 siblings, 3 replies; 13+ messages in thread
From: Andrew Cooper @ 2016-11-24 15:40 UTC (permalink / raw)
  To: Xen-devel; +Cc: Andrew Cooper, Paul Durrant, Wei Liu, Jan Beulich

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Paul Durrant <paul.durrant@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/hvm/emulate.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
index 5f34991..f1f6e2f 100644
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -1696,7 +1696,8 @@ static int hvmemul_vmfunc(
 
     rc = hvm_funcs.altp2m_vcpu_emulate_vmfunc(ctxt->regs);
     if ( rc != X86EMUL_OKAY )
-        hvmemul_inject_hw_exception(TRAP_invalid_op, 0, ctxt);
+        hvmemul_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE,
+                                    ctxt);
 
     return rc;
 }
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC with an error code
  2016-11-24 15:40 ` [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD with an " Andrew Cooper
@ 2016-11-24 15:40   ` Andrew Cooper
  2016-11-24 15:45     ` Wei Liu
                       ` (2 more replies)
  2016-11-24 15:45   ` [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD " Wei Liu
  2016-11-24 16:08   ` Jan Beulich
  2 siblings, 3 replies; 13+ messages in thread
From: Andrew Cooper @ 2016-11-24 15:40 UTC (permalink / raw)
  To: Xen-devel; +Cc: Andrew Cooper, Kevin Tian, Wei Liu, Jun Nakajima, Jan Beulich

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/hvm/vmx/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 0a52624..7b2c50c 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -2915,7 +2915,7 @@ static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content)
 
         if ( (rc < 0) ||
              (msr_content && (vmx_add_host_load_msr(msr) < 0)) )
-            hvm_inject_hw_exception(TRAP_machine_check, 0);
+            hvm_inject_hw_exception(TRAP_machine_check, HVM_DELIVER_NO_ERROR_CODE);
         else
             __vmwrite(GUEST_IA32_DEBUGCTL, msr_content);
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD with an error code
  2016-11-24 15:40 ` [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD with an " Andrew Cooper
  2016-11-24 15:40   ` [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC " Andrew Cooper
@ 2016-11-24 15:45   ` Wei Liu
  2016-11-24 16:08   ` Jan Beulich
  2 siblings, 0 replies; 13+ messages in thread
From: Wei Liu @ 2016-11-24 15:45 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Paul Durrant, Wei Liu, Jan Beulich, Xen-devel

On Thu, Nov 24, 2016 at 03:40:43PM +0000, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Release-acked-by: Wei Liu <wei.liu2@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC with an error code
  2016-11-24 15:40   ` [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC " Andrew Cooper
@ 2016-11-24 15:45     ` Wei Liu
  2016-11-24 16:08     ` Jan Beulich
  2016-11-25  0:04     ` Tian, Kevin
  2 siblings, 0 replies; 13+ messages in thread
From: Wei Liu @ 2016-11-24 15:45 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Kevin Tian, Wei Liu, Jun Nakajima, Jan Beulich, Xen-devel

On Thu, Nov 24, 2016 at 03:40:44PM +0000, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Release-acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD with an error code
  2016-11-24 15:40 ` [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD with an " Andrew Cooper
  2016-11-24 15:40   ` [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC " Andrew Cooper
  2016-11-24 15:45   ` [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD " Wei Liu
@ 2016-11-24 16:08   ` Jan Beulich
  2 siblings, 0 replies; 13+ messages in thread
From: Jan Beulich @ 2016-11-24 16:08 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Paul Durrant, Wei Liu, Xen-devel

>>> On 24.11.16 at 16:40, <andrew.cooper3@citrix.com> wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC with an error code
  2016-11-24 15:40   ` [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC " Andrew Cooper
  2016-11-24 15:45     ` Wei Liu
@ 2016-11-24 16:08     ` Jan Beulich
  2016-11-25  0:04     ` Tian, Kevin
  2 siblings, 0 replies; 13+ messages in thread
From: Jan Beulich @ 2016-11-24 16:08 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Kevin Tian, Wei Liu, Jun Nakajima, Xen-devel

>>> On 24.11.16 at 16:40, <andrew.cooper3@citrix.com> wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC with an error code
  2016-11-24 15:40   ` [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC " Andrew Cooper
  2016-11-24 15:45     ` Wei Liu
  2016-11-24 16:08     ` Jan Beulich
@ 2016-11-25  0:04     ` Tian, Kevin
  2 siblings, 0 replies; 13+ messages in thread
From: Tian, Kevin @ 2016-11-25  0:04 UTC (permalink / raw)
  To: Andrew Cooper, Xen-devel; +Cc: Wei Liu, Nakajima, Jun, Jan Beulich

> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
> Sent: Thursday, November 24, 2016 11:41 PM
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Jun Nakajima <jun.nakajima@intel.com>
> CC: Kevin Tian <kevin.tian@intel.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> ---
>  xen/arch/x86/hvm/vmx/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Kevin Tian <kevin.tian@intel.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] x86/SVM: don't deliver #GP without error code
  2016-11-24 14:13 [PATCH] x86/SVM: don't deliver #GP without error code Jan Beulich
  2016-11-24 14:19 ` Andrew Cooper
  2016-11-24 15:40 ` [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD with an " Andrew Cooper
@ 2016-11-28 13:45 ` Boris Ostrovsky
  2 siblings, 0 replies; 13+ messages in thread
From: Boris Ostrovsky @ 2016-11-28 13:45 UTC (permalink / raw)
  To: Jan Beulich, xen-devel; +Cc: Andrew Cooper, Wei Liu, Suravee Suthikulpanit

On 11/24/2016 09:13 AM, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

(even though it's already been applied)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2016-11-28 13:43 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 14:13 [PATCH] x86/SVM: don't deliver #GP without error code Jan Beulich
2016-11-24 14:19 ` Andrew Cooper
2016-11-24 14:33   ` Jan Beulich
2016-11-24 14:36     ` Wei Liu
2016-11-24 14:37     ` Andrew Cooper
2016-11-24 15:40 ` [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD with an " Andrew Cooper
2016-11-24 15:40   ` [PATCH for-4.8 2/2] x86/vmx: Don't deliver #MC " Andrew Cooper
2016-11-24 15:45     ` Wei Liu
2016-11-24 16:08     ` Jan Beulich
2016-11-25  0:04     ` Tian, Kevin
2016-11-24 15:45   ` [PATCH for-4.8 1/2] x86/emul: Don't deliver #UD " Wei Liu
2016-11-24 16:08   ` Jan Beulich
2016-11-28 13:45 ` [PATCH] x86/SVM: don't deliver #GP without " Boris Ostrovsky

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.