From: Dan Carpenter <dan.carpenter@oracle.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: wharms@bfs.de, linux-media@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Sakari Alius <sakari.ailus@iki.fi>
Subject: Re: [patch] [media] uvcvideo: freeing an error pointer
Date: Fri, 25 Nov 2016 19:20:24 +0000 [thread overview]
Message-ID: <20161125192024.GI6266@mwanda> (raw)
In-Reply-To: <11316049.HORSOXRmDr@avalon>
On Fri, Nov 25, 2016 at 06:02:45PM +0200, Laurent Pinchart wrote:
> Sakari Ailus (CC'ed) has expressed the opinion that we might want to go one
> step further and treat error pointers the same way we treat NULL or ZERO
> pointers today, by just returning without logging anything. The reasoning is
> that accepting a NULL pointer in kfree() was decided before we made extensive
> use of allocation APIs returning error pointers, so it could be time to update
> kfree() based on the current allocation usage patterns.
Just don't free things that haven't been allocated. That honestly seems
like a simple rule to me, whenever I touch error handling code it feels
better and simpler after I fix the bugs. Error handling doesn't have to
be complicated if you just follow the rules.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: wharms@bfs.de, linux-media@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Sakari Alius <sakari.ailus@iki.fi>
Subject: Re: [patch] [media] uvcvideo: freeing an error pointer
Date: Fri, 25 Nov 2016 22:20:24 +0300 [thread overview]
Message-ID: <20161125192024.GI6266@mwanda> (raw)
In-Reply-To: <11316049.HORSOXRmDr@avalon>
On Fri, Nov 25, 2016 at 06:02:45PM +0200, Laurent Pinchart wrote:
> Sakari Ailus (CC'ed) has expressed the opinion that we might want to go one
> step further and treat error pointers the same way we treat NULL or ZERO
> pointers today, by just returning without logging anything. The reasoning is
> that accepting a NULL pointer in kfree() was decided before we made extensive
> use of allocation APIs returning error pointers, so it could be time to update
> kfree() based on the current allocation usage patterns.
Just don't free things that haven't been allocated. That honestly seems
like a simple rule to me, whenever I touch error handling code it feels
better and simpler after I fix the bugs. Error handling doesn't have to
be complicated if you just follow the rules.
regards,
dan carpenter
next prev parent reply other threads:[~2016-11-25 19:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 10:28 [patch] [media] uvcvideo: freeing an error pointer Dan Carpenter
2016-11-25 10:28 ` Dan Carpenter
2016-11-25 13:40 ` SF Markus Elfring
2016-11-25 13:40 ` SF Markus Elfring
2016-11-25 13:57 ` Laurent Pinchart
2016-11-25 13:57 ` Laurent Pinchart
2016-11-25 14:47 ` walter harms
2016-11-25 14:47 ` walter harms
2016-11-25 16:02 ` Laurent Pinchart
2016-11-25 16:02 ` Laurent Pinchart
2016-11-25 19:20 ` Dan Carpenter [this message]
2016-11-25 19:20 ` Dan Carpenter
2016-11-27 16:21 ` Sakari Alius
2016-11-27 16:21 ` Sakari Alius
2016-11-28 13:49 ` Dan Carpenter
2016-11-28 13:49 ` Dan Carpenter
2016-11-28 13:54 ` Julia Lawall
2016-11-28 13:54 ` Julia Lawall
2016-11-28 14:49 ` Laurent Pinchart
2016-11-28 14:49 ` Laurent Pinchart
2016-11-30 12:33 ` Dan Carpenter
2016-11-30 12:33 ` Dan Carpenter
2016-11-30 13:53 ` Laurent Pinchart
2016-11-30 13:53 ` Laurent Pinchart
2016-11-30 14:45 ` Dan Carpenter
2016-11-30 14:45 ` Dan Carpenter
2016-11-29 6:48 ` Julia Lawall
2016-11-29 6:48 ` Julia Lawall
2016-11-25 19:08 ` Dan Carpenter
2016-11-25 19:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161125192024.GI6266@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.