From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jinshan Xiong <jinshan.xiong@intel.com>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH v2] staging: lustre: osc: Performance tune for LRU
Date: Sat, 26 Nov 2016 01:12:41 +0300 [thread overview]
Message-ID: <20161125221241.GN6266@mwanda> (raw)
In-Reply-To: <1479942105-30220-1-git-send-email-jsimmons@infradead.org>
On Wed, Nov 23, 2016 at 06:01:45PM -0500, James Simmons wrote:
> From: Jinshan Xiong <jinshan.xiong@intel.com>
>
> Early launch page LRU work in osc_io_rw_iter_init();
> Change the page LRU shrinking policy by OSC attributes;
> Delete the contented lock osc_object::oo_seatbelt
>
The cli_name() stuff should be in a separate patch. It's hard to review
this stuff (or possibly I just found the first deal breaker and gave
up).
Anyway, please review this again and break it up into separate patches.
regards,
dan carpenter
PS: I glanced at the patch again and the very first line is changing
"lru" to "LRU" in a comment. We'll get a million performance increases
from that I bet. Don't mix random white space changes into it...
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jinshan Xiong <jinshan.xiong@intel.com>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH v2] staging: lustre: osc: Performance tune for LRU
Date: Sat, 26 Nov 2016 01:12:41 +0300 [thread overview]
Message-ID: <20161125221241.GN6266@mwanda> (raw)
In-Reply-To: <1479942105-30220-1-git-send-email-jsimmons@infradead.org>
On Wed, Nov 23, 2016 at 06:01:45PM -0500, James Simmons wrote:
> From: Jinshan Xiong <jinshan.xiong@intel.com>
>
> Early launch page LRU work in osc_io_rw_iter_init();
> Change the page LRU shrinking policy by OSC attributes;
> Delete the contented lock osc_object::oo_seatbelt
>
The cli_name() stuff should be in a separate patch. It's hard to review
this stuff (or possibly I just found the first deal breaker and gave
up).
Anyway, please review this again and break it up into separate patches.
regards,
dan carpenter
PS: I glanced at the patch again and the very first line is changing
"lru" to "LRU" in a comment. We'll get a million performance increases
from that I bet. Don't mix random white space changes into it...
next prev parent reply other threads:[~2016-11-25 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 23:01 [lustre-devel] [PATCH v2] staging: lustre: osc: Performance tune for LRU James Simmons
2016-11-23 23:01 ` James Simmons
2016-11-25 22:12 ` Dan Carpenter [this message]
2016-11-25 22:12 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161125221241.GN6266@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinshan.xiong@intel.com \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.