All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support
Date: Sun, 27 Nov 2016 23:08:46 +0100	[thread overview]
Message-ID: <20161127220846.GH13318@lunn.ch> (raw)
In-Reply-To: <9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de>

> > This driver already supports nearly 30 different Marvell switch
> > models. Please document why the marvell,mv88e6176 is special and why
> > it needs its own compatible string when the others don't.
> 
> I don't understand.

Think about what i said. Why does the 6176 need its own compatible
string, when the two 6352s and the 6165 on the zii-devel-b don't have
one? And the DIR 665 has a 6171, which does not have a compatible
string of its own. The clearfog actually has a 6176, and it seems to
work fine without a compatible string.

> You as driver author should know that the .data pointer is vital to your
> driver

Exactly, so if i ask why is it needed, maybe you should stop and think
for a while.

> you even recently accepted another model that conflicted with
> my patch.

And think about that also, and you will find the 6390 family, who's
first device is 6190, is not compatible with the 6085, and so needs a
different compatible string.

	  Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: "Andreas Färber" <afaerber@suse.de>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Michal Hrusecki" <Michal.Hrusecky@nic.cz>,
	"Tomas Hlavacek" <tomas.hlavacek@nic.cz>,
	"Bed??icha Ko??atu" <bedrich.kosata@nic.cz>,
	"Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support
Date: Sun, 27 Nov 2016 23:08:46 +0100	[thread overview]
Message-ID: <20161127220846.GH13318@lunn.ch> (raw)
In-Reply-To: <9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de>

> > This driver already supports nearly 30 different Marvell switch
> > models. Please document why the marvell,mv88e6176 is special and why
> > it needs its own compatible string when the others don't.
> 
> I don't understand.

Think about what i said. Why does the 6176 need its own compatible
string, when the two 6352s and the 6165 on the zii-devel-b don't have
one? And the DIR 665 has a 6171, which does not have a compatible
string of its own. The clearfog actually has a 6176, and it seems to
work fine without a compatible string.

> You as driver author should know that the .data pointer is vital to your
> driver

Exactly, so if i ask why is it needed, maybe you should stop and think
for a while.

> you even recently accepted another model that conflicted with
> my patch.

And think about that also, and you will find the 6390 family, who's
first device is 6190, is not compatible with the 6085, and so needs a
different compatible string.

	  Andrew

  reply	other threads:[~2016-11-27 22:08 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-27 20:57 [PATCH 1/2] Documentation: net: dsa: marvell: Add 88E6176 Andreas Färber
2016-11-27 20:57 ` Andreas Färber
2016-11-27 20:57 ` Andreas Färber
2016-11-27 20:57 ` [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andreas Färber
2016-11-27 20:57   ` Andreas Färber
2016-11-27 21:27   ` Andrew Lunn
2016-11-27 21:27     ` Andrew Lunn
2016-11-27 21:50     ` Andreas Färber
2016-11-27 21:50       ` Andreas Färber
2016-11-27 21:50       ` Andreas Färber
2016-11-27 22:08       ` Andrew Lunn [this message]
2016-11-27 22:08         ` Andrew Lunn
2016-11-27 22:42         ` Andreas Färber
2016-11-27 22:42           ` Andreas Färber
2016-11-27 23:10           ` Andrew Lunn
2016-11-27 23:10             ` Andrew Lunn
2016-11-28  8:09             ` Uwe Kleine-König
2016-11-28  8:09               ` Uwe Kleine-König
2016-11-28 13:17               ` Andrew Lunn
2016-11-28 13:17                 ` Andrew Lunn
2016-11-28 13:17                 ` Andrew Lunn
2016-11-28 15:44                 ` Uwe Kleine-König
2016-11-28 15:44                   ` Uwe Kleine-König
2016-11-28 15:44                   ` Uwe Kleine-König
2016-11-28 16:14                   ` Andrew Lunn
2016-11-28 16:14                     ` Andrew Lunn
2016-11-28 16:14                     ` Andrew Lunn
2016-11-29 17:54                   ` Vivien Didelot
2016-11-29 17:54                     ` Vivien Didelot
2016-11-29 18:20                     ` Andrew Lunn
2016-11-29 18:20                       ` Andrew Lunn
2016-11-29 18:20                       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161127220846.GH13318@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.