From: Shaohua Li <shli@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Song Liu <songliubraving@fb.com>,
linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] md/r5cache: enable IRQs on error path
Date: Mon, 28 Nov 2016 05:37:54 +0000 [thread overview]
Message-ID: <20161128053754.cbppd4ada3oe6klw@kernel.org> (raw)
In-Reply-To: <20161124111304.GI17225@mwanda>
On Thu, Nov 24, 2016 at 02:13:04PM +0300, Dan Carpenter wrote:
> We need to re-enable the IRQs here before returning.
>
> Fixes: a39f7afde358 ("md/r5cache: write-out phase and reclaim support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks!
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 2a60ce4..6610134 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1029,7 +1029,7 @@ static sector_t r5c_calculate_new_cp(struct r5conf *conf)
> spin_lock_irqsave(&log->stripe_in_journal_lock, flags);
> if (list_empty(&conf->log->stripe_in_journal_list)) {
> /* all stripes flushed */
> - spin_unlock(&log->stripe_in_journal_lock);
> + spin_unlock_irqrestore(&log->stripe_in_journal_lock, flags);
> return log->next_checkpoint;
> }
> sh = list_first_entry(&conf->log->stripe_in_journal_list,
WARNING: multiple messages have this Message-ID (diff)
From: Shaohua Li <shli@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Song Liu <songliubraving@fb.com>,
linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] md/r5cache: enable IRQs on error path
Date: Sun, 27 Nov 2016 21:37:54 -0800 [thread overview]
Message-ID: <20161128053754.cbppd4ada3oe6klw@kernel.org> (raw)
In-Reply-To: <20161124111304.GI17225@mwanda>
On Thu, Nov 24, 2016 at 02:13:04PM +0300, Dan Carpenter wrote:
> We need to re-enable the IRQs here before returning.
>
> Fixes: a39f7afde358 ("md/r5cache: write-out phase and reclaim support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks!
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 2a60ce4..6610134 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1029,7 +1029,7 @@ static sector_t r5c_calculate_new_cp(struct r5conf *conf)
> spin_lock_irqsave(&log->stripe_in_journal_lock, flags);
> if (list_empty(&conf->log->stripe_in_journal_list)) {
> /* all stripes flushed */
> - spin_unlock(&log->stripe_in_journal_lock);
> + spin_unlock_irqrestore(&log->stripe_in_journal_lock, flags);
> return log->next_checkpoint;
> }
> sh = list_first_entry(&conf->log->stripe_in_journal_list,
next prev parent reply other threads:[~2016-11-28 5:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 11:13 [patch] md/r5cache: enable IRQs on error path Dan Carpenter
2016-11-24 11:13 ` Dan Carpenter
2016-11-28 5:37 ` Shaohua Li [this message]
2016-11-28 5:37 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128053754.cbppd4ada3oe6klw@kernel.org \
--to=shli@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.