From: Benoit Parrot <bparrot@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Nikhil Devshatwar <nikhil.nd@ti.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] media: ti-vpe: vpdma: fix a timeout loop
Date: Mon, 28 Nov 2016 16:51:37 +0000 [thread overview]
Message-ID: <20161128165137.GE5954@ti.com> (raw)
In-Reply-To: <20161125201957.GA30161@mwanda>
Dan,
Thanks for the patch.
Acked-by: Benoit Parrot <bparrot@ti.com>
Dan Carpenter <dan.carpenter@oracle.com> wrote on Sat [2016-Nov-26 00:28:34 +0300]:
> The check assumes that we end on zero but actually we end on -1. Change
> the post-op to a pre-op so that we do end on zero. Techinically now we
> only loop 499 times instead of 500 but that's fine.
>
> Fixes: dc12b124353b ("[media] media: ti-vpe: vpdma: Add abort channel desc and cleanup APIs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> index 13bfd71..23472e3 100644
> --- a/drivers/media/platform/ti-vpe/vpdma.c
> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> @@ -453,7 +453,7 @@ int vpdma_list_cleanup(struct vpdma_data *vpdma, int list_num,
> if (ret)
> return ret;
>
> - while (vpdma_list_busy(vpdma, list_num) && timeout--)
> + while (vpdma_list_busy(vpdma, list_num) && --timeout)
> ;
>
> if (timeout = 0) {
WARNING: multiple messages have this Message-ID (diff)
From: Benoit Parrot <bparrot@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Nikhil Devshatwar <nikhil.nd@ti.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
<linux-media@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [patch] [media] media: ti-vpe: vpdma: fix a timeout loop
Date: Mon, 28 Nov 2016 10:51:37 -0600 [thread overview]
Message-ID: <20161128165137.GE5954@ti.com> (raw)
In-Reply-To: <20161125201957.GA30161@mwanda>
Dan,
Thanks for the patch.
Acked-by: Benoit Parrot <bparrot@ti.com>
Dan Carpenter <dan.carpenter@oracle.com> wrote on Sat [2016-Nov-26 00:28:34 +0300]:
> The check assumes that we end on zero but actually we end on -1. Change
> the post-op to a pre-op so that we do end on zero. Techinically now we
> only loop 499 times instead of 500 but that's fine.
>
> Fixes: dc12b124353b ("[media] media: ti-vpe: vpdma: Add abort channel desc and cleanup APIs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> index 13bfd71..23472e3 100644
> --- a/drivers/media/platform/ti-vpe/vpdma.c
> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> @@ -453,7 +453,7 @@ int vpdma_list_cleanup(struct vpdma_data *vpdma, int list_num,
> if (ret)
> return ret;
>
> - while (vpdma_list_busy(vpdma, list_num) && timeout--)
> + while (vpdma_list_busy(vpdma, list_num) && --timeout)
> ;
>
> if (timeout == 0) {
next prev parent reply other threads:[~2016-11-28 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 21:28 [patch] [media] media: ti-vpe: vpdma: fix a timeout loop Dan Carpenter
2016-11-25 21:28 ` Dan Carpenter
2016-11-28 16:51 ` Benoit Parrot [this message]
2016-11-28 16:51 ` Benoit Parrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128165137.GE5954@ti.com \
--to=bparrot@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nikhil.nd@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.