All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/tvheadend: bump version to v4.1-2345 and fix version reporting
Date: Mon, 28 Nov 2016 22:03:15 +0100	[thread overview]
Message-ID: <20161128220315.1924903c@free-electrons.com> (raw)
In-Reply-To: <20161128103231.21626-1-damjan.marion@gmail.com>

Hello,

On Mon, 28 Nov 2016 11:32:31 +0100, Damjan Marion wrote:
> tvheadedend tracks version information based on git version
> numbers. As tvheadend is downloaded as tarball form github
> it was reporting version 0.0.0~unknown.
> 
> Signed-off-by: Damjan Marion <damjan.marion@gmail.com>

Could you split the bump and the version fix reporting in two separate
patches?

> -TVHEADEND_VERSION = 50a370707aedf5c127e92bb517c378aa8ac04657
> +TVHEADEND_VERSION = v4.1-2345-g04ff649

Please keep this as a full hash, like it used to be. It should still
work fine with the version reporting, if you write this version to
$(@D)/rpm/version, like you're doing below.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2016-11-28 21:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 10:32 [Buildroot] [PATCH] package/tvheadend: bump version to v4.1-2345 and fix version reporting Damjan Marion
2016-11-28 10:44 ` Baruch Siach
2016-11-28 10:50   ` Damjan Marion
2016-11-28 21:03 ` Thomas Petazzoni [this message]
2016-11-28 21:08   ` Damjan Marion
2016-11-28 21:13     ` Thomas Petazzoni
2016-11-28 21:24       ` Damjan Marion
2016-11-28 21:43         ` Thomas Petazzoni
2016-11-28 21:49           ` Damjan Marion
2016-11-29 23:28   ` Arnout Vandecappelle
2016-11-30  5:34     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161128220315.1924903c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.