All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/tvheadend: bump version to v4.1-2345 and fix version reporting
Date: Mon, 28 Nov 2016 22:43:26 +0100	[thread overview]
Message-ID: <20161128224326.4199d3f3@free-electrons.com> (raw)
In-Reply-To: <B12CF9A8-74C8-438D-8DB3-9AB9E45F91FD@gmail.com>

Hello,

On Mon, 28 Nov 2016 22:24:20 +0100, Damjan Marion wrote:

> > Because we're using a full hash in every other package fetched from Git
> > in Buildroot, and we like consistency :)  
> 
> Unfortunately that was only meaningful way (I?m aware of) to provide some
> human-readable version information out from their repo.

Well, the full hash is by far the most precise and exact information.
Anyone having the Git repository can do "git checkout <hash>" and get
straight to the exact same commit.

> I don't see how is this improvement compared to ?0.0.0~unknown?. I really doubt
> that it is worth time to submit that as a patch?.

Well, 0.0.0~unknown doesn't say anything about the version. The full
hash says it all.

> What about something like:
> 
> TVHEADEND_VERSION = 50a370707aedf5c127e92bb517c378aa8ac04657
> TVHEADEND_PRETTY_VERSION = v4.1-2345-g50a3707  

Which have to be maintained separately :/

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-11-28 21:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 10:32 [Buildroot] [PATCH] package/tvheadend: bump version to v4.1-2345 and fix version reporting Damjan Marion
2016-11-28 10:44 ` Baruch Siach
2016-11-28 10:50   ` Damjan Marion
2016-11-28 21:03 ` Thomas Petazzoni
2016-11-28 21:08   ` Damjan Marion
2016-11-28 21:13     ` Thomas Petazzoni
2016-11-28 21:24       ` Damjan Marion
2016-11-28 21:43         ` Thomas Petazzoni [this message]
2016-11-28 21:49           ` Damjan Marion
2016-11-29 23:28   ` Arnout Vandecappelle
2016-11-30  5:34     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161128224326.4199d3f3@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.