All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: mst@redhat.com, aconole@redhat.com, pbonzini@redhat.com,
	qemu-devel@nongnu.org, fbl@redhat.com, berrange@redhat.com,
	mlureau@redhat.com, ktraynor@redhat.com, jasowang@redhat.com,
	"Harris, James R" <james.r.harris@intel.com>
Subject: Re: [Qemu-devel] [RFC v3 1/3] vhost-user: Add MTU protocol feature and op
Date: Wed, 30 Nov 2016 18:25:44 +0800	[thread overview]
Message-ID: <20161130102544.GS5048@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20161130101017.13382-2-maxime.coquelin@redhat.com>

On Wed, Nov 30, 2016 at 11:10:15AM +0100, Maxime Coquelin wrote:
> +#define VHOST_USER_PROTOCOL_F_MTU            4
>  
>  Message types
>  -------------
> @@ -470,6 +471,18 @@ Message types
>        The first 6 bytes of the payload contain the mac address of the guest to
>        allow the vhost user backend to construct and broadcast the fake RARP.
>  
> + * VHOST_USER_SET_MTU

One thing I have just thought of is that, though we currently have one
vhost-user driver (net), SPDK here (James cc'ed) is proposing vhost-user
for other devices, say SCSI.

So maybe it's better to add some type prefix here, like VHOST_USER_NET_SET_MTU?

	--yliu

  reply	other threads:[~2016-11-30 10:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30 10:10 [Qemu-devel] [RFC v3 0/3] virtio-net: Add support to MTU feature Maxime Coquelin
2016-11-30 10:10 ` [Qemu-devel] [RFC v3 1/3] vhost-user: Add MTU protocol feature and op Maxime Coquelin
2016-11-30 10:25   ` Yuanhan Liu [this message]
2016-11-30 12:17     ` Maxime Coquelin
2016-11-30 10:10 ` [Qemu-devel] [RFC v3 2/3] vhost-net: Notify the backend about the host MTU Maxime Coquelin
2016-12-06 18:31   ` Aaron Conole
2016-12-07  7:49     ` Maxime Coquelin
2016-11-30 10:10 ` [Qemu-devel] [RFC v3 3/3] virtio-net: Add MTU feature support Maxime Coquelin
2016-11-30 11:24   ` Jason Wang
2016-11-30 12:24     ` Maxime Coquelin
2016-11-30 10:30 ` [Qemu-devel] [RFC v3 0/3] virtio-net: Add support to MTU feature no-reply
2016-11-30 11:23 ` Jason Wang
2016-11-30 12:16   ` Maxime Coquelin
2016-11-30 13:42     ` Michael S. Tsirkin
2016-12-05 16:11       ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161130102544.GS5048@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=aconole@redhat.com \
    --cc=berrange@redhat.com \
    --cc=fbl@redhat.com \
    --cc=james.r.harris@intel.com \
    --cc=jasowang@redhat.com \
    --cc=ktraynor@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mlureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.