* [PATCH] usb: host: replace symbolic permission with octal [not found] <CGME20161130134902epcms5p7d33e26394dec3f931fc623bdb023482d@epcms5p7> @ 2016-11-30 13:49 ` Amit Kumar Kushwaha 0 siblings, 0 replies; 4+ messages in thread From: Amit Kumar Kushwaha @ 2016-11-30 13:49 UTC (permalink / raw) To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, akkushwaha9896@gmail.com [-- Attachment #1: Type: text/plain, Size: 991 bytes --] This patch handles warning message for preferring octal permissions over Symbolic permission for module parameter Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com> --- drivers/usb/host/xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 1a4ca02..a953d47 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -40,11 +40,11 @@ /* Some 0.95 hardware can't handle the chain bit on a Link TRB being cleared */ static int link_quirk; -module_param(link_quirk, int, S_IRUGO | S_IWUSR); +module_param(link_quirk, int, 0644); MODULE_PARM_DESC(link_quirk, "Don't clear the chain bit on a link TRB"); static unsigned int quirks; -module_param(quirks, uint, S_IRUGO); +module_param(quirks, uint, 0444); MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default"); /* TODO: copied from ehci-hcd.c - can this be refactored? */ -- 2.10.2.windows.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] usb: host: replace symbolic permission with octal @ 2016-11-30 13:49 ` Amit Kumar Kushwaha 0 siblings, 0 replies; 4+ messages in thread From: Amit Kumar Kushwaha @ 2016-11-30 13:49 UTC (permalink / raw) To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, akkushwaha9896@gmail.com [-- Attachment #1: Type: text/plain, Size: 991 bytes --] This patch handles warning message for preferring octal permissions over Symbolic permission for module parameter Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com> --- drivers/usb/host/xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 1a4ca02..a953d47 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -40,11 +40,11 @@ /* Some 0.95 hardware can't handle the chain bit on a Link TRB being cleared */ static int link_quirk; -module_param(link_quirk, int, S_IRUGO | S_IWUSR); +module_param(link_quirk, int, 0644); MODULE_PARM_DESC(link_quirk, "Don't clear the chain bit on a link TRB"); static unsigned int quirks; -module_param(quirks, uint, S_IRUGO); +module_param(quirks, uint, 0444); MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default"); /* TODO: copied from ehci-hcd.c - can this be refactored? */ -- 2.10.2.windows.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: host: replace symbolic permission with octal 2016-11-30 13:49 ` Amit Kumar Kushwaha @ 2016-11-30 13:56 ` gregkh -1 siblings, 0 replies; 4+ messages in thread From: gregkh @ 2016-11-30 13:56 UTC (permalink / raw) To: Amit Kumar Kushwaha Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, akkushwaha9896@gmail.com On Wed, Nov 30, 2016 at 01:49:02PM +0000, Amit Kumar Kushwaha wrote: > This patch handles warning message for preferring octal > permissions over Symbolic permission for module parameter That makes no sense at all. What warning message? Build time? Run time? Please do cleanup patches on drivers/staging/ until you know how to do them, don't start on the "core" kernel, as you will just annoy maintainers (hint, you cc:ed too many people...) good luck! greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: host: replace symbolic permission with octal @ 2016-11-30 13:56 ` gregkh 0 siblings, 0 replies; 4+ messages in thread From: gregkh @ 2016-11-30 13:56 UTC (permalink / raw) To: Amit Kumar Kushwaha Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, akkushwaha9896@gmail.com On Wed, Nov 30, 2016 at 01:49:02PM +0000, Amit Kumar Kushwaha wrote: > This patch handles warning message for preferring octal > permissions over Symbolic permission for module parameter That makes no sense at all. What warning message? Build time? Run time? Please do cleanup patches on drivers/staging/ until you know how to do them, don't start on the "core" kernel, as you will just annoy maintainers (hint, you cc:ed too many people...) good luck! greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-30 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20161130134902epcms5p7d33e26394dec3f931fc623bdb023482d@epcms5p7>
2016-11-30 13:49 ` [PATCH] usb: host: replace symbolic permission with octal Amit Kumar Kushwaha
2016-11-30 13:49 ` Amit Kumar Kushwaha
2016-11-30 13:56 ` gregkh
2016-11-30 13:56 ` gregkh
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.