From: Keith Busch <keith.busch@intel.com>
To: Scott Bauer <scott.bauer@intel.com>
Cc: linux-nvme@lists.infradead.org, Rafael.Antognolli@intel.com,
axboe@fb.com, jonathan.derrick@intel.com, j.naumann@fu-berlin.de,
hch@infradead.org, linux-block@vger.kernel.org, sagi@grimberg.me
Subject: Re: [PATCH v2 2/4] block: Add Sed-opal library
Date: Wed, 30 Nov 2016 13:13:57 -0500 [thread overview]
Message-ID: <20161130181357.GD21081@localhost.localdomain> (raw)
In-Reply-To: <1480456322-27339-3-git-send-email-scott.bauer@intel.com>
On Tue, Nov 29, 2016 at 02:52:00PM -0700, Scott Bauer wrote:
> + dev = get_or_create_opal_dev(bdev, key->opal_act.key.lr, true);
> + if (!dev)
> + return -ENOMEM;
The alloc_opal_dev from this call returns ERR_PTR values on error, so
the check should be:
if (IS_ERR_OR_NULL(dev))
return PTR_ERR(dev);
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH v2 2/4] block: Add Sed-opal library
Date: Wed, 30 Nov 2016 13:13:57 -0500 [thread overview]
Message-ID: <20161130181357.GD21081@localhost.localdomain> (raw)
In-Reply-To: <1480456322-27339-3-git-send-email-scott.bauer@intel.com>
On Tue, Nov 29, 2016@02:52:00PM -0700, Scott Bauer wrote:
> + dev = get_or_create_opal_dev(bdev, key->opal_act.key.lr, true);
> + if (!dev)
> + return -ENOMEM;
The alloc_opal_dev from this call returns ERR_PTR values on error, so
the check should be:
if (IS_ERR_OR_NULL(dev))
return PTR_ERR(dev);
next prev parent reply other threads:[~2016-11-30 18:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 21:51 [PATCH v2 0/4] SED OPAL Library Scott Bauer
2016-11-29 21:51 ` Scott Bauer
2016-11-29 21:51 ` [PATCH v2 1/4] include: Add definitions for sed Scott Bauer
2016-11-29 21:51 ` Scott Bauer
2016-11-29 21:52 ` [PATCH v2 2/4] block: Add Sed-opal library Scott Bauer
2016-11-29 21:52 ` Scott Bauer
2016-11-30 18:13 ` Keith Busch [this message]
2016-11-30 18:13 ` Keith Busch
2016-11-30 18:09 ` Scott Bauer
2016-11-30 18:09 ` Scott Bauer
2016-12-01 0:50 ` Keith Busch
2016-12-01 0:50 ` Keith Busch
2016-12-01 10:04 ` Christoph Hellwig
2016-12-01 10:04 ` Christoph Hellwig
2016-12-01 17:53 ` Scott Bauer
2016-12-01 17:53 ` Scott Bauer
2016-12-01 18:22 ` Keith Busch
2016-12-01 18:22 ` Keith Busch
2016-12-09 17:45 ` Scott Bauer
2016-12-09 17:45 ` Scott Bauer
2016-12-09 18:30 ` Christoph Hellwig
2016-12-09 18:30 ` Christoph Hellwig
2016-12-09 18:50 ` Scott Bauer
2016-12-09 18:50 ` Scott Bauer
2016-11-29 21:52 ` [PATCH v2 3/4] nvme: Implement resume_from_suspend and sed block ioctl Scott Bauer
2016-11-29 21:52 ` Scott Bauer
2016-12-01 0:50 ` Keith Busch
2016-12-01 0:50 ` Keith Busch
2016-11-29 21:52 ` [PATCH v2 4/4] Maintainers: Add Information for SED Opal library Scott Bauer
2016-11-29 21:52 ` Scott Bauer
2017-02-10 16:46 ` Elliott, Robert (Persistent Memory)
2017-02-10 16:44 ` Scott Bauer
2017-02-11 2:24 ` Elliott, Robert (Persistent Memory)
2017-02-13 8:04 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130181357.GD21081@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=Rafael.Antognolli@intel.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=j.naumann@fu-berlin.de \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=scott.bauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.