From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
robh@kernel.org, d-gerlach@ti.com, broonie@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V6 08/10] PM / OPP: Allow platform specific custom set_opp() callbacks
Date: Wed, 30 Nov 2016 14:04:19 -0800 [thread overview]
Message-ID: <20161130220419.GL6095@codeaurora.org> (raw)
In-Reply-To: <152e4a2c876449f3e47c206f5120cafdfd48b976.1480481312.git.viresh.kumar@linaro.org>
On 11/30, Viresh Kumar wrote:
> The generic set_opp() handler isn't sufficient for platforms with
> complex DVFS. For example, some TI platforms have multiple regulators
> for a CPU device. The order in which various supplies need to be
> programmed is only known to the platform code and its best to leave it
> to it.
>
> This patch implements APIs to register platform specific set_opp()
> callback.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> Tested-by: Dave Gerlach <d-gerlach@ti.com>
>
> ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
So this one has the same set/put problem the other APIs has?
Presumably we're going to need to fix and change the API that is
introduced here. Wouldn't it be better to do that first though?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-30 22:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 5:14 [PATCH V6 00/10] PM / OPP: Multiple regulator support Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 02/10] PM / OPP: Reword binding supporting multiple regulators per device Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 04/10] PM / OPP: Manage supply's voltage/current in a separate structure Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 05/10] PM / OPP: Pass struct dev_pm_opp_supply to _set_opp_voltage() Viresh Kumar
[not found] ` <cover.1480481312.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-11-30 5:14 ` [PATCH V6 01/10] PM / OPP: Fix incorrect cpu-supply property in binding Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 03/10] PM / OPP: Don't use OPP structure outside of rcu protected section Viresh Kumar
2016-11-30 5:14 ` Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 06/10] PM / OPP: Add infrastructure to manage multiple regulators Viresh Kumar
[not found] ` <3b3ce1dac198fb668b97e81490bcbcf03d31e40d.1480481312.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-11-30 22:37 ` Stephen Boyd
2016-12-01 0:51 ` Viresh Kumar
2016-12-01 10:59 ` Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 08/10] PM / OPP: Allow platform specific custom set_opp() callbacks Viresh Kumar
2016-11-30 22:04 ` Stephen Boyd [this message]
[not found] ` <20161130220419.GL6095-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-12-01 0:27 ` Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 09/10] PM / OPP: Don't WARN on multiple calls to dev_pm_opp_set_regulators() Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 10/10] PM / OPP: Don't assume platform doesn't have regulators Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 07/10] PM / OPP: Separate out _generic_set_opp() Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130220419.GL6095@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=broonie@kernel.org \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.