Re: [PATCH V6 06/10] PM / OPP: Add infrastructure to manage multiple regulators

[Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

On 01-12-16, 06:21, Viresh Kumar wrote:
> On 30-11-16, 14:37, Stephen Boyd wrote:
> > > +static bool opp_debug_create_supplies(struct dev_pm_opp *opp,
> > > +				      struct opp_table *opp_table,
> > > +				      struct dentry *pdentry)
> > > +{
> > > +	struct dentry *d;
> > > +	int i = 0;
> > > +	char *name;
> > > +
> > > +	/* Always create at least supply-0 directory */
> > > +	do {
> > > +		name = kasprintf(GFP_KERNEL, "supply-%d", i);
> > 
> > Sorry I haven't noticed this before. Wouldn't we want to put the
> > supply name here instead of a number?
> 
> The OPP core provides a way for platforms to use the set-OPP
> functionality, but that is not compulsory for its user. Which makes it
> very much possible that the OPP core wouldn't know the names of the
> supplies at all. And so I used the numbers here. Anyway, the numbers
> matches the order in which they are passed from DT, so that should be
> readable.
> 
> Here is the new rebased version of the patch. I will send the complete
> series again later on. Please see if it looks fine.
> 
> -------------------------8<-------------------------
> 
> From: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Date: Tue, 4 Oct 2016 17:07:28 +0530
> Subject: [PATCH] PM / OPP: Add infrastructure to manage multiple regulators
> 
> This patch adds infrastructure to manage multiple regulators and updates
> the only user (cpufreq-dt) of dev_pm_opp_set{put}_regulator().
> 
> This is preparatory work for adding full support for devices with
> multiple regulators.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Tested-by: Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>

Ignore this one now. I have resent the series again after resolving
all the pending issues. Please review that.

Thanks.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html