All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	sparclinux@vger.kernel.org, davem@davemloft.net
Subject: Re: next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe
Date: Thu, 01 Dec 2016 12:34:09 +0000	[thread overview]
Message-ID: <20161201123409.GA3924@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161201065657.GA4697@roeck-us.net>

On Wed, Nov 30, 2016 at 10:56:57PM -0800, Guenter Roeck wrote:
> Hi Paul,
> 
> On Wed, Nov 30, 2016 at 05:19:50PM -0800, Paul E. McKenney wrote:
> [ ... ]
> 
> > > > > 
> > > > > BUG: sleeping function called from invalid context at mm/page_alloc.c:3775
> [ ... ]
> > 
> > Whew!  You had me going for a bit there.  ;-)
> 
> Bisect results are here ... the culprit is, again, commit 2d66cccd73 ("mm:
> Prevent __alloc_pages_nodemask() RCU CPU stall warnings"), and reverting that
> patch fixes the problem. Good that you dropped it already :-).

"My work is done."  ;-)

And apologies for the hassle.  I have no idea what I was thinking when
I put the cond_resched_rcu_qs() there!

							Thanx, Paul

> Guenter
> 
> ---
> # bad: [59ab0083490c8a871b51e893bae5806e55901d7e] Add linux-next specific files for 20161130
> # good: [e5517c2a5a49ed5e99047008629f1cd60246ea0e] Linux 4.9-rc7
> git bisect start 'HEAD' 'v4.9-rc7'
> # good: [187f99e5c22bb3fab8b330f3ebbbd235d238f3f8] Merge remote-tracking branch 'crypto/master'
> git bisect good 187f99e5c22bb3fab8b330f3ebbbd235d238f3f8
> # good: [36126657c908e822523b8563f9b1512937c0f342] Merge remote-tracking branch 'tip/auto-latest'
> git bisect good 36126657c908e822523b8563f9b1512937c0f342
> # good: [2d2139c5c746ec61024fdfa9c36e4e034bb18e59] Merge tag 'iio-for-4.10d' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next
> git bisect good 2d2139c5c746ec61024fdfa9c36e4e034bb18e59
> # bad: [926a60551123048c589b45abee2a2ec4c924ab21] Merge remote-tracking branch 'extcon/extcon-next'
> git bisect bad 926a60551123048c589b45abee2a2ec4c924ab21
> # bad: [1541655795a90720b8a094c8cc39f582dec17398] Merge remote-tracking branch 'tty/tty-next'
> git bisect bad 1541655795a90720b8a094c8cc39f582dec17398
> # bad: [69a6720a1e54519d9bf8563764e9e93bf1bd6a84] Merge remote-tracking branch 'kvm-arm/next'
> git bisect bad 69a6720a1e54519d9bf8563764e9e93bf1bd6a84
> # good: [33b8b045b93f9104c61ecad1865af961b3bef03e] Merge remote-tracking branch 'ftrace/for-next'
> git bisect good 33b8b045b93f9104c61ecad1865af961b3bef03e
> # good: [8370c3d08bd98576d97514eca29970e03767a5d1] kvm: svm: Add kvm_fast_pio_in support
> git bisect good 8370c3d08bd98576d97514eca29970e03767a5d1
> # good: [0a895142323de3eebb0b753d3d8c0e768ff179d9] mm: Prevent shrink_node() RCU CPU stall warnings
> git bisect good 0a895142323de3eebb0b753d3d8c0e768ff179d9
> # bad: [f8045446ca778333e960dcb9e30a5858ff2b8c20] srcu: Force full grace-period ordering
> git bisect bad f8045446ca778333e960dcb9e30a5858ff2b8c20
> # good: [f660d64912ccadadcdce6dfb39eb06924dd93767] doc: Fix RCU requirements typos
> git bisect good f660d64912ccadadcdce6dfb39eb06924dd93767
> # good: [d2db185bfee894c573faebed93461e9938bdbb61] rcu: Remove short-term CPU kicking
> git bisect good d2db185bfee894c573faebed93461e9938bdbb61
> # bad: [2d66cccd73436ac9985a08e5c2f82e4344f72264] mm: Prevent __alloc_pages_nodemask() RCU CPU stall warnings
> git bisect bad 2d66cccd73436ac9985a08e5c2f82e4344f72264
> # good: [34c53f5cd399801b083047cc9cf2ad3ed17c3144] mm: Prevent shrink_node_memcg() RCU CPU stall warnings
> git bisect good 34c53f5cd399801b083047cc9cf2ad3ed17c3144
> # first bad commit: [2d66cccd73436ac9985a08e5c2f82e4344f72264] mm: Prevent __alloc_pages_nodemask() RCU CPU stall warnings
> 


WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	sparclinux@vger.kernel.org, davem@davemloft.net
Subject: Re: next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu
Date: Thu, 1 Dec 2016 04:34:09 -0800	[thread overview]
Message-ID: <20161201123409.GA3924@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161201065657.GA4697@roeck-us.net>

On Wed, Nov 30, 2016 at 10:56:57PM -0800, Guenter Roeck wrote:
> Hi Paul,
> 
> On Wed, Nov 30, 2016 at 05:19:50PM -0800, Paul E. McKenney wrote:
> [ ... ]
> 
> > > > > 
> > > > > BUG: sleeping function called from invalid context at mm/page_alloc.c:3775
> [ ... ]
> > 
> > Whew!  You had me going for a bit there.  ;-)
> 
> Bisect results are here ... the culprit is, again, commit 2d66cccd73 ("mm:
> Prevent __alloc_pages_nodemask() RCU CPU stall warnings"), and reverting that
> patch fixes the problem. Good that you dropped it already :-).

"My work is done."  ;-)

And apologies for the hassle.  I have no idea what I was thinking when
I put the cond_resched_rcu_qs() there!

							Thanx, Paul

> Guenter
> 
> ---
> # bad: [59ab0083490c8a871b51e893bae5806e55901d7e] Add linux-next specific files for 20161130
> # good: [e5517c2a5a49ed5e99047008629f1cd60246ea0e] Linux 4.9-rc7
> git bisect start 'HEAD' 'v4.9-rc7'
> # good: [187f99e5c22bb3fab8b330f3ebbbd235d238f3f8] Merge remote-tracking branch 'crypto/master'
> git bisect good 187f99e5c22bb3fab8b330f3ebbbd235d238f3f8
> # good: [36126657c908e822523b8563f9b1512937c0f342] Merge remote-tracking branch 'tip/auto-latest'
> git bisect good 36126657c908e822523b8563f9b1512937c0f342
> # good: [2d2139c5c746ec61024fdfa9c36e4e034bb18e59] Merge tag 'iio-for-4.10d' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next
> git bisect good 2d2139c5c746ec61024fdfa9c36e4e034bb18e59
> # bad: [926a60551123048c589b45abee2a2ec4c924ab21] Merge remote-tracking branch 'extcon/extcon-next'
> git bisect bad 926a60551123048c589b45abee2a2ec4c924ab21
> # bad: [1541655795a90720b8a094c8cc39f582dec17398] Merge remote-tracking branch 'tty/tty-next'
> git bisect bad 1541655795a90720b8a094c8cc39f582dec17398
> # bad: [69a6720a1e54519d9bf8563764e9e93bf1bd6a84] Merge remote-tracking branch 'kvm-arm/next'
> git bisect bad 69a6720a1e54519d9bf8563764e9e93bf1bd6a84
> # good: [33b8b045b93f9104c61ecad1865af961b3bef03e] Merge remote-tracking branch 'ftrace/for-next'
> git bisect good 33b8b045b93f9104c61ecad1865af961b3bef03e
> # good: [8370c3d08bd98576d97514eca29970e03767a5d1] kvm: svm: Add kvm_fast_pio_in support
> git bisect good 8370c3d08bd98576d97514eca29970e03767a5d1
> # good: [0a895142323de3eebb0b753d3d8c0e768ff179d9] mm: Prevent shrink_node() RCU CPU stall warnings
> git bisect good 0a895142323de3eebb0b753d3d8c0e768ff179d9
> # bad: [f8045446ca778333e960dcb9e30a5858ff2b8c20] srcu: Force full grace-period ordering
> git bisect bad f8045446ca778333e960dcb9e30a5858ff2b8c20
> # good: [f660d64912ccadadcdce6dfb39eb06924dd93767] doc: Fix RCU requirements typos
> git bisect good f660d64912ccadadcdce6dfb39eb06924dd93767
> # good: [d2db185bfee894c573faebed93461e9938bdbb61] rcu: Remove short-term CPU kicking
> git bisect good d2db185bfee894c573faebed93461e9938bdbb61
> # bad: [2d66cccd73436ac9985a08e5c2f82e4344f72264] mm: Prevent __alloc_pages_nodemask() RCU CPU stall warnings
> git bisect bad 2d66cccd73436ac9985a08e5c2f82e4344f72264
> # good: [34c53f5cd399801b083047cc9cf2ad3ed17c3144] mm: Prevent shrink_node_memcg() RCU CPU stall warnings
> git bisect good 34c53f5cd399801b083047cc9cf2ad3ed17c3144
> # first bad commit: [2d66cccd73436ac9985a08e5c2f82e4344f72264] mm: Prevent __alloc_pages_nodemask() RCU CPU stall warnings
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	sparclinux@vger.kernel.org, davem@davemloft.net
Subject: Re: next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu
Date: Thu, 1 Dec 2016 04:34:09 -0800	[thread overview]
Message-ID: <20161201123409.GA3924@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161201065657.GA4697@roeck-us.net>

On Wed, Nov 30, 2016 at 10:56:57PM -0800, Guenter Roeck wrote:
> Hi Paul,
> 
> On Wed, Nov 30, 2016 at 05:19:50PM -0800, Paul E. McKenney wrote:
> [ ... ]
> 
> > > > > 
> > > > > BUG: sleeping function called from invalid context at mm/page_alloc.c:3775
> [ ... ]
> > 
> > Whew!  You had me going for a bit there.  ;-)
> 
> Bisect results are here ... the culprit is, again, commit 2d66cccd73 ("mm:
> Prevent __alloc_pages_nodemask() RCU CPU stall warnings"), and reverting that
> patch fixes the problem. Good that you dropped it already :-).

"My work is done."  ;-)

And apologies for the hassle.  I have no idea what I was thinking when
I put the cond_resched_rcu_qs() there!

							Thanx, Paul

> Guenter
> 
> ---
> # bad: [59ab0083490c8a871b51e893bae5806e55901d7e] Add linux-next specific files for 20161130
> # good: [e5517c2a5a49ed5e99047008629f1cd60246ea0e] Linux 4.9-rc7
> git bisect start 'HEAD' 'v4.9-rc7'
> # good: [187f99e5c22bb3fab8b330f3ebbbd235d238f3f8] Merge remote-tracking branch 'crypto/master'
> git bisect good 187f99e5c22bb3fab8b330f3ebbbd235d238f3f8
> # good: [36126657c908e822523b8563f9b1512937c0f342] Merge remote-tracking branch 'tip/auto-latest'
> git bisect good 36126657c908e822523b8563f9b1512937c0f342
> # good: [2d2139c5c746ec61024fdfa9c36e4e034bb18e59] Merge tag 'iio-for-4.10d' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next
> git bisect good 2d2139c5c746ec61024fdfa9c36e4e034bb18e59
> # bad: [926a60551123048c589b45abee2a2ec4c924ab21] Merge remote-tracking branch 'extcon/extcon-next'
> git bisect bad 926a60551123048c589b45abee2a2ec4c924ab21
> # bad: [1541655795a90720b8a094c8cc39f582dec17398] Merge remote-tracking branch 'tty/tty-next'
> git bisect bad 1541655795a90720b8a094c8cc39f582dec17398
> # bad: [69a6720a1e54519d9bf8563764e9e93bf1bd6a84] Merge remote-tracking branch 'kvm-arm/next'
> git bisect bad 69a6720a1e54519d9bf8563764e9e93bf1bd6a84
> # good: [33b8b045b93f9104c61ecad1865af961b3bef03e] Merge remote-tracking branch 'ftrace/for-next'
> git bisect good 33b8b045b93f9104c61ecad1865af961b3bef03e
> # good: [8370c3d08bd98576d97514eca29970e03767a5d1] kvm: svm: Add kvm_fast_pio_in support
> git bisect good 8370c3d08bd98576d97514eca29970e03767a5d1
> # good: [0a895142323de3eebb0b753d3d8c0e768ff179d9] mm: Prevent shrink_node() RCU CPU stall warnings
> git bisect good 0a895142323de3eebb0b753d3d8c0e768ff179d9
> # bad: [f8045446ca778333e960dcb9e30a5858ff2b8c20] srcu: Force full grace-period ordering
> git bisect bad f8045446ca778333e960dcb9e30a5858ff2b8c20
> # good: [f660d64912ccadadcdce6dfb39eb06924dd93767] doc: Fix RCU requirements typos
> git bisect good f660d64912ccadadcdce6dfb39eb06924dd93767
> # good: [d2db185bfee894c573faebed93461e9938bdbb61] rcu: Remove short-term CPU kicking
> git bisect good d2db185bfee894c573faebed93461e9938bdbb61
> # bad: [2d66cccd73436ac9985a08e5c2f82e4344f72264] mm: Prevent __alloc_pages_nodemask() RCU CPU stall warnings
> git bisect bad 2d66cccd73436ac9985a08e5c2f82e4344f72264
> # good: [34c53f5cd399801b083047cc9cf2ad3ed17c3144] mm: Prevent shrink_node_memcg() RCU CPU stall warnings
> git bisect good 34c53f5cd399801b083047cc9cf2ad3ed17c3144
> # first bad commit: [2d66cccd73436ac9985a08e5c2f82e4344f72264] mm: Prevent __alloc_pages_nodemask() RCU CPU stall warnings
> 

  reply	other threads:[~2016-12-01 12:34 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 21:23 next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Guenter Roeck
2016-11-29 21:23 ` Guenter Roeck
2016-11-29 21:23 ` Guenter Roeck
2016-11-30  1:28 ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Paul E. McKenney
2016-11-30  1:28   ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Paul E. McKenney
2016-11-30  1:28   ` Paul E. McKenney
2016-11-30  4:32   ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Guenter Roeck
2016-11-30  4:32     ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Guenter Roeck
2016-11-30  4:32     ` Guenter Roeck
2016-11-30  7:02     ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Paul E. McKenney
2016-11-30  7:02       ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Paul E. McKenney
2016-11-30  7:02       ` Paul E. McKenney
2016-11-30 10:52       ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Guenter Roeck
2016-11-30 10:52         ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Guenter Roeck
2016-11-30 10:52         ` Guenter Roeck
2016-11-30 12:03         ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Paul E. McKenney
2016-11-30 12:03           ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Paul E. McKenney
2016-11-30 12:03           ` Paul E. McKenney
2016-11-30 19:21           ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Guenter Roeck
2016-11-30 19:21             ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Guenter Roeck
2016-11-30 19:21             ` Guenter Roeck
2016-11-30 21:01             ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Paul E. McKenney
2016-11-30 21:01               ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Paul E. McKenney
2016-11-30 21:01               ` Paul E. McKenney
2016-11-30 23:18               ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Guenter Roeck
2016-11-30 23:18                 ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Guenter Roeck
2016-11-30 23:18                 ` Guenter Roeck
2016-12-01  1:19                 ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Paul E. McKenney
2016-12-01  1:19                   ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Paul E. McKenney
2016-12-01  1:19                   ` Paul E. McKenney
2016-12-01  6:56                   ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Guenter Roeck
2016-12-01  6:56                     ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Guenter Roeck
2016-12-01  6:56                     ` Guenter Roeck
2016-12-01 12:34                     ` Paul E. McKenney [this message]
2016-12-01 12:34                       ` Paul E. McKenney
2016-12-01 12:34                       ` Paul E. McKenney
2016-12-01 12:50                       ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qe Guenter Roeck
2016-12-01 12:50                         ` next: Commit 'mm: Prevent __alloc_pages_nodemask() RCU CPU stall ...' causing hang on sparc32 qemu Guenter Roeck
2016-12-01 12:50                         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161201123409.GA3924@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@roeck-us.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.