From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
kvm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] KVM: use after free in kvm_ioctl_create_device()
Date: Thu, 01 Dec 2016 15:14:33 +0000 [thread overview]
Message-ID: <20161201151432.GH1682@potion> (raw)
In-Reply-To: <20161130192105.GC28180@mwanda>
2016-11-30 22:21+0300, Dan Carpenter:
> We should move the ops->destroy(dev) after the list_del(&dev->vm_node)
> so that we don't use "dev" after freeing it.
>
> Fixes: a28ebea2adc4 ("KVM: Protect device ops->create and list_add with kvm->lock")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to kvm/master, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
kvm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] KVM: use after free in kvm_ioctl_create_device()
Date: Thu, 1 Dec 2016 16:14:33 +0100 [thread overview]
Message-ID: <20161201151432.GH1682@potion> (raw)
In-Reply-To: <20161130192105.GC28180@mwanda>
2016-11-30 22:21+0300, Dan Carpenter:
> We should move the ops->destroy(dev) after the list_del(&dev->vm_node)
> so that we don't use "dev" after freeing it.
>
> Fixes: a28ebea2adc4 ("KVM: Protect device ops->create and list_add with kvm->lock")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to kvm/master, thanks.
next prev parent reply other threads:[~2016-12-01 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 19:21 [patch] KVM: use after free in kvm_ioctl_create_device() Dan Carpenter
2016-11-30 19:21 ` Dan Carpenter
2016-12-01 12:20 ` David Hildenbrand
2016-12-01 12:20 ` David Hildenbrand
2016-12-01 15:14 ` Radim Krčmář [this message]
2016-12-01 15:14 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201151432.GH1682@potion \
--to=rkrcmar@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.