From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-nvdimm@lists.01.org
Subject: Re: [PATCH v2 1/6] tracing: add __print_flags_u64()
Date: Thu, 1 Dec 2016 08:35:00 -0700 [thread overview]
Message-ID: <20161201153500.GB5160@linux.intel.com> (raw)
In-Reply-To: <20161201091254.3e9f99b0@gandalf.local.home>
On Thu, Dec 01, 2016 at 09:12:54AM -0500, Steven Rostedt wrote:
> On Wed, 30 Nov 2016 16:45:28 -0700
> Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> > diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> > index 3fc2042..ed4398f 100644
> > --- a/kernel/trace/trace_output.c
> > +++ b/kernel/trace/trace_output.c
> > @@ -124,6 +124,44 @@ EXPORT_SYMBOL(trace_print_symbols_seq);
> >
> > #if BITS_PER_LONG == 32
> > const char *
> > +trace_print_flags_seq_u64(struct trace_seq *p, const char *delim,
> > + unsigned long long flags,
> > + const struct trace_print_flags_u64 *flag_array)
> > +{
> > + unsigned long mask;
>
> Don't you want mask to be unsigned long long?
Yep, thanks for spotting that. I'll fix it in v3.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-nvdimm@ml01.01.org
Subject: Re: [PATCH v2 1/6] tracing: add __print_flags_u64()
Date: Thu, 1 Dec 2016 08:35:00 -0700 [thread overview]
Message-ID: <20161201153500.GB5160@linux.intel.com> (raw)
In-Reply-To: <20161201091254.3e9f99b0@gandalf.local.home>
On Thu, Dec 01, 2016 at 09:12:54AM -0500, Steven Rostedt wrote:
> On Wed, 30 Nov 2016 16:45:28 -0700
> Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> > diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> > index 3fc2042..ed4398f 100644
> > --- a/kernel/trace/trace_output.c
> > +++ b/kernel/trace/trace_output.c
> > @@ -124,6 +124,44 @@ EXPORT_SYMBOL(trace_print_symbols_seq);
> >
> > #if BITS_PER_LONG == 32
> > const char *
> > +trace_print_flags_seq_u64(struct trace_seq *p, const char *delim,
> > + unsigned long long flags,
> > + const struct trace_print_flags_u64 *flag_array)
> > +{
> > + unsigned long mask;
>
> Don't you want mask to be unsigned long long?
Yep, thanks for spotting that. I'll fix it in v3.
next prev parent reply other threads:[~2016-12-01 15:35 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 23:45 [PATCH v2 0/6] introduce DAX tracepoint support Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` [PATCH v2 1/6] tracing: add __print_flags_u64() Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-12-01 14:12 ` Steven Rostedt
2016-12-01 14:12 ` Steven Rostedt
2016-12-01 14:12 ` Steven Rostedt
2016-12-01 15:35 ` Ross Zwisler [this message]
2016-12-01 15:35 ` Ross Zwisler
2016-11-30 23:45 ` [PATCH v2 2/6] dax: remove leading space from labels Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-12-01 8:11 ` Jan Kara
2016-12-01 8:11 ` Jan Kara
2016-12-01 8:11 ` Jan Kara
2016-12-01 15:26 ` Ross Zwisler
2016-12-01 15:26 ` Ross Zwisler
2016-12-01 15:26 ` Ross Zwisler
2016-12-01 16:33 ` Jan Kara
2016-12-01 16:33 ` Jan Kara
2016-12-01 16:33 ` Jan Kara
2016-11-30 23:45 ` [PATCH v2 3/6] dax: add tracepoint infrastructure, PMD tracing Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-12-01 8:10 ` Jan Kara
2016-12-01 8:10 ` Jan Kara
2016-12-01 8:10 ` Jan Kara
2016-12-01 14:16 ` Steven Rostedt
2016-12-01 14:16 ` Steven Rostedt
2016-12-01 14:16 ` Steven Rostedt
2016-12-01 15:39 ` Ross Zwisler
2016-12-01 15:39 ` Ross Zwisler
2016-12-01 15:39 ` Ross Zwisler
2016-11-30 23:45 ` [PATCH v2 4/6] dax: update MAINTAINERS entries for FS DAX Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` [PATCH v2 5/6] dax: add tracepoints to dax_pmd_load_hole() Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` [PATCH v2 6/6] dax: add tracepoints to dax_pmd_insert_mapping() Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-11-30 23:45 ` Ross Zwisler
2016-12-01 14:19 ` Steven Rostedt
2016-12-01 14:19 ` Steven Rostedt
2016-12-01 14:19 ` Steven Rostedt
2016-12-01 15:44 ` Ross Zwisler
2016-12-01 15:44 ` Ross Zwisler
2016-12-01 15:44 ` Ross Zwisler
2016-12-01 16:11 ` Steven Rostedt
2016-12-01 16:11 ` Steven Rostedt
2016-12-01 16:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201153500.GB5160@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mawilcox@microsoft.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.