All of lore.kernel.org
 help / color / mirror / Atom feed
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: arm64: dts: zx: support cpu-freq for zx296718
Date: Fri, 2 Dec 2016 08:24:47 +0530	[thread overview]
Message-ID: <20161202025447.GD7682@vireshk-i7> (raw)
In-Reply-To: <20161202023627.GA6657@dragon>

On 02-12-16, 10:36, Shawn Guo wrote:
> + Viresh, the author of the bindings.
> 
> On Thu, Dec 01, 2016 at 08:08:55PM +0800, Baoyou Xie wrote:
> > This patch adds the CPU clock phandle in CPU's node
> > and uses operating-points-v2 to register operating points.
> > 
> > So it can be used by cpufreq-dt driver.
> > 
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 
> Just out of curiosity, why is there no '[PATCH]' prefix in the subject?
> 
> > ---
> >  arch/arm64/boot/dts/zte/zx296718.dtsi | 37 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/zte/zx296718.dtsi b/arch/arm64/boot/dts/zte/zx296718.dtsi
> > index 7a1aed7..16f7d5e 100644
> > --- a/arch/arm64/boot/dts/zte/zx296718.dtsi
> > +++ b/arch/arm64/boot/dts/zte/zx296718.dtsi
> > @@ -44,6 +44,7 @@
> >  #include <dt-bindings/input/input.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/clock/zx296718-clock.h>
> >  
> >  / {
> >  	compatible = "zte,zx296718";
> > @@ -81,6 +82,8 @@
> >  			compatible = "arm,cortex-a53","arm,armv8";
> >  			reg = <0x0 0x0>;
> >  			enable-method = "psci";
> > +			clocks = <&topcrm A53_GATE>;
> > +			operating-points-v2 = <&cluster0_opp>;
> >  		};
> >  
> >  		cpu1: cpu at 1 {
> > @@ -88,6 +91,7 @@
> >  			compatible = "arm,cortex-a53","arm,armv8";
> >  			reg = <0x0 0x1>;
> >  			enable-method = "psci";
> > +			operating-points-v2 = <&cluster0_opp>;
> >  		};
> >  
> >  		cpu2: cpu at 2 {
> > @@ -95,6 +99,7 @@
> >  			compatible = "arm,cortex-a53","arm,armv8";
> >  			reg = <0x0 0x2>;
> >  			enable-method = "psci";
> > +			operating-points-v2 = <&cluster0_opp>;
> >  		};
> >  
> >  		cpu3: cpu at 3 {
> > @@ -102,6 +107,38 @@
> >  			compatible = "arm,cortex-a53","arm,armv8";
> >  			reg = <0x0 0x3>;
> >  			enable-method = "psci";
> > +			operating-points-v2 = <&cluster0_opp>;
> > +		};
> > +	};
> > +
> > +	cluster0_opp: opp_table0 {

Also, you better add "clocks" property in all above nodes.

-- 
viresh

WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
	robh+dt@kernel.org, mark.rutland@arm.com,
	catalin.marinas@arm.com, will.deacon@arm.com, jun.nie@linaro.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn,
	chen.chaokai@zte.com.cn, wang.qiang01@zte.com.cn
Subject: Re: arm64: dts: zx: support cpu-freq for zx296718
Date: Fri, 2 Dec 2016 08:24:47 +0530	[thread overview]
Message-ID: <20161202025447.GD7682@vireshk-i7> (raw)
In-Reply-To: <20161202023627.GA6657@dragon>

On 02-12-16, 10:36, Shawn Guo wrote:
> + Viresh, the author of the bindings.
> 
> On Thu, Dec 01, 2016 at 08:08:55PM +0800, Baoyou Xie wrote:
> > This patch adds the CPU clock phandle in CPU's node
> > and uses operating-points-v2 to register operating points.
> > 
> > So it can be used by cpufreq-dt driver.
> > 
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 
> Just out of curiosity, why is there no '[PATCH]' prefix in the subject?
> 
> > ---
> >  arch/arm64/boot/dts/zte/zx296718.dtsi | 37 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/zte/zx296718.dtsi b/arch/arm64/boot/dts/zte/zx296718.dtsi
> > index 7a1aed7..16f7d5e 100644
> > --- a/arch/arm64/boot/dts/zte/zx296718.dtsi
> > +++ b/arch/arm64/boot/dts/zte/zx296718.dtsi
> > @@ -44,6 +44,7 @@
> >  #include <dt-bindings/input/input.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/clock/zx296718-clock.h>
> >  
> >  / {
> >  	compatible = "zte,zx296718";
> > @@ -81,6 +82,8 @@
> >  			compatible = "arm,cortex-a53","arm,armv8";
> >  			reg = <0x0 0x0>;
> >  			enable-method = "psci";
> > +			clocks = <&topcrm A53_GATE>;
> > +			operating-points-v2 = <&cluster0_opp>;
> >  		};
> >  
> >  		cpu1: cpu@1 {
> > @@ -88,6 +91,7 @@
> >  			compatible = "arm,cortex-a53","arm,armv8";
> >  			reg = <0x0 0x1>;
> >  			enable-method = "psci";
> > +			operating-points-v2 = <&cluster0_opp>;
> >  		};
> >  
> >  		cpu2: cpu@2 {
> > @@ -95,6 +99,7 @@
> >  			compatible = "arm,cortex-a53","arm,armv8";
> >  			reg = <0x0 0x2>;
> >  			enable-method = "psci";
> > +			operating-points-v2 = <&cluster0_opp>;
> >  		};
> >  
> >  		cpu3: cpu@3 {
> > @@ -102,6 +107,38 @@
> >  			compatible = "arm,cortex-a53","arm,armv8";
> >  			reg = <0x0 0x3>;
> >  			enable-method = "psci";
> > +			operating-points-v2 = <&cluster0_opp>;
> > +		};
> > +	};
> > +
> > +	cluster0_opp: opp_table0 {

Also, you better add "clocks" property in all above nodes.

-- 
viresh

  reply	other threads:[~2016-12-02  2:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 12:08 arm64: dts: zx: support cpu-freq for zx296718 Baoyou Xie
2016-12-01 12:08 ` Baoyou Xie
2016-12-02  2:36 ` Shawn Guo
2016-12-02  2:36   ` Shawn Guo
2016-12-02  2:36   ` Shawn Guo
2016-12-02  2:54   ` Viresh Kumar [this message]
2016-12-02  2:54     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161202025447.GD7682@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.