From: Ben Pfaff <blp@ovn.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: "open list:OPENVSWITCH" <dev@openvswitch.org>,
netdev@vger.kernel.org,
"moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>
Subject: Re: [Bridge] [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit
Date: Sat, 3 Dec 2016 15:27:30 -0800 [thread overview]
Message-ID: <20161203232730.GT3129@ovn.org> (raw)
In-Reply-To: <cfa1f2efae2217b50cbefccbf9ba7f0d24a23c63.1480755768.git.mirq-linux@rere.qmqm.pl>
On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote:
> This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed
> intact through linux networking stack.
>
> Signed-off-by: Michał Mirosław <michal.miroslaw@atendesoftware.pl>
> ---
>
> Dear NetDevs
>
> I guess this needs to be split to the prep..convert[]..finish sequence,
> but if you like it as is, then it's ready.
>
> The biggest question is if the modified interface and vlan_present
> is the way to go. This can be changed to use vlan_proto != 0 instead
> of an extra flag bit.
>
> As I can't test most of the driver changes, please look at them carefully.
> OVS and bridge eyes are especially welcome.
This appears to change the established Open vSwitch userspace API. You
can see that simply from the way that it changes the documentation for
the userspace API. If I'm right about that, then this change will break
all userspace programs that use the Open vSwitch kernel module,
including Open vSwitch itself.
WARNING: multiple messages have this Message-ID (diff)
From: Ben Pfaff <blp@ovn.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org,
"open list:OPENVSWITCH" <dev@openvswitch.org>,
"moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>
Subject: Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit
Date: Sat, 3 Dec 2016 15:27:30 -0800 [thread overview]
Message-ID: <20161203232730.GT3129@ovn.org> (raw)
In-Reply-To: <cfa1f2efae2217b50cbefccbf9ba7f0d24a23c63.1480755768.git.mirq-linux@rere.qmqm.pl>
On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote:
> This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed
> intact through linux networking stack.
>
> Signed-off-by: Michał Mirosław <michal.miroslaw@atendesoftware.pl>
> ---
>
> Dear NetDevs
>
> I guess this needs to be split to the prep..convert[]..finish sequence,
> but if you like it as is, then it's ready.
>
> The biggest question is if the modified interface and vlan_present
> is the way to go. This can be changed to use vlan_proto != 0 instead
> of an extra flag bit.
>
> As I can't test most of the driver changes, please look at them carefully.
> OVS and bridge eyes are especially welcome.
This appears to change the established Open vSwitch userspace API. You
can see that simply from the way that it changes the documentation for
the userspace API. If I'm right about that, then this change will break
all userspace programs that use the Open vSwitch kernel module,
including Open vSwitch itself.
next prev parent reply other threads:[~2016-12-03 23:27 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 9:22 [Bridge] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit Michał Mirosław
2016-12-03 9:22 ` Michał Mirosław
2016-12-03 23:27 ` Ben Pfaff [this message]
2016-12-03 23:27 ` [ovs-dev] " Ben Pfaff
2016-12-05 17:24 ` [Bridge] " Michał Mirosław
2016-12-05 17:24 ` Michał Mirosław
2016-12-05 18:55 ` [Bridge] " Ben Pfaff
2016-12-05 18:55 ` Ben Pfaff
2016-12-05 22:52 ` [Bridge] " Michał Mirosław
2016-12-05 22:52 ` Michał Mirosław
2016-12-06 0:59 ` [Bridge] [ovs-dev] " Ben Pfaff
2016-12-06 0:59 ` Ben Pfaff
2016-12-13 0:12 ` [PATCH net-next 00/27] Remove VLAN CFI bit abuse Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 03/27] ibmvnic: fix accelerated VLAN handling Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 01/27] net/vlan: introduce __vlan_hwaccel_clear_tag() helper Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 02/27] net/vlan: introduce __vlan_hwaccel_copy_tag() helper Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 05/27] i40iw: remove use of VLAN_TAG_PRESENT Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 04/27] qlcnic: remove assumption that vlan_tci != 0 Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 07/27] gianfar: remove use of VLAN_TAG_PRESENT Michał Mirosław
2016-12-13 12:09 ` Claudiu Manoil
2016-12-13 0:12 ` [PATCH net-next 08/27] net/hyperv: " Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 06/27] cnic: " Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 11/27] sky2: use __vlan_hwaccel helpers Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 09/27] cxgb4: " Michał Mirosław
2016-12-13 1:40 ` Steve Wise
2016-12-13 0:12 ` [Bridge] [PATCH net-next 13/27] bridge: " Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 12:59 ` [Bridge] " Sergei Shtylyov
2016-12-13 12:59 ` Sergei Shtylyov
2016-12-13 15:11 ` [Bridge] " Michał Mirosław
2016-12-13 15:11 ` Michał Mirosław
2016-12-14 0:40 ` [Bridge] " Toshiaki Makita
2016-12-14 0:40 ` Toshiaki Makita
2016-12-13 0:12 ` [PATCH net-next 14/27] 8021q: " Michał Mirosław
[not found] ` <cover.1481586602.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2016-12-13 0:12 ` [PATCH net-next 17/27] OVS: remove assumptions about VLAN_TAG_PRESENT bit Michał Mirosław
[not found] ` <e44219bc56d3e44aa0711c83c626adabf4c4ecd8.1481586602.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2016-12-13 10:40 ` Jiri Benc
2016-12-13 15:14 ` Michał Mirosław
2016-12-13 15:31 ` [PATCH/replace net-next 17/27] OVS: remove use of VLAN_TAG_PRESENT Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 16/27] nfnetlink/queue: use __vlan_hwaccel helpers Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 15/27] ipv4/tunnel: " Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 18/27] net/skbuff: add macros for VLAN_PRESENT bit Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 19/27] net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 20/27] net/bpf_jit: MIPS: " Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 1:22 ` Ralf Baechle
2016-12-13 0:12 ` [PATCH net-next 21/27] net/bpf_jit: PPC: " Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 23/27] net/bpf: " Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 22/27] net/bpf_jit: SPARC: " Michał Mirosław
2016-12-13 0:12 ` Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 24/27] bpf_test: prepare for VLAN_TAG_PRESENT removal Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 26/27] net/hyperv: enable passing of VLAN.CFI bit Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 25/27] net: remove VLAN_TAG_PRESENT Michał Mirosław
2016-12-13 0:12 ` [PATCH net-next 27/27] net/vlan: remove unused #define HAVE_VLAN_GET_TAG Michał Mirosław
2016-12-13 5:18 ` [PATCH net-next 00/27] Remove VLAN CFI bit abuse Michał Mirosław
2016-12-14 1:16 ` Stephen Hemminger
2016-12-14 2:00 ` Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 00/27] Allow passing of VLAN CFI bit through network stack Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 01/27] net/vlan: introduce __vlan_hwaccel_clear_tag() helper Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 02/27] net/vlan: introduce __vlan_hwaccel_copy_tag() helper Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 03/27] ibmvnic: fix accelerated VLAN handling Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 07/27] gianfar: remove use of VLAN_TAG_PRESENT Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 05/27] i40iw: " Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 04/27] qlcnic: remove assumption that vlan_tci != 0 Michał Mirosław
2017-01-04 11:29 ` Chopra, Manish
2017-01-03 20:52 ` [PATCH net-next v2 06/27] cnic: remove use of VLAN_TAG_PRESENT Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 11/27] sky2: use __vlan_hwaccel helpers Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 09/27] cxgb4: " Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 10/27] benet: " Michał Mirosław
[not found] ` <CACZ4nhsUxWYvM5HoASHb7-m2uZtnk3DN6cQigp+cObyLqPJXdA@mail.gmail.com>
2017-01-03 23:11 ` [PATCH net-next v3 " Michał Mirosław
2017-01-11 5:29 ` Somnath Kotur
2017-01-03 20:52 ` [PATCH net-next v2 08/27] net/hyperv: remove use of VLAN_TAG_PRESENT Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 12/27] net/core: use __vlan_hwaccel helpers Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 14/27] 8021q: " Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 15/27] ipv4/tunnel: " Michał Mirosław
2017-01-03 20:52 ` [Bridge] [PATCH net-next v2 13/27] bridge: " Michał Mirosław
2017-01-03 20:52 ` Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 16/27] nfnetlink/queue: " Michał Mirosław
[not found] ` <cover.1483475202.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2017-01-03 20:52 ` [PATCH net-next v2 17/27] OVS: remove use of VLAN_TAG_PRESENT Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 20/27] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 19/27] net/bpf_jit: ARM: " Michał Mirosław
2017-01-03 20:52 ` Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 18/27] net/skbuff: add macros for VLAN_PRESENT bit Michał Mirosław
2017-01-03 20:52 ` Michał Mirosław
2017-01-03 20:52 ` Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 22/27] net/bpf_jit: SPARC: split VLAN_PRESENT bit handling from VLAN_TCI Michał Mirosław
2017-01-03 20:52 ` Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 21/27] net/bpf_jit: PPC: " Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 24/27] bpf_test: prepare for VLAN_TAG_PRESENT removal Michał Mirosław
2017-01-03 21:16 ` Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 23/27] net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 25/27] net: remove VLAN_TAG_PRESENT Michał Mirosław
2017-01-03 21:15 ` [PATCH net-next v3 " Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 27/27] net/vlan: remove unused #define HAVE_VLAN_GET_TAG Michał Mirosław
2017-01-03 20:52 ` [PATCH net-next v2 26/27] net/hyperv: enable passing of VLAN.CFI bit Michał Mirosław
2017-01-03 21:32 ` [PATCH net-next v2 00/27] Allow passing of VLAN CFI bit through network stack David Miller
2017-01-03 23:21 ` Michał Mirosław
2017-01-03 23:36 ` Michał Mirosław
2017-01-04 0:13 ` Michał Mirosław
2016-12-14 1:21 ` [Bridge] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit Stephen Hemminger
2016-12-14 1:21 ` Stephen Hemminger
2016-12-14 2:03 ` [Bridge] " Michał Mirosław
2016-12-14 2:03 ` Michał Mirosław
2016-12-14 2:21 ` [Bridge] " Alexei Starovoitov
2016-12-14 2:21 ` Alexei Starovoitov
2016-12-14 14:28 ` [Bridge] " Michał Mirosław
2016-12-14 14:28 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161203232730.GT3129@ovn.org \
--to=blp@ovn.org \
--cc=bridge@lists.linux-foundation.org \
--cc=dev@openvswitch.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.