From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Bharata B Rao <bharata.rao@gmail.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Igor Mammedov <imammedo@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] Unable to add ram object with same ID after addition, migration and removal at the target
Date: Mon, 05 Dec 2016 00:44:53 -0600 [thread overview]
Message-ID: <20161205064453.3996.48049@loki> (raw)
In-Reply-To: <CAGZKiBrebbEy9pfWCmN_ztmQZ5gNUZ5Ho_J-oOtyhrYSQPi91A@mail.gmail.com>
Quoting Bharata B Rao (2016-12-04 21:51:32)
> On Fri, Dec 2, 2016 at 11:46 PM, Dr. David Alan Gilbert <dgilbert@redhat.com>
> wrote:
>
> * Bharata B Rao (bharata.rao@gmail.com) wrote:
> > Hi,
> >
> > - Add ram object and dimm device at the source
> >
> > (qemu) object_add memory-backend-ram,id=ram0,size=128M
> > (qemu) device_add pc-dimm,id=dimm0,memdev=ram0
> >
> > - Migrate the VM and remove the dimm device and ram object at the target
> >
> > (qemu) device_del dimm0
> > (qemu) object_del ram0
> >
> > - Adding the ram object with same id now at the target fails like this:
> >
> > (qemu) info memdev
> >
> > (qemu) object_add memory-backend-ram,id=ram0,size=128M
> > Duplicate ID 'ram0' for object
> >
> > Same behaviour is seen on x86 and Power. The problem isn't seen if
> > migration isn't involved (add, remove, add at the source itself).
>
> Is this the same as the one Michael Roth posted a fix for a few days
> back; 'monitor: fix object_del for command-line-created objects'
>
> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg05479.html
>
>
> Yes, this is same as above, I hadn't noticed Michael's fix.
>
> Will be good to have this fix in 2.8.
I considered shooting for 2.8, but since it's only triggerable with HMP
(QMP doesn't use the QemuOpts-based parsing so it doesn't hit the
duplicate ID error, so libvirt in turn would be uneffected), and doesn't
seem to be a regression (AFAICT it's been an issue since object_del was
introduced), I figured it could wait till 2.9/2.8.1.
Definitely a pain for testing though...
>
> Regards,
> Bharata.
next prev parent reply other threads:[~2016-12-05 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 3:25 [Qemu-devel] Unable to add ram object with same ID after addition, migration and removal at the target Bharata B Rao
2016-12-02 18:16 ` Dr. David Alan Gilbert
2016-12-05 3:51 ` Bharata B Rao
2016-12-05 6:44 ` Michael Roth [this message]
2016-12-05 23:02 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205064453.3996.48049@loki \
--to=mdroth@linux.vnet.ibm.com \
--cc=bharata.rao@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.