From: Greg KH <greg@kroah.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, Ping-Ke Shih <pkshih@realtek.com>,
linux-wireless@vger.kernel.org, kvalo@codeaurora.org
Subject: Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex
Date: Tue, 6 Dec 2016 08:13:40 +0100 [thread overview]
Message-ID: <20161206071340.GB10292@kroah.com> (raw)
In-Reply-To: <6442d5c7-f083-0e98-490b-dd18a5a4d316@lwfinger.net>
On Mon, Dec 05, 2016 at 04:34:08PM -0600, Larry Finger wrote:
> On 12/05/2016 03:34 PM, Dan Carpenter wrote:
> > On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote:
> > > --- wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h
> > > +++ wireless-drivers-next/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h
> > > @@ -27,6 +27,29 @@
> > >
> > > #include "../wifi.h"
> > >
> > > +#ifdef CONFIG_RTLWIFI_DEBUG
> > > +
> > > +#define BTC_SPRINTF(ptr, ...) snprintf(ptr, ##__VA_ARGS__)
> > > +#define BTC_TRACE(fmt) \
> > > +do { \
> > > + struct rtl_priv *rtlpriv = gl_bt_coexist.adapter; \
> > > + if (!rtlpriv) \
> > > + break; \
> > > + RT_TRACE_STRING(rtlpriv, COMP_COEX, DBG_LOUD, fmt); \
> > > +} while (0)
> > > +
> >
> > This sort of macro is exactly when the rtl drivers spent so long in
> > staging... Subsystems should not invent their own tracing but in
> > particular these macros are so very very ugly.
> >
> > It's just super frustrating to even look at this...
> >
> > There are a lot of staging drivers I feel good about when they leave.
> > The HyperV drivers. The IIO stuff. A lot of the media stuff and
> > generally the media tree is getting better and better. I like comedi
> > and unisys, those are in staging, but they are great and could move out
> > any time as far as I'm concerned.
> >
> > But this patch just makes me super discouraged. What are we doing???
>
> Dan,
>
> It would not matter to me if these drivers got moved to staging, but there
> are a lot of users whose distros do not build staging drivers that would be
> very unhappy.
>
> Can you point me to a driver with a better way to conditionally dump a
> debugging string to the logs?
Just use 'dev_dbg()', or 'pr_debug()' if you don't have a device pointer
(hint, all drivers should have that pointer). That can be turned on or
off by a user dynamically as the kernel runs. No need to invent fancy
custom macros for things we have already for many many years.
thanks,
greg k-h
next prev parent reply other threads:[~2016-12-06 7:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 1:48 [PATCH 00/14] rtlwifi: Various updates Larry Finger
2016-12-02 1:48 ` [PATCH 01/14] rtlwifi: Correct power save capability while init mac80211 Larry Finger
2016-12-30 13:10 ` [01/14] " Kalle Valo
2016-12-02 1:48 ` [PATCH 02/14] rtlwifi: Fix programing CAM content sequence Larry Finger
2016-12-05 20:49 ` Dan Carpenter
2016-12-02 1:48 ` [PATCH 03/14] rtlwifi: Set retry limit depends on vif type Larry Finger
2016-12-02 1:48 ` [PATCH 03/14] rtlwifi: extend debug_comp to u64 Larry Finger
2016-12-02 1:48 ` [PATCH 05/14] rtlwifi: Add TX report and disable key will wait until report acked Larry Finger
2016-12-05 21:10 ` Dan Carpenter
2016-12-02 1:48 ` [PATCH 06/14] rtlwifi: rtl8723be: btcoexist: Add single_ant_path Larry Finger
2016-12-02 1:48 ` [PATCH 07/14] rtlwifi: move btcoex's ant_num declaration Larry Finger
2016-12-02 1:48 ` [PATCH 08/14] rtlwifi: rtl8723be: btcoex: add package_type function to btcoex Larry Finger
2016-12-02 1:48 ` [PATCH 09/14] rtlwifi: ibtcoex: move bt_type declaration Larry Finger
2016-12-02 1:48 ` [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex Larry Finger
2016-12-05 21:34 ` Dan Carpenter
2016-12-05 22:34 ` Larry Finger
2016-12-06 7:13 ` Greg KH [this message]
2016-12-07 12:16 ` Kalle Valo
2016-12-07 13:32 ` Dan Carpenter
2016-12-07 16:41 ` Larry Finger
2016-12-08 11:43 ` Kalle Valo
2016-12-08 11:50 ` Dan Carpenter
2016-12-08 11:54 ` Dan Carpenter
2016-12-09 8:50 ` Kalle Valo
2016-12-09 23:56 ` Markus Böhme
2016-12-10 6:39 ` Joe Perches
2016-12-09 8:48 ` Kalle Valo
2016-12-06 19:37 ` Dan Carpenter
2016-12-02 1:48 ` [PATCH 11/14] rtlwifi: Add a new enumeration value to btc_set_type Larry Finger
2016-12-02 1:48 ` [PATCH 12/14] rtlwifi: btcoexist: Add vendor definition for new btcoexist Larry Finger
2016-12-02 1:48 ` [PATCH 13/14] rtlwifi: rtl8723be: fix ant_sel code Larry Finger
2016-12-02 1:48 ` [PATCH 14/14] rtlwifi: Add work queue for c2h cmd Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206071340.GB10292@kroah.com \
--to=greg@kroah.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.