From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Greg KH <greg@kroah.com>,
devel@driverdev.osuosl.org, Ping-Ke Shih <pkshih@realtek.com>,
linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex
Date: Wed, 7 Dec 2016 16:32:19 +0300 [thread overview]
Message-ID: <20161207133219.GM8176@mwanda> (raw)
In-Reply-To: <871sxkdjeh.fsf@kamboji.qca.qualcomm.com>
On Wed, Dec 07, 2016 at 02:16:06PM +0200, Kalle Valo wrote:
> We have disccused this before, but for wireless it's not really that
> simple. AFAIK with dyndbg you can only control the messages per line
> (painful to enable group of messages) or per file (enables too many
> messages). In wireless we have cases when we need to enable group of
> messages, but not all.
You can turn them on by the function or a range of lines, then disable
the spammy lines. With these new debug macros you can't do that so this
is a step backwards.
If I'm totally honest, I've never seen uglier macros than these. I work
in staging and I've spent a lot of time in ancient code but these ones
really take the cake.
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-07 13:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 1:48 [PATCH 00/14] rtlwifi: Various updates Larry Finger
2016-12-02 1:48 ` [PATCH 01/14] rtlwifi: Correct power save capability while init mac80211 Larry Finger
2016-12-30 13:10 ` [01/14] " Kalle Valo
2016-12-02 1:48 ` [PATCH 02/14] rtlwifi: Fix programing CAM content sequence Larry Finger
2016-12-05 20:49 ` Dan Carpenter
2016-12-02 1:48 ` [PATCH 03/14] rtlwifi: Set retry limit depends on vif type Larry Finger
2016-12-02 1:48 ` [PATCH 03/14] rtlwifi: extend debug_comp to u64 Larry Finger
2016-12-02 1:48 ` [PATCH 05/14] rtlwifi: Add TX report and disable key will wait until report acked Larry Finger
2016-12-05 21:10 ` Dan Carpenter
2016-12-02 1:48 ` [PATCH 06/14] rtlwifi: rtl8723be: btcoexist: Add single_ant_path Larry Finger
2016-12-02 1:48 ` [PATCH 07/14] rtlwifi: move btcoex's ant_num declaration Larry Finger
2016-12-02 1:48 ` [PATCH 08/14] rtlwifi: rtl8723be: btcoex: add package_type function to btcoex Larry Finger
2016-12-02 1:48 ` [PATCH 09/14] rtlwifi: ibtcoex: move bt_type declaration Larry Finger
2016-12-02 1:48 ` [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex Larry Finger
2016-12-05 21:34 ` Dan Carpenter
2016-12-05 22:34 ` Larry Finger
2016-12-06 7:13 ` Greg KH
2016-12-07 12:16 ` Kalle Valo
2016-12-07 13:32 ` Dan Carpenter [this message]
2016-12-07 16:41 ` Larry Finger
2016-12-08 11:43 ` Kalle Valo
2016-12-08 11:50 ` Dan Carpenter
2016-12-08 11:54 ` Dan Carpenter
2016-12-09 8:50 ` Kalle Valo
2016-12-09 23:56 ` Markus Böhme
2016-12-10 6:39 ` Joe Perches
2016-12-09 8:48 ` Kalle Valo
2016-12-06 19:37 ` Dan Carpenter
2016-12-02 1:48 ` [PATCH 11/14] rtlwifi: Add a new enumeration value to btc_set_type Larry Finger
2016-12-02 1:48 ` [PATCH 12/14] rtlwifi: btcoexist: Add vendor definition for new btcoexist Larry Finger
2016-12-02 1:48 ` [PATCH 13/14] rtlwifi: rtl8723be: fix ant_sel code Larry Finger
2016-12-02 1:48 ` [PATCH 14/14] rtlwifi: Add work queue for c2h cmd Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207133219.GM8176@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.