All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 5/5] mlx5, calc_sq_size(): Make a debug message more informative
Date: Tue, 6 Dec 2016 16:31:59 +0200	[thread overview]
Message-ID: <20161206143159.GB3437@mtr-leonro.local> (raw)
In-Reply-To: <4387aa0f-5097-d456-eee2-b480dfa5af87-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>

On Mon, Dec 05, 2016 at 05:19:52PM -0800, Bart Van Assche wrote:
> Make it clear that qp->sq.wqe_cnt is not the number of WQEs.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
> Cc: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks,
Acked-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

> ---
>  drivers/infiniband/hw/mlx5/qp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index b2c6c13d44ac..735b8aadb84c 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -381,7 +381,8 @@ static int calc_sq_size(struct mlx5_ib_dev *dev, struct ib_qp_init_attr *attr,
>  	wq_size = roundup_pow_of_two(attr->cap.max_send_wr * wqe_size);
>  	qp->sq.wqe_cnt = wq_size / MLX5_SEND_WQE_BB;
>  	if (qp->sq.wqe_cnt > (1 << MLX5_CAP_GEN(dev->mdev, log_max_qp_sz))) {
> -		mlx5_ib_dbg(dev, "wqe count(%d) exceeds limits(%d)\n",
> +		mlx5_ib_dbg(dev, "send queue size (%d * %d / %d -> %d) exceeds limits(%d)\n",
> +			    attr->cap.max_send_wr, wqe_size, MLX5_SEND_WQE_BB,
>  			    qp->sq.wqe_cnt,
>  			    1 << MLX5_CAP_GEN(dev->mdev, log_max_qp_sz));
>  		return -ENOMEM;
> -- 
> 2.11.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-12-06 14:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06  1:17 [PATCH 0/5] mlx5 patches for kernel v4.10 Bart Van Assche
     [not found] ` <9ff07804-492c-c67a-e729-b31e0f863027-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06  1:18   ` [PATCH 1/5] mlx5: Use NULL instead of 0 to represent a pointer Bart Van Assche
     [not found]     ` <16dc2a07-86f7-ce47-7b0c-1da03e58d99f-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06 13:59       ` Leon Romanovsky
     [not found]         ` <20161206135917.GC2437-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-06 16:28           ` Jason Gunthorpe
2016-12-06 16:29           ` Bart Van Assche
     [not found]             ` <a8d3dbb7-aafa-c5af-5d06-78d1f4914c5d-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-07  8:21               ` Leon Romanovsky
     [not found]                 ` <20161207082110.GA11857-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-14 18:44                   ` Doug Ledford
2016-12-06  1:18   ` [PATCH 2/5] mlx5: Remove a set-but-not-used variable Bart Van Assche
     [not found]     ` <f1351e2c-915d-9883-838b-d3c50f27da17-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06 14:24       ` Leon Romanovsky
     [not found]         ` <20161206142441.GA3437-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-14 18:45           ` Doug Ledford
2016-12-06  1:19   ` [PATCH 3/5] mlx5: Avoid that sparse complains about dubious !x & y expressions Bart Van Assche
     [not found]     ` <572c702f-589f-2d5a-9e13-45223191db85-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-08  9:26       ` Or Gerlitz
     [not found]         ` <CAJ3xEMjPZYgLhDi_6Jxkx_dg_RaehD=3SchMt_noLzQEChPrxQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-08 17:52           ` Bart Van Assche
2016-12-08 17:53           ` Jason Gunthorpe
     [not found]             ` <20161208175322.GB11025-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-14 18:46               ` Doug Ledford
2016-12-06  1:19   ` [PATCH 4/5] mlx5: Fix mlx5_srq_attr.pas endianness annotation Bart Van Assche
     [not found]     ` <3d4f5ffa-e9bf-cd28-d200-74c5dd3d68ce-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06 13:55       ` Leon Romanovsky
2016-12-06  1:19   ` [PATCH 5/5] mlx5, calc_sq_size(): Make a debug message more informative Bart Van Assche
     [not found]     ` <4387aa0f-5097-d456-eee2-b480dfa5af87-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06 14:31       ` Leon Romanovsky [this message]
     [not found]         ` <20161206143159.GB3437-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-14 18:46           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161206143159.GB3437@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.