All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Saeed Mahameed <saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 3/5] mlx5: Avoid that sparse complains about dubious !x & y expressions
Date: Thu, 8 Dec 2016 09:52:20 -0800	[thread overview]
Message-ID: <eb8fd218-eefb-d836-ac61-e394fd113240@sandisk.com> (raw)
In-Reply-To: <CAJ3xEMjPZYgLhDi_6Jxkx_dg_RaehD=3SchMt_noLzQEChPrxQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 12/08/2016 01:26 AM, Or Gerlitz wrote:
> Matan came up with a fix (below) which solves all these sparse
> complaints in both drivers (mlx5 IB and core)
> while basically not touching the code, we will be going with that fix
> to 4.11, thanks, I will add reported
> by pointing to you.

Hello Or,

Please consider to keep the following change:

-	MLX5_SET(mkc, mkc, en_rinval, !!((type == IB_MW_TYPE_2)));
+	MLX5_SET(mkc, mkc, en_rinval, type == IB_MW_TYPE_2);

I don't think that specifying two boolean not (!) operators in front of 
a boolean expression is useful :-)

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-12-08 17:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06  1:17 [PATCH 0/5] mlx5 patches for kernel v4.10 Bart Van Assche
     [not found] ` <9ff07804-492c-c67a-e729-b31e0f863027-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06  1:18   ` [PATCH 1/5] mlx5: Use NULL instead of 0 to represent a pointer Bart Van Assche
     [not found]     ` <16dc2a07-86f7-ce47-7b0c-1da03e58d99f-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06 13:59       ` Leon Romanovsky
     [not found]         ` <20161206135917.GC2437-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-06 16:28           ` Jason Gunthorpe
2016-12-06 16:29           ` Bart Van Assche
     [not found]             ` <a8d3dbb7-aafa-c5af-5d06-78d1f4914c5d-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-07  8:21               ` Leon Romanovsky
     [not found]                 ` <20161207082110.GA11857-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-14 18:44                   ` Doug Ledford
2016-12-06  1:18   ` [PATCH 2/5] mlx5: Remove a set-but-not-used variable Bart Van Assche
     [not found]     ` <f1351e2c-915d-9883-838b-d3c50f27da17-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06 14:24       ` Leon Romanovsky
     [not found]         ` <20161206142441.GA3437-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-14 18:45           ` Doug Ledford
2016-12-06  1:19   ` [PATCH 3/5] mlx5: Avoid that sparse complains about dubious !x & y expressions Bart Van Assche
     [not found]     ` <572c702f-589f-2d5a-9e13-45223191db85-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-08  9:26       ` Or Gerlitz
     [not found]         ` <CAJ3xEMjPZYgLhDi_6Jxkx_dg_RaehD=3SchMt_noLzQEChPrxQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-08 17:52           ` Bart Van Assche [this message]
2016-12-08 17:53           ` Jason Gunthorpe
     [not found]             ` <20161208175322.GB11025-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-14 18:46               ` Doug Ledford
2016-12-06  1:19   ` [PATCH 4/5] mlx5: Fix mlx5_srq_attr.pas endianness annotation Bart Van Assche
     [not found]     ` <3d4f5ffa-e9bf-cd28-d200-74c5dd3d68ce-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06 13:55       ` Leon Romanovsky
2016-12-06  1:19   ` [PATCH 5/5] mlx5, calc_sq_size(): Make a debug message more informative Bart Van Assche
     [not found]     ` <4387aa0f-5097-d456-eee2-b480dfa5af87-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-06 14:31       ` Leon Romanovsky
     [not found]         ` <20161206143159.GB3437-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-14 18:46           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb8fd218-eefb-d836-ac61-e394fd113240@sandisk.com \
    --to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
    --cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.