[meta-raspberrypi][PATCH] Do not rely on DISTRO_TYPE to enable/disable kernel debug

[meta-raspberrypi][PATCH] Do not rely on DISTRO_TYPE to enable/disable kernel debug

[Frank Meerkoetter]

DISTRO_TYPE doesn't seem to be set anywhere in OE/poky. This causes
CMDLINE_DEBUG to default to "debug" which is very noisy. This is
especially true when building a systemd based system, as systemd
also looks at the kernel commandline to set the debug level.
Such a system is nearly unuseable from the serial console due
to the amount of data logged by systemd.
---
 recipes-kernel/linux/linux-rpi.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/recipes-kernel/linux/linux-rpi.inc b/recipes-kernel/linux/linux-rpi.inc
index 95a9530..53383b0 100644
--- a/recipes-kernel/linux/linux-rpi.inc
+++ b/recipes-kernel/linux/linux-rpi.inc
@@ -13,9 +13,9 @@ ARM_KEEP_OABI ?= "1"
 # Quirk for udev greater or equal 141
 UDEV_GE_141 ?= "1"
 
-# Set the verbosity of kernel messages during runtime
-# You can define CMDLINE_DEBUG in your local.conf or distro.conf to override this behaviour
-CMDLINE_DEBUG ?= '${@base_conditional("DISTRO_TYPE", "release", "quiet", "debug", d)}'
+# You can define CMDLINE_DEBUG as "debug" in your local.conf or distro.conf
+# to enable kernel debugging.
+CMDLINE_DEBUG ?= ""
 CMDLINE_append = " ${CMDLINE_DEBUG}"
 
 KERNEL_INITRAMFS ?= '${@base_conditional("INITRAMFS_IMAGE_BUNDLE", "1", "1", "", d)}'
-- 
2.7.4

Re: [meta-raspberrypi][PATCH] Do not rely on DISTRO_TYPE to enable/disable kernel debug

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

On Mon, Nov 28, 2016 at 08:37:45PM +0100, Frank Meerkoetter wrote:
> DISTRO_TYPE doesn't seem to be set anywhere in OE/poky. This causes
> CMDLINE_DEBUG to default to "debug" which is very noisy. This is
> especially true when building a systemd based system, as systemd
> also looks at the kernel commandline to set the debug level.
> Such a system is nearly unuseable from the serial console due
> to the amount of data logged by systemd.
> ---
>  recipes-kernel/linux/linux-rpi.inc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/recipes-kernel/linux/linux-rpi.inc b/recipes-kernel/linux/linux-rpi.inc
> index 95a9530..53383b0 100644
> --- a/recipes-kernel/linux/linux-rpi.inc
> +++ b/recipes-kernel/linux/linux-rpi.inc
> @@ -13,9 +13,9 @@ ARM_KEEP_OABI ?= "1"
>  # Quirk for udev greater or equal 141
>  UDEV_GE_141 ?= "1"
>
> -# Set the verbosity of kernel messages during runtime
> -# You can define CMDLINE_DEBUG in your local.conf or distro.conf to override this behaviour
> -CMDLINE_DEBUG ?= '${@base_conditional("DISTRO_TYPE", "release", "quiet", "debug", d)}'
> +# You can define CMDLINE_DEBUG as "debug" in your local.conf or distro.conf
> +# to enable kernel debugging.
> +CMDLINE_DEBUG ?= ""
>  CMDLINE_append = " ${CMDLINE_DEBUG}"
>
>  KERNEL_INITRAMFS ?= '${@base_conditional("INITRAMFS_IMAGE_BUNDLE", "1", "1", "", d)}'
> --

I like this. Let's merge it. Master it is.

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 817 bytes --]

Re: [meta-raspberrypi][PATCH] Do not rely on DISTRO_TYPE to enable/disable kernel debug

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

On Mon, Nov 28, 2016 at 08:37:45PM +0100, Frank Meerkoetter wrote:
> DISTRO_TYPE doesn't seem to be set anywhere in OE/poky. This causes
> CMDLINE_DEBUG to default to "debug" which is very noisy. This is
> especially true when building a systemd based system, as systemd
> also looks at the kernel commandline to set the debug level.
> Such a system is nearly unuseable from the serial console due
> to the amount of data logged by systemd.
> ---
>  recipes-kernel/linux/linux-rpi.inc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/recipes-kernel/linux/linux-rpi.inc b/recipes-kernel/linux/linux-rpi.inc
> index 95a9530..53383b0 100644
> --- a/recipes-kernel/linux/linux-rpi.inc
> +++ b/recipes-kernel/linux/linux-rpi.inc
> @@ -13,9 +13,9 @@ ARM_KEEP_OABI ?= "1"
>  # Quirk for udev greater or equal 141
>  UDEV_GE_141 ?= "1"
>
> -# Set the verbosity of kernel messages during runtime
> -# You can define CMDLINE_DEBUG in your local.conf or distro.conf to override this behaviour
> -CMDLINE_DEBUG ?= '${@base_conditional("DISTRO_TYPE", "release", "quiet", "debug", d)}'
> +# You can define CMDLINE_DEBUG as "debug" in your local.conf or distro.conf
> +# to enable kernel debugging.
> +CMDLINE_DEBUG ?= ""
>  CMDLINE_append = " ${CMDLINE_DEBUG}"
>
>  KERNEL_INITRAMFS ?= '${@base_conditional("INITRAMFS_IMAGE_BUNDLE", "1", "1", "", d)}'

I had to change the git log a little. Please make sure you submit other
patches using the format described here:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Thanks for you contribution.

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 817 bytes --]