[PATCH V2] ti-sgx-ddk-um: fix a bug at the drmModeAddFB() call at null_drm_ws.c

[PATCH V2] ti-sgx-ddk-um: fix a bug at the drmModeAddFB() call at null_drm_ws.c

[Eric Ruei]

Both parameter depth and bpp are set to uiPixelWidthInBits at the current
implementation, however, the depth may not be the same as bpp for certain
pixel format such as XRGB8888. This bug was exposed by the recent DRM
driver change introducing strict error checking. To fix this problem,
add utility function uiPixelDepthInBits to derive and use depth based on
the pixel format.

Signed-off-by: Eric Ruei <e-ruei1@ti.com>
---
 recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
index 770cda2..5903b2e 100644
--- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
+++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
@@ -8,7 +8,7 @@ PACKAGE_ARCH = "${MACHINE_ARCH}"
 BRANCH = "ti-img-sgx/${PV}"
 
 SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-um-linux.git;protocol=git;branch=${BRANCH}"
-SRCREV = "a5152f0b90bf3916eb1f478ac9fefe7d7ebe8bd9"
+SRCREV = "3c0537748dd283b2de9c5369570aa2aade5a9979"
 
 # There's only hardfp version available
 python __anonymous() {
@@ -31,7 +31,7 @@ INITSCRIPT_PARAMS = "defaults 8"
 
 inherit update-rc.d
 
-PR = "r17"
+PR = "r18"
 PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 omap5-sgx-ddk-um-linux"
 
 DEPENDS += "libdrm udev libgbm wayland libffi"
-- 
1.9.1

Re: [PATCH V2] ti-sgx-ddk-um: fix a bug at the drmModeAddFB() call at null_drm_ws.c

[Denys Dmytriyenko]

Applied, thanks! It was sent to the wrong list, though...


On Wed, Dec 07, 2016 at 10:00:59AM -0500, Eric Ruei wrote:
> Both parameter depth and bpp are set to uiPixelWidthInBits at the current
> implementation, however, the depth may not be the same as bpp for certain
> pixel format such as XRGB8888. This bug was exposed by the recent DRM
> driver change introducing strict error checking. To fix this problem,
> add utility function uiPixelDepthInBits to derive and use depth based on
> the pixel format.
> 
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
>  recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> index 770cda2..5903b2e 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.14.3699939.bb
> @@ -8,7 +8,7 @@ PACKAGE_ARCH = "${MACHINE_ARCH}"
>  BRANCH = "ti-img-sgx/${PV}"
>  
>  SRC_URI = "git://git.ti.com/graphics/omap5-sgx-ddk-um-linux.git;protocol=git;branch=${BRANCH}"
> -SRCREV = "a5152f0b90bf3916eb1f478ac9fefe7d7ebe8bd9"
> +SRCREV = "3c0537748dd283b2de9c5369570aa2aade5a9979"
>  
>  # There's only hardfp version available
>  python __anonymous() {
> @@ -31,7 +31,7 @@ INITSCRIPT_PARAMS = "defaults 8"
>  
>  inherit update-rc.d
>  
> -PR = "r17"
> +PR = "r18"
>  PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 omap5-sgx-ddk-um-linux"
>  
>  DEPENDS += "libdrm udev libgbm wayland libffi"
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago