From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: devel@driverdev.osuosl.org, Chris Cesare <chris.cesare@gmail.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Ian Abbott <abbotti@mev.co.uk>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/5] staging-COMEDI: Fine-tuning for three functions
Date: Thu, 08 Dec 2016 13:30:19 +0000 [thread overview]
Message-ID: <20161208133019.GA30859@kroah.com> (raw)
In-Reply-To: <8cddc37d-4529-ada4-ac21-20e09e888d0d@users.sourceforge.net>
On Thu, Dec 08, 2016 at 12:30:20PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 8 Dec 2016 11:37:37 +0100
>
> Some update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (5):
> Combine four kcalloc() calls into one in serial2002_setup_subdevs()
> Split a condition check in usbdux_alloc_usb_buffers()
> Move an assignment in usbdux_alloc_usb_buffers()
> Split a condition check in usbduxsigma_alloc_usb_buffers()
> Move an assignment in usbduxsigma_alloc_usb_buffers()
>
> drivers/staging/comedi/drivers/serial2002.c | 22 +++++-----
> drivers/staging/comedi/drivers/usbdux.c | 56 ++++++++++++++++++-----
> drivers/staging/comedi/drivers/usbduxsigma.c | 66 ++++++++++++++++++++++------
> 3 files changed, 108 insertions(+), 36 deletions(-)
You do realize that I no longer take patches from you for any of the
subsystems I maintain, right? This patch series is one reason why...
I suggest working on other projects to learn C better first.
best of luck,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: devel@driverdev.osuosl.org, Chris Cesare <chris.cesare@gmail.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Ian Abbott <abbotti@mev.co.uk>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/5] staging-COMEDI: Fine-tuning for three functions
Date: Thu, 8 Dec 2016 14:30:19 +0100 [thread overview]
Message-ID: <20161208133019.GA30859@kroah.com> (raw)
In-Reply-To: <8cddc37d-4529-ada4-ac21-20e09e888d0d@users.sourceforge.net>
On Thu, Dec 08, 2016 at 12:30:20PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 8 Dec 2016 11:37:37 +0100
>
> Some update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (5):
> Combine four kcalloc() calls into one in serial2002_setup_subdevs()
> Split a condition check in usbdux_alloc_usb_buffers()
> Move an assignment in usbdux_alloc_usb_buffers()
> Split a condition check in usbduxsigma_alloc_usb_buffers()
> Move an assignment in usbduxsigma_alloc_usb_buffers()
>
> drivers/staging/comedi/drivers/serial2002.c | 22 +++++-----
> drivers/staging/comedi/drivers/usbdux.c | 56 ++++++++++++++++++-----
> drivers/staging/comedi/drivers/usbduxsigma.c | 66 ++++++++++++++++++++++------
> 3 files changed, 108 insertions(+), 36 deletions(-)
You do realize that I no longer take patches from you for any of the
subsystems I maintain, right? This patch series is one reason why...
I suggest working on other projects to learn C better first.
best of luck,
greg k-h
next prev parent reply other threads:[~2016-12-08 13:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 11:30 [PATCH 0/5] staging-COMEDI: Fine-tuning for three functions SF Markus Elfring
2016-12-08 11:30 ` SF Markus Elfring
2016-12-08 11:33 ` [PATCH 1/5] staging: comedi: serial2002: Combine four kcalloc() calls into one in serial2002_setup_s SF Markus Elfring
2016-12-08 11:33 ` [PATCH 1/5] staging: comedi: serial2002: Combine four kcalloc() calls into one in serial2002_setup_subdevs() SF Markus Elfring
2016-12-08 12:22 ` [PATCH 1/5] staging: comedi: serial2002: Combine four kcalloc() calls into one in serial2002_set Dan Carpenter
2016-12-08 12:22 ` [PATCH 1/5] staging: comedi: serial2002: Combine four kcalloc() calls into one in serial2002_setup_subdevs() Dan Carpenter
2016-12-08 11:34 ` [PATCH 2/5] staging: comedi: usbdux: Split a condition check in usbdux_alloc_usb_buffers() SF Markus Elfring
2016-12-08 11:34 ` SF Markus Elfring
2016-12-08 12:35 ` Dan Carpenter
2016-12-08 12:35 ` Dan Carpenter
2016-12-08 12:37 ` Dan Carpenter
2016-12-08 12:37 ` Dan Carpenter
2016-12-08 12:44 ` Ian Abbott
2016-12-08 12:44 ` Ian Abbott
2016-12-08 15:43 ` SF Markus Elfring
2016-12-08 15:43 ` SF Markus Elfring
2016-12-08 11:35 ` [PATCH 3/5] staging: comedi: usbdux: Move an assignment " SF Markus Elfring
2016-12-08 11:35 ` SF Markus Elfring
2016-12-08 12:40 ` Dan Carpenter
2016-12-08 12:40 ` Dan Carpenter
2016-12-08 11:37 ` [PATCH 4/5] staging: comedi: usbduxsigma: Split a condition check in usbduxsigma_alloc_usb_buffers() SF Markus Elfring
2016-12-08 11:37 ` SF Markus Elfring
2016-12-08 12:51 ` [PATCH 4/5] staging: comedi: usbduxsigma: Split a condition check in usbduxsigma_alloc_usb_buffe Ian Abbott
2016-12-08 12:51 ` [PATCH 4/5] staging: comedi: usbduxsigma: Split a condition check in usbduxsigma_alloc_usb_buffers() Ian Abbott
2016-12-08 15:46 ` SF Markus Elfring
2016-12-08 15:46 ` SF Markus Elfring
2016-12-08 18:12 ` Ian Abbott
2016-12-08 18:12 ` Ian Abbott
2016-12-08 11:38 ` [PATCH 5/5] staging: comedi: usbduxsigma: Move an assignment " SF Markus Elfring
2016-12-08 11:38 ` SF Markus Elfring
2016-12-08 13:30 ` Greg Kroah-Hartman [this message]
2016-12-08 13:30 ` [PATCH 0/5] staging-COMEDI: Fine-tuning for three functions Greg Kroah-Hartman
2016-12-08 15:26 ` SF Markus Elfring
2016-12-08 15:26 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208133019.GA30859@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=chris.cesare@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=elfring@users.sourceforge.net \
--cc=hsweeten@visionengravers.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.