From: Quentin Lambert <lambert.quentin@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: Quentin Lambert <lambert.quentin@gmail.com>
Subject: [PATCH] staging: lustre: Fix variable type declaration after refactoring
Date: Thu, 08 Dec 2016 16:07:59 +0000 [thread overview]
Message-ID: <20161208160759.19649-1-lambert.quentin@gmail.com> (raw)
A recent clean-up declared och_flags as a int rather than fmode_t. This
lead to the following sparse warning:
drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
fmode_t degrades to integer
This patch fixes this issue.
Fixes: 1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/staging/lustre/lustre/include/obd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_client_handle {
struct md_open_data *och_mod;
struct lustre_handle och_lease_handle; /* open lock for lease */
__u32 och_magic;
- int och_flags;
+ fmode_t och_flags;
};
#define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Lambert <lambert.quentin@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: Quentin Lambert <lambert.quentin@gmail.com>
Subject: [lustre-devel] [PATCH] staging: lustre: Fix variable type declaration after refactoring
Date: Thu, 8 Dec 2016 17:07:59 +0100 [thread overview]
Message-ID: <20161208160759.19649-1-lambert.quentin@gmail.com> (raw)
A recent clean-up declared och_flags as a int rather than fmode_t. This
lead to the following sparse warning:
drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
fmode_t degrades to integer
This patch fixes this issue.
Fixes: 1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/staging/lustre/lustre/include/obd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_client_handle {
struct md_open_data *och_mod;
struct lustre_handle och_lease_handle; /* open lock for lease */
__u32 och_magic;
- int och_flags;
+ fmode_t och_flags;
};
#define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Lambert <lambert.quentin@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: Quentin Lambert <lambert.quentin@gmail.com>
Subject: [PATCH] staging: lustre: Fix variable type declaration after refactoring
Date: Thu, 8 Dec 2016 17:07:59 +0100 [thread overview]
Message-ID: <20161208160759.19649-1-lambert.quentin@gmail.com> (raw)
A recent clean-up declared och_flags as a int rather than fmode_t. This
lead to the following sparse warning:
drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
fmode_t degrades to integer
This patch fixes this issue.
Fixes: 1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/staging/lustre/lustre/include/obd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_client_handle {
struct md_open_data *och_mod;
struct lustre_handle och_lease_handle; /* open lock for lease */
__u32 och_magic;
- int och_flags;
+ fmode_t och_flags;
};
#define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
next reply other threads:[~2016-12-08 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 16:07 Quentin Lambert [this message]
2016-12-08 16:07 ` [PATCH] staging: lustre: Fix variable type declaration after refactoring Quentin Lambert
2016-12-08 16:07 ` [lustre-devel] " Quentin Lambert
2016-12-08 19:36 ` Dan Carpenter
2016-12-08 19:36 ` Dan Carpenter
2016-12-08 19:36 ` [lustre-devel] " Dan Carpenter
2016-12-08 20:38 ` [PATCH v2] " Quentin Lambert
2016-12-08 20:38 ` Quentin Lambert
2016-12-08 20:38 ` [lustre-devel] " Quentin Lambert
2016-12-19 16:38 ` James Simmons
2016-12-19 16:38 ` James Simmons
2016-12-19 16:38 ` [lustre-devel] " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208160759.19649-1-lambert.quentin@gmail.com \
--to=lambert.quentin@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.