From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] python-protobuf: Allow host building
Date: Sat, 10 Dec 2016 15:38:17 +0100 [thread overview]
Message-ID: <20161210153817.485b25d3@free-electrons.com> (raw)
In-Reply-To: <20161209011313.9549-2-wak@google.com>
Hello,
On Thu, 8 Dec 2016 17:13:11 -0800, William A. Kennington III wrote:
> Currently python-protobuf does not allow the building as a host package
> during a cross compile. We would like to be able to build nanopb as a
> host package but can't without host-python-protobuf.
This patch looks good, but also doesn't apply:
thomas at skate:~/projets/buildroot (master)$ git pwam 704278
Applying patch #704278 using 'git am -s -3'
Description: [1/3] python-protobuf: Allow host building
Applying: python-protobuf: Allow host building
fatal: sha1 information is lacking or useless (package/python-protobuf/python-protobuf.mk).
error: could not build fake ancestor
Patch failed at 0001 python-protobuf: Allow host building
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
> Google-Bug-Id: 33072942
> Change-Id: Id09f461bda3f9c7a0bd6b5c36a6a8fa92e4adb27
Please remove those two lines.
> Signed-off-by: William A. Kennington III <wak@google.com>
> ---
> package/python-protobuf/python-protobuf.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/python-protobuf/python-protobuf.mk
> b/package/python-protobuf/python-protobuf.mk
> index d8be76d..d46bda2 100644
> --- a/package/python-protobuf/python-protobuf.mk
> +++ b/package/python-protobuf/python-protobuf.mk
> @@ -13,4 +13,5 @@ PYTHON_PROTOBUF_DEPENDENCIES = host-protobuf
> PYTHON_PROTOBUF_SETUP_TYPE = setuptools
> PYTHON_PROTOBUF_SUBDIR = python
>
> +$(eval $(host-python-package))
> $(eval $(python-package))
The way the added line is indented compared to the context lines make
it look weird. It's probably why it doesn't apply.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-12-10 14:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 1:13 [Buildroot] [PATCH 0/3] pblog: Add new package William A. Kennington III
2016-12-09 1:13 ` [Buildroot] [PATCH 1/3] python-protobuf: Allow host building William A. Kennington III
2016-12-10 14:38 ` Thomas Petazzoni [this message]
2016-12-09 1:13 ` [Buildroot] [PATCH 2/3] nanopb: Init at 69e9c1fc8162956feffa32e07a97c53bdb92f5ef William A. Kennington III
2016-12-10 14:37 ` Thomas Petazzoni
2016-12-09 1:13 ` [Buildroot] [PATCH 3/3] pblog: Init at e2e17544950eedac4f3bc59926aed8604d755072 William A. Kennington III
2016-12-10 14:41 ` Thomas Petazzoni
2017-01-12 19:15 ` [Buildroot] [PATCH v2 0/3] pblog: new package William A. Kennington III
2017-01-12 19:15 ` [Buildroot] [PATCH v2 1/3] python-protobuf: Allow host building William A. Kennington III
2017-01-15 21:30 ` Yann E. MORIN
2017-01-17 22:09 ` Arnout Vandecappelle
2017-01-15 21:32 ` Yann E. MORIN
2017-01-12 19:15 ` [Buildroot] [PATCH v2 2/3] nanopb: new package William A. Kennington III
2017-01-15 21:51 ` Yann E. MORIN
2017-01-18 18:59 ` William Kennington
2017-01-12 19:15 ` [Buildroot] [PATCH v2 3/3] pblog: " William A. Kennington III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161210153817.485b25d3@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.