From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] pblog: Init at e2e17544950eedac4f3bc59926aed8604d755072
Date: Sat, 10 Dec 2016 15:41:20 +0100 [thread overview]
Message-ID: <20161210154120.5650d0a0@free-electrons.com> (raw)
In-Reply-To: <20161209011313.9549-4-wak@google.com>
Hello,
Like the other patches, this patch is badly wrapped and therefore does
not apply. Its title should be just:
pblog: new package
On Thu, 8 Dec 2016 17:13:13 -0800, William A. Kennington III wrote:
> diff --git a/package/pblog/Config.in b/package/pblog/Config.in
> new file mode 100644
> index 0000000..2ef77a8
> --- /dev/null
> +++ b/package/pblog/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PBLOG
> + bool "pblog"
> + depends BR2_PACKAGE_HOST_NANOPB
> + select BR2_PACKAGE_HOST_NANOPB
There is no BR2_PACKAGE_HOST_NANOPB symbol. Also, "depends" doesn't
exist, only "depends on" does. And doing a "depends on" and a "select"
on the same symbol doesn't make any sense.
> diff --git a/package/pblog/pblog.hash b/package/pblog/pblog.hash
> new file mode 100644
> index 0000000..e7f8dc5
> --- /dev/null
> +++ b/package/pblog/pblog.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 f5908706afe15041983f163da735db751dda82f20c84e60c0c59584d609f10eb
> pblog-e2e17544950eedac4f3bc59926aed8604d755072.tar.gz
Badly wrapped.
> diff --git a/package/pblog/pblog.mk b/package/pblog/pblog.mk
> new file mode 100644
> index 0000000..e5a2cd1
> --- /dev/null
> +++ b/package/pblog/pblog.mk
> @@ -0,0 +1,27 @@
> +################################################################################
> +#
> +# pblog
> +#
> +################################################################################
> +
> +PBLOG_VERSION = e2e17544950eedac4f3bc59926aed8604d755072
> +PBLOG_SITE = $(call github,google,pblog,$(PBLOG_VERSION))
> +PBLOG_LICENSE = Apache-2.0
> +PBLOG_LICENSE_FILES = LICENSE.txt
> +# no configure script
Comment unneeded.
> +PBLOG_DEPENDENCIES = host-nanopb
So, the target nanopb package is useless?
> +
> +define PBLOG_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS)
> NANOPB_DIR=$(HOST_NANOPB_DIR) -C $(@D) all
Please install nanopb to $(HOST_DIR) and use it from there.
> +endef
> +
> +define PBLOG_INSTALL_STAGING_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS)
> NANOPB_DIR=$(HOST_NANOPB_DIR) DESTDIR=$(STAGING_DIR) -C $(@D) install
> +endef
If you specific some staging installation commands, you must have a
PBLOG_INSTALL_STAGING = YES otherwise those commands are completely
ignored.
> +
> +define PBLOG_INSTALL_TARGET_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS)
> NANOPB_DIR=$(HOST_NANOPB_DIR) DESTDIR=$(TARGET_DIR) -C $(@D) install
> +endef
More global commands: please split long lines, like this:
$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
NANOPB_DIR=... \
DESTDIR=... \
-C $(@D) install
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-12-10 14:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 1:13 [Buildroot] [PATCH 0/3] pblog: Add new package William A. Kennington III
2016-12-09 1:13 ` [Buildroot] [PATCH 1/3] python-protobuf: Allow host building William A. Kennington III
2016-12-10 14:38 ` Thomas Petazzoni
2016-12-09 1:13 ` [Buildroot] [PATCH 2/3] nanopb: Init at 69e9c1fc8162956feffa32e07a97c53bdb92f5ef William A. Kennington III
2016-12-10 14:37 ` Thomas Petazzoni
2016-12-09 1:13 ` [Buildroot] [PATCH 3/3] pblog: Init at e2e17544950eedac4f3bc59926aed8604d755072 William A. Kennington III
2016-12-10 14:41 ` Thomas Petazzoni [this message]
2017-01-12 19:15 ` [Buildroot] [PATCH v2 0/3] pblog: new package William A. Kennington III
2017-01-12 19:15 ` [Buildroot] [PATCH v2 1/3] python-protobuf: Allow host building William A. Kennington III
2017-01-15 21:30 ` Yann E. MORIN
2017-01-17 22:09 ` Arnout Vandecappelle
2017-01-15 21:32 ` Yann E. MORIN
2017-01-12 19:15 ` [Buildroot] [PATCH v2 2/3] nanopb: new package William A. Kennington III
2017-01-15 21:51 ` Yann E. MORIN
2017-01-18 18:59 ` William Kennington
2017-01-12 19:15 ` [Buildroot] [PATCH v2 3/3] pblog: " William A. Kennington III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161210154120.5650d0a0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.