All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-generic: run $(PKG)_PRE_RSYNC_HOOKS before checking for the existence of $(SRCDIR)
Date: Sun, 11 Dec 2016 20:19:54 +0100	[thread overview]
Message-ID: <20161211191954.GE3599@free.fr> (raw)
In-Reply-To: <1481479965-26226-1-git-send-email-tal.shorer@gmail.com>

Tal, All,

On 2016-12-11 20:12 +0200, Tal Shorer spake thusly:
> This will allow packages to define their pre-rsync hooks which will be
> guaranteed to run even if the source is missing.
> 
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>

Before this goes in, we have to notice that packages (most probably,
out-of-tree packages in a br2-external tree) that defined hooks that
relied on the check to be done before the hooks are called, may now
break with this change.

However, I still believe this change is good, because it ensures the
hooks are called before the infra does anything, which is what we do in
all the other similar commands; also, there are valid cases where we
want the hooks to run first.

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/pkg-generic.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 827de62..3ca71b0 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -161,8 +161,8 @@ $(BUILD_DIR)/%/.stamp_extracted:
>  # used.
>  $(BUILD_DIR)/%/.stamp_rsynced:
>  	@$(call MESSAGE,"Syncing from source dir $(SRCDIR)")
> -	@test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1)
>  	$(foreach hook,$($(PKG)_PRE_RSYNC_HOOKS),$(call $(hook))$(sep))
> +	@test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1)
>  	rsync -au --chmod=u=rwX,go=rX $(RSYNC_VCS_EXCLUSIONS) $(call qstrip,$(SRCDIR))/ $(@D)
>  	$(foreach hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep))
>  	$(Q)touch $@
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-12-11 19:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09  8:37 [Buildroot] [PATCH] usbip: add a new package Tal Shorer
2016-12-10 13:31 ` Thomas Petazzoni
2016-12-10 18:39   ` Tal Shorer
2016-12-11 10:06     ` Yann E. MORIN
2016-12-11 13:56 ` Yann E. MORIN
2016-12-11 17:39   ` Tal Shorer
2016-12-11 17:45     ` Yann E. MORIN
2016-12-11 18:12       ` [Buildroot] [PATCH] pkg-generic: run $(PKG)_PRE_RSYNC_HOOKS before checking for the existence of $(SRCDIR) Tal Shorer
2016-12-11 19:19         ` Yann E. MORIN [this message]
2016-12-11 19:44         ` [Buildroot] [PATCH] package/usbip: new package Tal Shorer
2016-12-17 15:00         ` [Buildroot] [PATCH] pkg-generic: run $(PKG)_PRE_RSYNC_HOOKS before checking for the existence of $(SRCDIR) Thomas Petazzoni
2016-12-11 18:31       ` [Buildroot] [PATCH] usbip: add a new package Tal Shorer
2016-12-11 19:24         ` Yann E. MORIN
2016-12-11 19:59     ` Arnout Vandecappelle
2016-12-11 21:40       ` Yann E. MORIN
2016-12-11 21:46       ` Tal Shorer
2016-12-11 22:05         ` Yann E. MORIN
2016-12-11 22:11           ` Tal Shorer
2016-12-11 22:20             ` Yann E. MORIN
2016-12-11 22:30               ` Tal Shorer
2016-12-12  9:40                 ` Arnout Vandecappelle
2016-12-12 17:25                   ` Yann E. MORIN
2016-12-12 22:17                     ` Tal Shorer
2016-12-12 22:21                       ` [Buildroot] [PATCH v3] usbip: " Tal Shorer
2016-12-13 17:53                         ` Yann E. MORIN
2016-12-14 17:28                           ` [Buildroot] [PATCH v4] " Tal Shorer
2016-12-21 22:17                             ` Tal Shorer
2016-12-22 20:45                             ` Yann E. MORIN
2016-12-23 18:24                             ` Yann E. MORIN
2016-12-23 19:10                               ` Yann E. MORIN
2016-12-13 17:35                       ` [Buildroot] [PATCH] usbip: add a " Yann E. MORIN
2016-12-12 17:09                 ` [Buildroot] [PATCH v2 1/2] package: linux-tools: allow tools to define configure hooks Tal Shorer
2016-12-12 17:09                   ` [Buildroot] [PATCH v2 2/2] package: linux-tools: add usbip Tal Shorer
2016-12-12 17:26                     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161211191954.GE3599@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.