All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] usbip: add a new package
Date: Sun, 11 Dec 2016 20:24:56 +0100	[thread overview]
Message-ID: <20161211192456.GF3599@free.fr> (raw)
In-Reply-To: <CAFDyS3OkzvjXUkcOVd1FWy4Q4tWy+gOe=1DA5aJZk=0oCex+fQ@mail.gmail.com>

Tal, All,

On 2016-12-11 20:31 +0200, Tal Shorer spake thusly:
> On Sun, Dec 11, 2016 at 7:45 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> [--SNIP--]
> >> I tried getting this hook to run, but since the site method is "local",
> >> the package just gets rsynced. However, trying to add this to
> >> USBIP_PRE_RSYNC_HOOKS doesn't help either because the rsync rule checks
> >> for the source directory before calling the PRE_RSYNC_HOOKS.
> >
> > Damn it...
> >
> > I think this is a shortcoming in the rsync method: the hooks should be
> > called even before we try to run-or-test anything. I.e. the hooks should
> > be called before we do the test.
> >
> > Care to send a patch for that?
> >
> > Regards,
> > Yann E. MORIN.
> >
> done.

Thanks! :-)

> Should I wait for that patch to get noticed or should I just
> send what I have with PRE_RSYNC_HOOKS and expect that the error will
> "fix itself" when the other patch gets in?

You can just send the patch now, and add in a post-commit log that the
other patch is required first, i.e. in your commit log, add a three-dash
line and the message after it, like so:

    package/usbip: new package

    usbip is part of the linus tree, so it should be part of the
    linux-tools infra. However, it uses autotools, which are rather
    difficult to use in the linux-tools infra.

    So we make it a proper, separate autotools package. We only rely omn
    the kernel to be extracted and use that as the source.

    Signed-off-by: You

    ---
    Note: this requires that the patch to fix the hook order in the
    rsync command (https://patchwork.ozlabs.org/patch/704859/) goes
    in first.

And cherry-on-the-cake, make it a reply to that patch, with --in-reply-to
when sending the patch.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-12-11 19:24 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09  8:37 [Buildroot] [PATCH] usbip: add a new package Tal Shorer
2016-12-10 13:31 ` Thomas Petazzoni
2016-12-10 18:39   ` Tal Shorer
2016-12-11 10:06     ` Yann E. MORIN
2016-12-11 13:56 ` Yann E. MORIN
2016-12-11 17:39   ` Tal Shorer
2016-12-11 17:45     ` Yann E. MORIN
2016-12-11 18:12       ` [Buildroot] [PATCH] pkg-generic: run $(PKG)_PRE_RSYNC_HOOKS before checking for the existence of $(SRCDIR) Tal Shorer
2016-12-11 19:19         ` Yann E. MORIN
2016-12-11 19:44         ` [Buildroot] [PATCH] package/usbip: new package Tal Shorer
2016-12-17 15:00         ` [Buildroot] [PATCH] pkg-generic: run $(PKG)_PRE_RSYNC_HOOKS before checking for the existence of $(SRCDIR) Thomas Petazzoni
2016-12-11 18:31       ` [Buildroot] [PATCH] usbip: add a new package Tal Shorer
2016-12-11 19:24         ` Yann E. MORIN [this message]
2016-12-11 19:59     ` Arnout Vandecappelle
2016-12-11 21:40       ` Yann E. MORIN
2016-12-11 21:46       ` Tal Shorer
2016-12-11 22:05         ` Yann E. MORIN
2016-12-11 22:11           ` Tal Shorer
2016-12-11 22:20             ` Yann E. MORIN
2016-12-11 22:30               ` Tal Shorer
2016-12-12  9:40                 ` Arnout Vandecappelle
2016-12-12 17:25                   ` Yann E. MORIN
2016-12-12 22:17                     ` Tal Shorer
2016-12-12 22:21                       ` [Buildroot] [PATCH v3] usbip: " Tal Shorer
2016-12-13 17:53                         ` Yann E. MORIN
2016-12-14 17:28                           ` [Buildroot] [PATCH v4] " Tal Shorer
2016-12-21 22:17                             ` Tal Shorer
2016-12-22 20:45                             ` Yann E. MORIN
2016-12-23 18:24                             ` Yann E. MORIN
2016-12-23 19:10                               ` Yann E. MORIN
2016-12-13 17:35                       ` [Buildroot] [PATCH] usbip: add a " Yann E. MORIN
2016-12-12 17:09                 ` [Buildroot] [PATCH v2 1/2] package: linux-tools: allow tools to define configure hooks Tal Shorer
2016-12-12 17:09                   ` [Buildroot] [PATCH v2 2/2] package: linux-tools: add usbip Tal Shorer
2016-12-12 17:26                     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161211192456.GF3599@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.