* [PATCH 0/2] i2c: sh_mobile: fallback enhancements @ 2016-12-07 10:31 ` Simon Horman 0 siblings, 0 replies; 7+ messages in thread From: Simon Horman @ 2016-12-07 10:31 UTC (permalink / raw) To: Wolfram Sang Cc: Magnus Damm, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Simon Horman Hi, this short series aims to improve the fallback compatibility strings for the i2c-sh_mobile driver. Simon Horman (2): i2c: sh_mobile: List rmobile fallback compatibility last i2c: sh_mobile: Add per-Generation fallback bindings Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 17 ++++++++++++++--- drivers/i2c/busses/i2c-sh_mobile.c | 4 +++- 2 files changed, 17 insertions(+), 4 deletions(-) -- 2.7.0.rc3.207.g0ac5344 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 0/2] i2c: sh_mobile: fallback enhancements @ 2016-12-07 10:31 ` Simon Horman 0 siblings, 0 replies; 7+ messages in thread From: Simon Horman @ 2016-12-07 10:31 UTC (permalink / raw) To: Wolfram Sang Cc: Magnus Damm, linux-i2c, linux-renesas-soc, devicetree, Simon Horman Hi, this short series aims to improve the fallback compatibility strings for the i2c-sh_mobile driver. Simon Horman (2): i2c: sh_mobile: List rmobile fallback compatibility last i2c: sh_mobile: Add per-Generation fallback bindings Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 17 ++++++++++++++--- drivers/i2c/busses/i2c-sh_mobile.c | 4 +++- 2 files changed, 17 insertions(+), 4 deletions(-) -- 2.7.0.rc3.207.g0ac5344 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] i2c: sh_mobile: List rmobile fallback compatibility last 2016-12-07 10:31 ` Simon Horman (?) @ 2016-12-07 10:39 ` Simon Horman 2016-12-07 12:16 ` Geert Uytterhoeven -1 siblings, 1 reply; 7+ messages in thread From: Simon Horman @ 2016-12-07 10:39 UTC (permalink / raw) To: Wolfram Sang Cc: Magnus Damm, linux-i2c, linux-renesas-soc, devicetree, Simon Horman Improve readability by listing the rmobile fallback compatibility string after the more-specific compatibility strings they provide a fallback for. This does not effect run-time behaviour as it is the order in the DTB that determines which compatibility string is used. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- drivers/i2c/busses/i2c-sh_mobile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c index 192f36f00e4d..6335ad35902d 100644 --- a/drivers/i2c/busses/i2c-sh_mobile.c +++ b/drivers/i2c/busses/i2c-sh_mobile.c @@ -827,7 +827,6 @@ static const struct sh_mobile_dt_config r8a7740_dt_config = { }; static const struct of_device_id sh_mobile_i2c_dt_ids[] = { - { .compatible = "renesas,rmobile-iic", .data = &default_dt_config }, { .compatible = "renesas,iic-r8a73a4", .data = &fast_clock_dt_config }, { .compatible = "renesas,iic-r8a7740", .data = &r8a7740_dt_config }, { .compatible = "renesas,iic-r8a7790", .data = &fast_clock_dt_config }, @@ -837,6 +836,7 @@ static const struct of_device_id sh_mobile_i2c_dt_ids[] = { { .compatible = "renesas,iic-r8a7794", .data = &fast_clock_dt_config }, { .compatible = "renesas,iic-r8a7795", .data = &fast_clock_dt_config }, { .compatible = "renesas,iic-sh73a0", .data = &fast_clock_dt_config }, + { .compatible = "renesas,rmobile-iic", .data = &default_dt_config }, {}, }; MODULE_DEVICE_TABLE(of, sh_mobile_i2c_dt_ids); -- 2.7.0.rc3.207.g0ac5344 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] i2c: sh_mobile: List rmobile fallback compatibility last 2016-12-07 10:39 ` [PATCH 1/2] i2c: sh_mobile: List rmobile fallback compatibility last Simon Horman @ 2016-12-07 12:16 ` Geert Uytterhoeven 0 siblings, 0 replies; 7+ messages in thread From: Geert Uytterhoeven @ 2016-12-07 12:16 UTC (permalink / raw) To: Simon Horman Cc: Wolfram Sang, Magnus Damm, Linux I2C, Linux-Renesas, devicetree@vger.kernel.org On Wed, Dec 7, 2016 at 11:39 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Improve readability by listing the rmobile fallback compatibility string > after the more-specific compatibility strings they provide a fallback for. > > This does not effect run-time behaviour as it is the order in the DTB that > determines which compatibility string is used. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] i2c: sh_mobile: Add per-Generation fallback bindings 2016-12-07 10:31 ` Simon Horman (?) (?) @ 2016-12-07 10:39 ` Simon Horman 2016-12-07 12:19 ` Geert Uytterhoeven 2016-12-11 21:53 ` Wolfram Sang -1 siblings, 2 replies; 7+ messages in thread From: Simon Horman @ 2016-12-07 10:39 UTC (permalink / raw) To: Wolfram Sang Cc: Magnus Damm, linux-i2c, linux-renesas-soc, devicetree, Simon Horman Add per-Generation fallback bindings for R-Car SoCs. This is in keeping with the compatibility string scheme is being adopted for drivers for Renesas SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 17 ++++++++++++++--- drivers/i2c/busses/i2c-sh_mobile.c | 2 ++ 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt index 214f94c25d37..7716acc55dec 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt @@ -1,8 +1,7 @@ Device tree configuration for Renesas IIC (sh_mobile) driver Required properties: -- compatible : "renesas,iic-<soctype>". "renesas,rmobile-iic" as fallback - Examples with soctypes are: +- compatible : - "renesas,iic-r8a73a4" (R-Mobile APE6) - "renesas,iic-r8a7740" (R-Mobile A1) - "renesas,iic-r8a7790" (R-Car H2) @@ -12,6 +11,17 @@ Required properties: - "renesas,iic-r8a7794" (R-Car E2) - "renesas,iic-r8a7795" (R-Car H3) - "renesas,iic-sh73a0" (SH-Mobile AG5) + - "renesas,rcar-gen2-iic" (generic R-Car Gen2 compatible device) + - "renesas,rcar-gen3-iic" (generic R-Car Gen3 compatible device) + - "renesas,rmobile-iic" (generic device) + + When compatible with a generic R-Car version, nodes + must list the SoC-specific version corresponding to + the platform first followed by the generic R-Car + version. + + renesas,rmobile-iic must always follow. + - reg : address start and address range size of device - interrupts : interrupt of device - clocks : clock for device @@ -31,7 +41,8 @@ Pinctrl properties might be needed, too. See there. Example: iic0: i2c@e6500000 { - compatible = "renesas,iic-r8a7790", "renesas,rmobile-iic"; + compatible = "renesas,iic-r8a7790", "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; reg = <0 0xe6500000 0 0x425>; interrupts = <0 174 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp3_clks R8A7790_CLK_IIC0>; diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c index 6335ad35902d..3d9ebe6e5716 100644 --- a/drivers/i2c/busses/i2c-sh_mobile.c +++ b/drivers/i2c/busses/i2c-sh_mobile.c @@ -834,7 +834,9 @@ static const struct of_device_id sh_mobile_i2c_dt_ids[] = { { .compatible = "renesas,iic-r8a7792", .data = &fast_clock_dt_config }, { .compatible = "renesas,iic-r8a7793", .data = &fast_clock_dt_config }, { .compatible = "renesas,iic-r8a7794", .data = &fast_clock_dt_config }, + { .compatible = "renesas,rcar-gen2-iic", .data = &fast_clock_dt_config }, { .compatible = "renesas,iic-r8a7795", .data = &fast_clock_dt_config }, + { .compatible = "renesas,rcar-gen3-iic", .data = &fast_clock_dt_config }, { .compatible = "renesas,iic-sh73a0", .data = &fast_clock_dt_config }, { .compatible = "renesas,rmobile-iic", .data = &default_dt_config }, {}, -- 2.7.0.rc3.207.g0ac5344 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] i2c: sh_mobile: Add per-Generation fallback bindings 2016-12-07 10:39 ` [PATCH 2/2] i2c: sh_mobile: Add per-Generation fallback bindings Simon Horman @ 2016-12-07 12:19 ` Geert Uytterhoeven 2016-12-11 21:53 ` Wolfram Sang 1 sibling, 0 replies; 7+ messages in thread From: Geert Uytterhoeven @ 2016-12-07 12:19 UTC (permalink / raw) To: Simon Horman Cc: Wolfram Sang, Magnus Damm, Linux I2C, Linux-Renesas, devicetree@vger.kernel.org On Wed, Dec 7, 2016 at 11:39 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Add per-Generation fallback bindings for R-Car SoCs. > > This is in keeping with the compatibility string scheme is being adopted > for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] i2c: sh_mobile: Add per-Generation fallback bindings 2016-12-07 10:39 ` [PATCH 2/2] i2c: sh_mobile: Add per-Generation fallback bindings Simon Horman 2016-12-07 12:19 ` Geert Uytterhoeven @ 2016-12-11 21:53 ` Wolfram Sang 1 sibling, 0 replies; 7+ messages in thread From: Wolfram Sang @ 2016-12-11 21:53 UTC (permalink / raw) To: Simon Horman Cc: Wolfram Sang, Magnus Damm, linux-i2c, linux-renesas-soc, devicetree [-- Attachment #1: Type: text/plain, Size: 390 bytes --] On Wed, Dec 07, 2016 at 11:39:53AM +0100, Simon Horman wrote: > Add per-Generation fallback bindings for R-Car SoCs. > > This is in keeping with the compatibility string scheme is being adopted > for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> I took the liberty to merge patch 1/2 into this one. Then, applied to for-next, thanks! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-12-11 21:53 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-12-07 10:31 [PATCH 0/2] i2c: sh_mobile: fallback enhancements Simon Horman 2016-12-07 10:31 ` Simon Horman 2016-12-07 10:39 ` [PATCH 1/2] i2c: sh_mobile: List rmobile fallback compatibility last Simon Horman 2016-12-07 12:16 ` Geert Uytterhoeven 2016-12-07 10:39 ` [PATCH 2/2] i2c: sh_mobile: Add per-Generation fallback bindings Simon Horman 2016-12-07 12:19 ` Geert Uytterhoeven 2016-12-11 21:53 ` Wolfram Sang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.