From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ray Jui <rjui@broadcom.com>, Lee Jones <lee@kernel.org>,
Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: bcm: Fix 'maybe-uninitialized' warning in bcm2835_clock_choose_div_and_prate()
Date: Mon, 12 Dec 2016 09:31:30 +0100 [thread overview]
Message-ID: <20161212093130.6e348a61@bbrezillon> (raw)
In-Reply-To: <3107859.uaKLk6DMRd@wuerfel>
On Mon, 12 Dec 2016 09:12:36 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday, December 12, 2016 9:00:53 AM CET Boris Brezillon wrote:
> > best_rate is reported as potentially uninitialized by gcc.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> I wonder why I didn't get that. Which compiler version did you use?
>
In case you're interested, my gcc [1] failed to detect it as well, and
this is not the first time it happens :-/.
[1]gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: bcm: Fix 'maybe-uninitialized' warning in bcm2835_clock_choose_div_and_prate()
Date: Mon, 12 Dec 2016 09:31:30 +0100 [thread overview]
Message-ID: <20161212093130.6e348a61@bbrezillon> (raw)
In-Reply-To: <3107859.uaKLk6DMRd@wuerfel>
On Mon, 12 Dec 2016 09:12:36 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday, December 12, 2016 9:00:53 AM CET Boris Brezillon wrote:
> > best_rate is reported as potentially uninitialized by gcc.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> I wonder why I didn't get that. Which compiler version did you use?
>
In case you're interested, my gcc [1] failed to detect it as well, and
this is not the first time it happens :-/.
[1]gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
next prev parent reply other threads:[~2016-12-12 8:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 8:00 [PATCH] clk: bcm: Fix 'maybe-uninitialized' warning in bcm2835_clock_choose_div_and_prate() Boris Brezillon
2016-12-12 8:00 ` Boris Brezillon
2016-12-12 8:12 ` Arnd Bergmann
2016-12-12 8:12 ` Arnd Bergmann
2016-12-12 8:22 ` Stephen Rothwell
2016-12-12 8:22 ` Stephen Rothwell
2016-12-12 8:31 ` Boris Brezillon [this message]
2016-12-12 8:31 ` Boris Brezillon
2016-12-12 8:34 ` Arnd Bergmann
2016-12-12 8:34 ` Arnd Bergmann
2016-12-12 9:03 ` Boris Brezillon
2016-12-12 9:03 ` Boris Brezillon
2016-12-12 17:24 ` Eric Anholt
2016-12-12 17:24 ` Eric Anholt
2016-12-12 19:26 ` Stephen Boyd
2016-12-12 19:26 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212093130.6e348a61@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=rjui@broadcom.com \
--cc=sboyd@codeaurora.org \
--cc=sbranden@broadcom.com \
--cc=sfr@canb.auug.org.au \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.