[PATCH] edgerouter.conf: enable generation of wic.bmap

[PATCH] edgerouter.conf: enable generation of wic.bmap

[Ed Bartosh]

Enabled generation of block map(bmap) files for wic images
built for edgerouter machine. This should simplify flashing
images with bmaptool.

[YOCTO #10621]

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 meta-yocto-bsp/conf/machine/edgerouter.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-yocto-bsp/conf/machine/edgerouter.conf b/meta-yocto-bsp/conf/machine/edgerouter.conf
index 720a947..c6193d9 100644
--- a/meta-yocto-bsp/conf/machine/edgerouter.conf
+++ b/meta-yocto-bsp/conf/machine/edgerouter.conf
@@ -18,7 +18,7 @@ USE_VT ?= "0"
 
 MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
 
-IMAGE_FSTYPES ?= "jffs2 tar.bz2 wic"
+IMAGE_FSTYPES ?= "jffs2 tar.bz2 wic wic.bmap"
 JFFS2_ERASEBLOCK = "0x10000"
 
 WKS_FILE ?= "sdimage-bootpart.wks"
-- 
2.1.4

Re: [PATCH] edgerouter.conf: enable generation of wic.bmap

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Fri, Dec 9, 2016 at 10:46 AM, Ed Bartosh <ed.bartosh@linux.intel.com>
wrote:

> Enabled generation of block map(bmap) files for wic images
> built for edgerouter machine. This should simplify flashing
> images with bmaptool.
>
> [YOCTO #10621]
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
>

I think this is more of a distro decision than machine, whether they want
to support use of bmaptool for their users/customers. It’d be nice if it
was easier to control compression from the distro, too. For example, if we
want to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be
able to switch to that for all machines that use wic. I’m not sure how best
to pull that off, however. Something to think about for the future.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1424 bytes --]

Re: [PATCH] edgerouter.conf: enable generation of wic.bmap

[Khem Raj]

On Sat, Dec 10, 2016 at 10:40 AM, Christopher Larson
<clarson@kergoth.com> wrote:
>
> On Fri, Dec 9, 2016 at 10:46 AM, Ed Bartosh <ed.bartosh@linux.intel.com>
> wrote:
>>
>> Enabled generation of block map(bmap) files for wic images
>> built for edgerouter machine. This should simplify flashing
>> images with bmaptool.
>>
>> [YOCTO #10621]
>>
>> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
>
>
> I think this is more of a distro decision than machine, whether they want to
> support use of bmaptool for their users/customers. It’d be nice if it was
> easier to control compression from the distro, too. For example, if we want
> to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be able to
> switch to that for all machines that use wic. I’m not sure how best to pull
> that off, however. Something to think about for the future.

I think thats a good point, however, distro should be able to define
something like
if machine is capable of supporting feature X then lets enable it. I
dont think we
should add machine knowledge into distros either.

> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Re: [PATCH] edgerouter.conf: enable generation of wic.bmap

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]

On Sat, Dec 10, 2016 at 1:57 PM, Khem Raj <raj.khem@gmail.com> wrote:

> On Sat, Dec 10, 2016 at 10:40 AM, Christopher Larson
> <clarson@kergoth.com> wrote:
> >
> > On Fri, Dec 9, 2016 at 10:46 AM, Ed Bartosh <ed.bartosh@linux.intel.com>
> > wrote:
> >>
> >> Enabled generation of block map(bmap) files for wic images
> >> built for edgerouter machine. This should simplify flashing
> >> images with bmaptool.
> >>
> >> [YOCTO #10621]
> >>
> >> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> >
> >
> > I think this is more of a distro decision than machine, whether they
> want to
> > support use of bmaptool for their users/customers. It’d be nice if it was
> > easier to control compression from the distro, too. For example, if we
> want
> > to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be
> able to
> > switch to that for all machines that use wic. I’m not sure how best to
> pull
> > that off, however. Something to think about for the future.
>
> I think thats a good point, however, distro should be able to define
> something like
> if machine is capable of supporting feature X then lets enable it. I
> dont think we
> should add machine knowledge into distros either.


Agreed. We do that already with features variables, but there’s no
equivalent for IMAGE_FSTYPES, of course. Presumably IMAGE_FSTYPES_append =
“ ${@‘wic.bmap’ if ‘${USING_WIC}’ else ‘’}” or so would get part of the way
there. Replacing wic with wic.bz2 or vice versa would be slightly more
complex.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2372 bytes --]

Re: [PATCH] edgerouter.conf: enable generation of wic.bmap

[Ed Bartosh]

On Sat, Dec 10, 2016 at 11:40:38AM -0700, Christopher Larson wrote:
> On Fri, Dec 9, 2016 at 10:46 AM, Ed Bartosh <ed.bartosh@linux.intel.com>
> wrote:
> 
> > Enabled generation of block map(bmap) files for wic images
> > built for edgerouter machine. This should simplify flashing
> > images with bmaptool.
> >
> > [YOCTO #10621]
> >
> > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> >
> 
> I think this is more of a distro decision than machine, whether they want
> to support use of bmaptool for their users/customers. It’d be nice if it
> was easier to control compression from the distro, too. For example, if we
> want to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be
> able to switch to that for all machines that use wic. I’m not sure how best
> to pull that off, however. Something to think about for the future.

Thanks for pointing out to it. I did it this way for two reasons:
- IMAGE_FSTYPES was already modified in edgerouter.conf
- I wanted to enable generation of wic.bmap for subset of machines, i.e.
  only for hardware reference BSPs mentioned in README.hardware

If there is a better to do it I'd be happy to update my patch.

--
Regards,
Ed

Re: [PATCH] edgerouter.conf: enable generation of wic.bmap

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]

On Mon, Dec 12, 2016 at 3:58 AM, Ed Bartosh <ed.bartosh@linux.intel.com>
wrote:

> On Sat, Dec 10, 2016 at 11:40:38AM -0700, Christopher Larson wrote:
> > On Fri, Dec 9, 2016 at 10:46 AM, Ed Bartosh <ed.bartosh@linux.intel.com>
> > wrote:
> >
> > > Enabled generation of block map(bmap) files for wic images
> > > built for edgerouter machine. This should simplify flashing
> > > images with bmaptool.
> > >
> > > [YOCTO #10621]
> > >
> > > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > >
> >
> > I think this is more of a distro decision than machine, whether they want
> > to support use of bmaptool for their users/customers. It’d be nice if it
> > was easier to control compression from the distro, too. For example, if
> we
> > want to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be
> > able to switch to that for all machines that use wic. I’m not sure how
> best
> > to pull that off, however. Something to think about for the future.
>
> Thanks for pointing out to it. I did it this way for two reasons:
> - IMAGE_FSTYPES was already modified in edgerouter.conf
> - I wanted to enable generation of wic.bmap for subset of machines, i.e.
>   only for hardware reference BSPs mentioned in README.hardware
>

That’s a fair point. As khem indicated, this is a bit of an intersection
between distro and machine, hardware capabilities and distro policy. I
expect this is fine as is, but something to consider improving going
forward. I’m not certain a distro/machine feature makes sense for something
like this, but perhaps something else might.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2426 bytes --]