From: Wolfram Sang <wsa@the-dreams.de>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] i2c: designware: add reset interface
Date: Tue, 13 Dec 2016 21:34:57 +0100 [thread overview]
Message-ID: <20161213203457.GB2889@katana> (raw)
In-Reply-To: <1479789700-19532-1-git-send-email-zhangfei.gao@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]
On Tue, Nov 22, 2016 at 12:41:40PM +0800, Zhangfei Gao wrote:
> Some platforms like hi3660 need do reset first to allow accessing registers
>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Adding designware maintainers to CC...
> ---
> drivers/i2c/busses/i2c-designware-core.h | 1 +
> drivers/i2c/busses/i2c-designware-platdrv.c | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h
> index 0d44d2a..94b14fa 100644
> --- a/drivers/i2c/busses/i2c-designware-core.h
> +++ b/drivers/i2c/busses/i2c-designware-core.h
> @@ -80,6 +80,7 @@ struct dw_i2c_dev {
> void __iomem *base;
> struct completion cmd_complete;
> struct clk *clk;
> + struct reset_control *rst;
> u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev);
> struct dw_pci_controller *controller;
> int cmd_err;
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 0b42a12..fd80e58 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -38,6 +38,7 @@
> #include <linux/pm_runtime.h>
> #include <linux/property.h>
> #include <linux/io.h>
> +#include <linux/reset.h>
> #include <linux/slab.h>
> #include <linux/acpi.h>
> #include <linux/platform_data/i2c-designware.h>
> @@ -176,6 +177,10 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
> dev->irq = irq;
> platform_set_drvdata(pdev, dev);
>
> + dev->rst = devm_reset_control_get(&pdev->dev, NULL);
> + if (!IS_ERR(dev->rst))
> + reset_control_reset(dev->rst);
> +
> /* fast mode by default because of legacy reasons */
> dev->clk_freq = 400000;
>
> --
> 2.7.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: designware: add reset interface
Date: Tue, 13 Dec 2016 21:34:57 +0100 [thread overview]
Message-ID: <20161213203457.GB2889@katana> (raw)
In-Reply-To: <1479789700-19532-1-git-send-email-zhangfei.gao@linaro.org>
On Tue, Nov 22, 2016 at 12:41:40PM +0800, Zhangfei Gao wrote:
> Some platforms like hi3660 need do reset first to allow accessing registers
>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Adding designware maintainers to CC...
> ---
> drivers/i2c/busses/i2c-designware-core.h | 1 +
> drivers/i2c/busses/i2c-designware-platdrv.c | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h
> index 0d44d2a..94b14fa 100644
> --- a/drivers/i2c/busses/i2c-designware-core.h
> +++ b/drivers/i2c/busses/i2c-designware-core.h
> @@ -80,6 +80,7 @@ struct dw_i2c_dev {
> void __iomem *base;
> struct completion cmd_complete;
> struct clk *clk;
> + struct reset_control *rst;
> u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev);
> struct dw_pci_controller *controller;
> int cmd_err;
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 0b42a12..fd80e58 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -38,6 +38,7 @@
> #include <linux/pm_runtime.h>
> #include <linux/property.h>
> #include <linux/io.h>
> +#include <linux/reset.h>
> #include <linux/slab.h>
> #include <linux/acpi.h>
> #include <linux/platform_data/i2c-designware.h>
> @@ -176,6 +177,10 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
> dev->irq = irq;
> platform_set_drvdata(pdev, dev);
>
> + dev->rst = devm_reset_control_get(&pdev->dev, NULL);
> + if (!IS_ERR(dev->rst))
> + reset_control_reset(dev->rst);
> +
> /* fast mode by default because of legacy reasons */
> dev->clk_freq = 400000;
>
> --
> 2.7.4
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161213/c10a0a77/attachment.sig>
next prev parent reply other threads:[~2016-12-13 20:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 4:41 [PATCH] i2c: designware: add reset interface Zhangfei Gao
2016-11-22 4:41 ` Zhangfei Gao
2016-12-13 20:34 ` Wolfram Sang [this message]
2016-12-13 20:34 ` Wolfram Sang
2016-12-14 19:00 ` Andy Shevchenko
2016-12-14 19:00 ` Andy Shevchenko
2016-12-15 8:56 ` zhangfei
2016-12-15 8:56 ` zhangfei
2016-12-15 8:59 ` [PATCH v2] " Zhangfei Gao
2016-12-15 8:59 ` Zhangfei Gao
2016-12-15 12:33 ` Andy Shevchenko
2016-12-15 12:33 ` Andy Shevchenko
2016-12-15 14:11 ` Phil Reid
2016-12-15 14:11 ` Phil Reid
2016-12-15 15:40 ` Jarkko Nikula
2016-12-15 15:40 ` Jarkko Nikula
2016-12-15 15:30 ` Ramiro Oliveira
2016-12-15 15:30 ` Ramiro Oliveira
2016-12-16 2:45 ` zhangfei
2016-12-16 2:45 ` zhangfei
2016-12-16 3:01 ` zhangfei
2016-12-16 3:01 ` zhangfei
2016-12-23 10:26 ` Philipp Zabel
2016-12-23 10:26 ` Philipp Zabel
2016-12-23 13:39 ` zhangfei
2016-12-23 13:39 ` zhangfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213203457.GB2889@katana \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.