From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs
Date: Wed, 14 Dec 2016 13:46:22 -0800 [thread overview]
Message-ID: <20161214214622.GC4920@atomide.com> (raw)
In-Reply-To: <20161214212556.GC28424@amd>
* Pavel Machek <pavel@ucw.cz> [161214 13:26]:
> On Wed 2016-12-14 22:12:43, Pali Roh?r wrote:
> > Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") broke
> > support for setting cmdline on Nokia N900 via CONFIG_CMDLINE.
> >
> > It is because arm code booted in DT mode parse cmdline only via function
> > early_init_dt_scan_chosen() and that function does not fill variable
> > boot_command_line when DTB does not contain /chosen entry. It is called
> > from function early_init_dt_scan_nodes() in setup_machine_fdt().
> >
> > This patch fixes it by explicitly filling boot_command_line in function
> > setup_machine_fdt() after calling early_init_dt_scan_nodes() in case
> > boot_command_line still remains empty.
> >
> > Signed-off-by: Pali Roh?r <pali.rohar@gmail.com>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Arnd Bergmann" <arnd@arndb.de>,
"Robin Murphy" <robin.murphy@arm.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Ben Dooks" <ben-linux@fluff.org>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs
Date: Wed, 14 Dec 2016 13:46:22 -0800 [thread overview]
Message-ID: <20161214214622.GC4920@atomide.com> (raw)
In-Reply-To: <20161214212556.GC28424@amd>
* Pavel Machek <pavel@ucw.cz> [161214 13:26]:
> On Wed 2016-12-14 22:12:43, Pali Rohár wrote:
> > Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") broke
> > support for setting cmdline on Nokia N900 via CONFIG_CMDLINE.
> >
> > It is because arm code booted in DT mode parse cmdline only via function
> > early_init_dt_scan_chosen() and that function does not fill variable
> > boot_command_line when DTB does not contain /chosen entry. It is called
> > from function early_init_dt_scan_nodes() in setup_machine_fdt().
> >
> > This patch fixes it by explicitly filling boot_command_line in function
> > setup_machine_fdt() after calling early_init_dt_scan_nodes() in case
> > boot_command_line still remains empty.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2016-12-14 21:46 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 21:12 [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Pali Rohár
2016-12-14 21:12 ` Pali Rohár
2016-12-14 21:25 ` Pavel Machek
2016-12-14 21:25 ` Pavel Machek
2016-12-14 21:46 ` Tony Lindgren [this message]
2016-12-14 21:46 ` Tony Lindgren
2016-12-14 22:22 ` Javier Martinez Canillas
2016-12-14 22:22 ` Javier Martinez Canillas
2016-12-14 23:52 ` Russell King - ARM Linux
2016-12-14 23:52 ` Russell King - ARM Linux
2016-12-15 0:09 ` Pali Rohár
2016-12-15 0:09 ` Pali Rohár
2016-12-15 0:18 ` Robin Murphy
2016-12-15 0:18 ` Robin Murphy
2016-12-15 10:09 ` Russell King - ARM Linux
2016-12-15 10:09 ` Russell King - ARM Linux
2016-12-16 11:42 ` Pali Rohár
2016-12-16 11:42 ` Pali Rohár
2016-12-25 22:08 ` Pali Rohár
2016-12-25 22:08 ` Pali Rohár
2017-01-02 13:54 ` Russell King - ARM Linux
2017-01-02 13:54 ` Russell King - ARM Linux
2016-12-16 11:46 ` Pali Rohár
2016-12-16 11:46 ` Pali Rohár
2016-12-16 12:13 ` Javier Martinez Canillas
2016-12-16 12:13 ` Javier Martinez Canillas
2016-12-16 12:32 ` Pali Rohár
2016-12-16 12:32 ` Pali Rohár
2016-12-16 12:38 ` Javier Martinez Canillas
2016-12-16 12:38 ` Javier Martinez Canillas
2016-12-16 12:48 ` Pali Rohár
2016-12-16 12:48 ` Pali Rohár
2016-12-16 12:53 ` Javier Martinez Canillas
2016-12-16 12:53 ` Javier Martinez Canillas
2016-12-16 15:40 ` Tony Lindgren
2016-12-16 15:40 ` Tony Lindgren
2016-12-16 16:13 ` Pali Rohár
2016-12-16 16:13 ` Pali Rohár
2016-12-16 16:21 ` Tony Lindgren
2016-12-16 16:21 ` Tony Lindgren
2016-12-16 16:27 ` Russell King - ARM Linux
2016-12-16 16:27 ` Russell King - ARM Linux
2016-12-16 16:57 ` Mark Rutland
2016-12-16 16:57 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214214622.GC4920@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.