All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: "Doug Anderson"
	<dianders-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"William wu" <wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Catalin Marinas" <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	"Will Deacon" <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	"Caesar Wang" <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"Shawn Lin" <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"Jianqun Xu" <jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"Elaine Zhang"
	<zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"David Wu" <david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399
Date: Wed, 14 Dec 2016 19:20:53 -0800	[thread overview]
Message-ID: <20161215032052.GA116728@google.com> (raw)
In-Reply-To: <5ce521da-119a-2de8-026c-5992fedfef43-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

On Thu, Dec 15, 2016 at 10:41:04AM +0800, Xing Zheng wrote:
> // Frank
> 
> Hi Doug,  Brain,
>     Thanks for the reply.
>     Sorry I forgot these patches have been sent earlier, and Frank
> have some explained and discussed with Heiko.
> Please see https://patchwork.kernel.org/patch/9255245/
>     Perhaps we can move to that patch tree to continue the discussion.
> 
>     I think Frank and William will help us to continue checking these.

I only briefly read that discussion, but AFAICT it doesn't actually
address all the comments/quetions we had here. For instance, the
power_off() vs. delayed-work race in your USB2 PHY driver (is that
intentional?). Also, the question of why PHY (auto?)suspend is relevant.

I'll check again tomorrow.

Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399
Date: Wed, 14 Dec 2016 19:20:53 -0800	[thread overview]
Message-ID: <20161215032052.GA116728@google.com> (raw)
In-Reply-To: <5ce521da-119a-2de8-026c-5992fedfef43@rock-chips.com>

On Thu, Dec 15, 2016 at 10:41:04AM +0800, Xing Zheng wrote:
> // Frank
> 
> Hi Doug,  Brain,
>     Thanks for the reply.
>     Sorry I forgot these patches have been sent earlier, and Frank
> have some explained and discussed with Heiko.
> Please see https://patchwork.kernel.org/patch/9255245/
>     Perhaps we can move to that patch tree to continue the discussion.
> 
>     I think Frank and William will help us to continue checking these.

I only briefly read that discussion, but AFAICT it doesn't actually
address all the comments/quetions we had here. For instance, the
power_off() vs. delayed-work race in your USB2 PHY driver (is that
intentional?). Also, the question of why PHY (auto?)suspend is relevant.

I'll check again tomorrow.

Brian

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: "Doug Anderson" <dianders@google.com>,
	frank.wang@rock-chips.com,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	"William wu" <wulf@rock-chips.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"Caesar Wang" <wxt@rock-chips.com>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Jianqun Xu" <jay.xu@rock-chips.com>,
	"Elaine Zhang" <zhangqing@rock-chips.com>,
	"David Wu" <david.wu@rock-chips.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399
Date: Wed, 14 Dec 2016 19:20:53 -0800	[thread overview]
Message-ID: <20161215032052.GA116728@google.com> (raw)
In-Reply-To: <5ce521da-119a-2de8-026c-5992fedfef43@rock-chips.com>

On Thu, Dec 15, 2016 at 10:41:04AM +0800, Xing Zheng wrote:
> // Frank
> 
> Hi Doug,  Brain,
>     Thanks for the reply.
>     Sorry I forgot these patches have been sent earlier, and Frank
> have some explained and discussed with Heiko.
> Please see https://patchwork.kernel.org/patch/9255245/
>     Perhaps we can move to that patch tree to continue the discussion.
> 
>     I think Frank and William will help us to continue checking these.

I only briefly read that discussion, but AFAICT it doesn't actually
address all the comments/quetions we had here. For instance, the
power_off() vs. delayed-work race in your USB2 PHY driver (is that
intentional?). Also, the question of why PHY (auto?)suspend is relevant.

I'll check again tomorrow.

Brian

  parent reply	other threads:[~2016-12-15  3:20 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14 10:11 [PATCH 0/3] Add and export clk-480m clocks for ehci and ohci on RK3399 Xing Zheng
2016-12-14 10:11 ` Xing Zheng
2016-12-14 10:11 ` Xing Zheng
     [not found] ` <1481710301-1454-1-git-send-email-zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-12-14 10:11   ` [PATCH 1/3] clk: rockchip: rk3399: add USBPHYx_480M_SRC clock IDs Xing Zheng
2016-12-14 10:11     ` Xing Zheng
2016-12-15  0:27     ` Doug Anderson
2016-12-14 10:11 ` [PATCH 2/3] clk: rockchip: rk3399: export 480M_SRC clocks id for usbphy0/usbphy1 Xing Zheng
2016-12-14 10:11   ` Xing Zheng
2016-12-15  0:28   ` Doug Anderson
2016-12-15  0:28     ` Doug Anderson
2016-12-15  0:28     ` Doug Anderson
2016-12-14 10:11 ` [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399 Xing Zheng
2016-12-14 10:11   ` Xing Zheng
     [not found]   ` <1481710301-1454-4-git-send-email-zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-12-15  0:10     ` Doug Anderson
2016-12-15  0:10       ` Doug Anderson
2016-12-15  0:10       ` Doug Anderson
     [not found]       ` <CAD=FV=UU4JdRjRgEvc_wxprvi6bo46+jd=x2m2QzOe4uJmuRPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-15  0:47         ` Brian Norris
2016-12-15  0:47           ` Brian Norris
2016-12-15  0:47           ` Brian Norris
     [not found]           ` <20161215004737.GA32652-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-12-15  1:18             ` Brian Norris
2016-12-15  1:18               ` Brian Norris
2016-12-15  1:18               ` Brian Norris
2016-12-15  2:41         ` Xing Zheng
2016-12-15  2:41           ` Xing Zheng
2016-12-15  2:41           ` Xing Zheng
     [not found]           ` <5ce521da-119a-2de8-026c-5992fedfef43-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-12-15  3:20             ` Brian Norris [this message]
2016-12-15  3:20               ` Brian Norris
2016-12-15  3:20               ` Brian Norris
2016-12-15  6:41           ` Frank Wang
2016-12-15  6:41             ` Frank Wang
     [not found]             ` <991221a4-3962-1bcb-7863-72f5553eba40-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-12-15 16:34               ` Doug Anderson
2016-12-15 16:34                 ` Doug Anderson
2016-12-15 16:34                 ` Doug Anderson
     [not found]                 ` <CAD=FV=XKQaqRS4jUM7NpN2KEV8USj_cVWbh7q4274n3jBtwORg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-15 18:18                   ` Heiko Stuebner
2016-12-15 18:18                     ` Heiko Stuebner
2016-12-15 18:18                     ` Heiko Stuebner
2016-12-16  6:57                     ` Xing Zheng
     [not found]                       ` <5853903D.8030605-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-12-16 17:28                         ` Doug Anderson
2016-12-16 17:28                           ` Doug Anderson
2016-12-16 17:28                           ` Doug Anderson
     [not found]                           ` <CAD=FV=W1BW6FSZ6MSxR6RhvtZyGsdQbz9vU_QshaQ5A65ENMCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-21 10:44                             ` Xing Zheng
2016-12-21 10:44                               ` Xing Zheng
2016-12-21 10:44                               ` Xing Zheng
2016-12-17  1:20                         ` Heiko Stuebner
2016-12-17  1:20                           ` Heiko Stuebner
2016-12-17  1:20                           ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161215032052.GA116728@google.com \
    --to=briannorris-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
    --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dianders-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    --cc=wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.