* [PATCH] drm: Fix kernel docs for drm_helper_mode_fill_fb_struct()
@ 2016-12-15 17:01 ville.syrjala
2016-12-15 17:12 ` Deucher, Alexander
2016-12-15 17:52 ` Laurent Pinchart
0 siblings, 2 replies; 4+ messages in thread
From: ville.syrjala @ 2016-12-15 17:01 UTC (permalink / raw)
To: dri-devel; +Cc: Alex Deucher, Laurent Pinchart
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
drm_modeset_helper.c:74: warning: No description found for parameter 'dev'
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Fixes: a3f913ca9892 ("drm: Pass 'dev' to drm_helper_mode_fill_fb_struct()")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_modeset_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_modeset_helper.c b/drivers/gpu/drm/drm_modeset_helper.c
index f78df06a940d..4b31f5f70177 100644
--- a/drivers/gpu/drm/drm_modeset_helper.c
+++ b/drivers/gpu/drm/drm_modeset_helper.c
@@ -62,6 +62,7 @@ EXPORT_SYMBOL(drm_helper_move_panel_connectors_to_head);
/**
* drm_helper_mode_fill_fb_struct - fill out framebuffer metadata
+ * @dev: DRM device
* @fb: drm_framebuffer object to fill out
* @mode_cmd: metadata from the userspace fb creation request
*
--
2.10.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] drm: Fix kernel docs for drm_helper_mode_fill_fb_struct()
2016-12-15 17:01 [PATCH] drm: Fix kernel docs for drm_helper_mode_fill_fb_struct() ville.syrjala
@ 2016-12-15 17:12 ` Deucher, Alexander
2016-12-15 17:58 ` Ville Syrjälä
2016-12-15 17:52 ` Laurent Pinchart
1 sibling, 1 reply; 4+ messages in thread
From: Deucher, Alexander @ 2016-12-15 17:12 UTC (permalink / raw)
To: 'ville.syrjala@linux.intel.com',
dri-devel@lists.freedesktop.org
Cc: Laurent Pinchart
> -----Original Message-----
> From: ville.syrjala@linux.intel.com [mailto:ville.syrjala@linux.intel.com]
> Sent: Thursday, December 15, 2016 12:01 PM
> To: dri-devel@lists.freedesktop.org
> Cc: Laurent Pinchart; Deucher, Alexander
> Subject: [PATCH] drm: Fix kernel docs for drm_helper_mode_fill_fb_struct()
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drm_modeset_helper.c:74: warning: No description found for parameter
> 'dev'
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Fixes: a3f913ca9892 ("drm: Pass 'dev' to drm_helper_mode_fill_fb_struct()")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/drm_modeset_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_modeset_helper.c
> b/drivers/gpu/drm/drm_modeset_helper.c
> index f78df06a940d..4b31f5f70177 100644
> --- a/drivers/gpu/drm/drm_modeset_helper.c
> +++ b/drivers/gpu/drm/drm_modeset_helper.c
> @@ -62,6 +62,7 @@
> EXPORT_SYMBOL(drm_helper_move_panel_connectors_to_head);
>
> /**
> * drm_helper_mode_fill_fb_struct - fill out framebuffer metadata
> + * @dev: DRM device
> * @fb: drm_framebuffer object to fill out
> * @mode_cmd: metadata from the userspace fb creation request
> *
> --
> 2.10.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm: Fix kernel docs for drm_helper_mode_fill_fb_struct()
2016-12-15 17:12 ` Deucher, Alexander
@ 2016-12-15 17:58 ` Ville Syrjälä
0 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2016-12-15 17:58 UTC (permalink / raw)
To: Deucher, Alexander; +Cc: Laurent Pinchart, dri-devel@lists.freedesktop.org
On Thu, Dec 15, 2016 at 05:12:26PM +0000, Deucher, Alexander wrote:
> > -----Original Message-----
> > From: ville.syrjala@linux.intel.com [mailto:ville.syrjala@linux.intel.com]
> > Sent: Thursday, December 15, 2016 12:01 PM
> > To: dri-devel@lists.freedesktop.org
> > Cc: Laurent Pinchart; Deucher, Alexander
> > Subject: [PATCH] drm: Fix kernel docs for drm_helper_mode_fill_fb_struct()
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > drm_modeset_helper.c:74: warning: No description found for parameter
> > 'dev'
> >
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Fixes: a3f913ca9892 ("drm: Pass 'dev' to drm_helper_mode_fill_fb_struct()")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Pushed to drm-misc-next. Thanks for the reviews.
>
> > ---
> > drivers/gpu/drm/drm_modeset_helper.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/drm_modeset_helper.c
> > b/drivers/gpu/drm/drm_modeset_helper.c
> > index f78df06a940d..4b31f5f70177 100644
> > --- a/drivers/gpu/drm/drm_modeset_helper.c
> > +++ b/drivers/gpu/drm/drm_modeset_helper.c
> > @@ -62,6 +62,7 @@
> > EXPORT_SYMBOL(drm_helper_move_panel_connectors_to_head);
> >
> > /**
> > * drm_helper_mode_fill_fb_struct - fill out framebuffer metadata
> > + * @dev: DRM device
> > * @fb: drm_framebuffer object to fill out
> > * @mode_cmd: metadata from the userspace fb creation request
> > *
> > --
> > 2.10.2
>
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Fix kernel docs for drm_helper_mode_fill_fb_struct()
2016-12-15 17:01 [PATCH] drm: Fix kernel docs for drm_helper_mode_fill_fb_struct() ville.syrjala
2016-12-15 17:12 ` Deucher, Alexander
@ 2016-12-15 17:52 ` Laurent Pinchart
1 sibling, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2016-12-15 17:52 UTC (permalink / raw)
To: ville.syrjala; +Cc: Alex Deucher, dri-devel
Hi Ville,
Thank you for the patch.
On Thursday 15 Dec 2016 19:01:28 ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drm_modeset_helper.c:74: warning: No description found for parameter 'dev'
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Fixes: a3f913ca9892 ("drm: Pass 'dev' to drm_helper_mode_fill_fb_struct()")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/drm_modeset_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_modeset_helper.c
> b/drivers/gpu/drm/drm_modeset_helper.c index f78df06a940d..4b31f5f70177
> 100644
> --- a/drivers/gpu/drm/drm_modeset_helper.c
> +++ b/drivers/gpu/drm/drm_modeset_helper.c
> @@ -62,6 +62,7 @@ EXPORT_SYMBOL(drm_helper_move_panel_connectors_to_head);
>
> /**
> * drm_helper_mode_fill_fb_struct - fill out framebuffer metadata
> + * @dev: DRM device
> * @fb: drm_framebuffer object to fill out
> * @mode_cmd: metadata from the userspace fb creation request
> *
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-15 17:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-15 17:01 [PATCH] drm: Fix kernel docs for drm_helper_mode_fill_fb_struct() ville.syrjala
2016-12-15 17:12 ` Deucher, Alexander
2016-12-15 17:58 ` Ville Syrjälä
2016-12-15 17:52 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.