From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: M'boumba Cedric Madianga
<cedric.madianga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
alexandre.torgue-qxv4g6HH51o@public.gmane.org,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
patrice.chotard-qxv4g6HH51o@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver
Date: Thu, 15 Dec 2016 20:42:07 +0100 [thread overview]
Message-ID: <20161215194207.GB1741@katana> (raw)
In-Reply-To: <20161213092031.d2ax2pnpzzicriel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 290 bytes --]
> > + if (ret) {
> > + dev_err(i2c_dev->dev, "bus not free\n");
> > + ret = -EBUSY;
>
> I'm not sure if "bus not free" deserves an error message. Wolfram?
I tend to agree. But I never enforced it up to now, never found the time
to double check if I could/should enforce it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver
Date: Thu, 15 Dec 2016 20:42:07 +0100 [thread overview]
Message-ID: <20161215194207.GB1741@katana> (raw)
In-Reply-To: <20161213092031.d2ax2pnpzzicriel@pengutronix.de>
> > + if (ret) {
> > + dev_err(i2c_dev->dev, "bus not free\n");
> > + ret = -EBUSY;
>
> I'm not sure if "bus not free" deserves an error message. Wolfram?
I tend to agree. But I never enforced it up to now, never found the time
to double check if I could/should enforce it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161215/45e9de14/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "M'boumba Cedric Madianga" <cedric.madianga@gmail.com>,
robh+dt@kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, linus.walleij@linaro.org,
patrice.chotard@st.com, linux@armlinux.org.uk,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver
Date: Thu, 15 Dec 2016 20:42:07 +0100 [thread overview]
Message-ID: <20161215194207.GB1741@katana> (raw)
In-Reply-To: <20161213092031.d2ax2pnpzzicriel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 290 bytes --]
> > + if (ret) {
> > + dev_err(i2c_dev->dev, "bus not free\n");
> > + ret = -EBUSY;
>
> I'm not sure if "bus not free" deserves an error message. Wolfram?
I tend to agree. But I never enforced it up to now, never found the time
to double check if I could/should enforce it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-12-15 19:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 16:15 [PATCH v6 0/5] Add support for the STM32F4 I2C M'boumba Cedric Madianga
2016-12-12 16:15 ` M'boumba Cedric Madianga
2016-12-12 16:15 ` [PATCH v6 1/5] dt-bindings: Document the STM32 I2C bindings M'boumba Cedric Madianga
2016-12-12 16:15 ` M'boumba Cedric Madianga
2016-12-12 16:15 ` [PATCH v6 2/5] i2c: Add STM32F4 I2C driver M'boumba Cedric Madianga
2016-12-12 16:15 ` M'boumba Cedric Madianga
2016-12-13 9:20 ` Uwe Kleine-König
2016-12-13 9:20 ` Uwe Kleine-König
2016-12-15 15:26 ` M'boumba Cedric Madianga
2016-12-15 15:26 ` M'boumba Cedric Madianga
2016-12-15 15:26 ` M'boumba Cedric Madianga
2016-12-15 19:33 ` Uwe Kleine-König
2016-12-15 19:33 ` Uwe Kleine-König
2016-12-15 19:40 ` Wolfram Sang
2016-12-15 19:40 ` Wolfram Sang
2016-12-15 19:40 ` Wolfram Sang
[not found] ` <20161213092031.d2ax2pnpzzicriel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-12-15 19:42 ` Wolfram Sang [this message]
2016-12-15 19:42 ` Wolfram Sang
2016-12-15 19:42 ` Wolfram Sang
2016-12-12 16:15 ` [PATCH v6 3/5] ARM: dts: stm32: Add I2C1 support for STM32F429 SoC M'boumba Cedric Madianga
2016-12-12 16:15 ` M'boumba Cedric Madianga
[not found] ` <1481559342-6106-4-git-send-email-cedric.madianga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-13 10:01 ` Alexandre Torgue
2016-12-13 10:01 ` Alexandre Torgue
2016-12-13 10:01 ` Alexandre Torgue
2016-12-12 16:15 ` [PATCH v6 4/5] ARM: dts: stm32: Add I2C1 support for STM32429 eval board M'boumba Cedric Madianga
2016-12-12 16:15 ` M'boumba Cedric Madianga
2016-12-13 10:02 ` Alexandre Torgue
2016-12-13 10:02 ` Alexandre Torgue
2016-12-13 10:02 ` Alexandre Torgue
2016-12-12 16:15 ` [PATCH v6 5/5] ARM: configs: stm32: Add I2C support for STM32 defconfig M'boumba Cedric Madianga
2016-12-12 16:15 ` M'boumba Cedric Madianga
[not found] ` <1481559342-6106-6-git-send-email-cedric.madianga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-13 10:03 ` Alexandre Torgue
2016-12-13 10:03 ` Alexandre Torgue
2016-12-13 10:03 ` Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215194207.GB1741@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=alexandre.torgue-qxv4g6HH51o@public.gmane.org \
--cc=cedric.madianga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=patrice.chotard-qxv4g6HH51o@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.