All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Brown <broonie@kernel.org>,
	Romain Perier <romain.perier@free-electrons.com>
Cc: linux-spi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch 1/3] spi: armada-3700: Signedness bug in probe
Date: Fri, 16 Dec 2016 09:33:05 +0000	[thread overview]
Message-ID: <20161216082443.GA7031@elgon.mountain> (raw)

We need "irq" to be an int because platform_get_irq() returns negative
error codes.

Fixes: 5762ab71eb24 ("spi: Add support for Armada 3700 SPI Controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c
index e89da0af45d2..5c7508dc6f0b 100644
--- a/drivers/spi/spi-armada-3700.c
+++ b/drivers/spi/spi-armada-3700.c
@@ -108,7 +108,7 @@ struct a3700_spi {
 	struct spi_master *master;
 	void __iomem *base;
 	struct clk *clk;
-	unsigned int irq;
+	int irq;
 	unsigned int flags;
 	bool xmit_data;
 	const u8 *tx_buf;

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Brown <broonie@kernel.org>,
	Romain Perier <romain.perier@free-electrons.com>
Cc: linux-spi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch 1/3] spi: armada-3700: Signedness bug in probe
Date: Fri, 16 Dec 2016 12:33:05 +0300	[thread overview]
Message-ID: <20161216082443.GA7031@elgon.mountain> (raw)

We need "irq" to be an int because platform_get_irq() returns negative
error codes.

Fixes: 5762ab71eb24 ("spi: Add support for Armada 3700 SPI Controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c
index e89da0af45d2..5c7508dc6f0b 100644
--- a/drivers/spi/spi-armada-3700.c
+++ b/drivers/spi/spi-armada-3700.c
@@ -108,7 +108,7 @@ struct a3700_spi {
 	struct spi_master *master;
 	void __iomem *base;
 	struct clk *clk;
-	unsigned int irq;
+	int irq;
 	unsigned int flags;
 	bool xmit_data;
 	const u8 *tx_buf;

             reply	other threads:[~2016-12-16  9:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16  9:33 Dan Carpenter [this message]
2016-12-16  9:33 ` [patch 1/3] spi: armada-3700: Signedness bug in probe Dan Carpenter
     [not found] ` <20161216082443.GA7031-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2016-12-16  9:36   ` Romain Perier
2016-12-16  9:36     ` Romain Perier
2016-12-16  9:56     ` Dan Carpenter
2016-12-16  9:56       ` Dan Carpenter
2016-12-16 10:29       ` Romain Perier
2016-12-16 10:29         ` Romain Perier
     [not found]         ` <9e5f6a38-6177-4026-7930-150c6b281a99-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-12-16 10:34           ` Dan Carpenter
2016-12-16 10:34             ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161216082443.GA7031@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=broonie@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=romain.perier@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.