From: Willy Tarreau <w@1wt.eu>
To: Mike Manning <mmanning@brocade.com>
Cc: stable@vger.kernel.org, hannes@stressinduktion.org
Subject: Re: [PATCH 3.10] ipv6: move DAD and addrconf_verify processing to workqueue
Date: Fri, 16 Dec 2016 11:40:32 +0100 [thread overview]
Message-ID: <20161216104032.GA12172@1wt.eu> (raw)
In-Reply-To: <1481883372-26591-1-git-send-email-mmanning@brocade.com>
Hi Mike,
On Fri, Dec 16, 2016 at 10:16:12AM +0000, Mike Manning wrote:
> From: Hannes Frederic Sowa <hannes@stressinduktion.org>
>
> commit c15b1ccadb323ea50023e8f1cca2954129a62b51 upstream.
>
> addrconf_join_solict and addrconf_join_anycast may cause actions which
> need rtnl locked, especially on first address creation.
(...)
Thanks, I'm fine with merging these patches, but a quick check tells me
that at least the first one caused some issues that were later fixed,
for example :
From 43a43b6040165f7b40b5b489fe61a4cb7f8c4980 Mon Sep 17 00:00:00 2001
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Mon, 31 Mar 2014 20:14:10 +0200
Subject: [PATCH] ipv6: some ipv6 statistic counters failed to disable bh
After commit c15b1ccadb323ea ("ipv6: move DAD and addrconf_verify
processing to workqueue") some counters are now updated in process context
and thus need to disable bh before doing so, otherwise deadlocks can
happen on 32-bit archs. Fabio Estevam noticed this while while mounting
a NFS volume on an ARM board.
Can you please have a quick check to ensure that all necessary fixes
that come with these two patches are also identified ? I'll then queue
them all at once.
Thanks!
Willy
next prev parent reply other threads:[~2016-12-16 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 10:16 [PATCH 3.10] ipv6: move DAD and addrconf_verify processing to workqueue Mike Manning
2016-12-16 10:40 ` Willy Tarreau [this message]
2016-12-16 10:51 ` Mike Manning
2016-12-16 10:58 ` Willy Tarreau
2016-12-16 11:30 ` Mike Manning
2016-12-16 11:36 ` Willy Tarreau
2016-12-16 14:43 ` Mike Manning
2016-12-16 15:19 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216104032.GA12172@1wt.eu \
--to=w@1wt.eu \
--cc=hannes@stressinduktion.org \
--cc=mmanning@brocade.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.