* [PATCH v1 0/2] tools: Allow cross-compilation of xentop
@ 2016-12-15 12:36 Edgar E. Iglesias
2016-12-15 12:36 ` [PATCH v1 1/2] tools/xenstat: Remove redundant check for curses.h Edgar E. Iglesias
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Edgar E. Iglesias @ 2016-12-15 12:36 UTC (permalink / raw)
To: xen-devel
Cc: edgar.iglesias, wei.liu2, julien.grall, sstabellini, ian.jackson
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
We usually cross-compile the Xen tools for ARM in Yocto, including
support for xentop.
These patches remove two blockers in the Makefiles for cross-compiled
xentop.
Cheers,
Edgar
Edgar E. Iglesias (2):
tools/xenstat: Remove redundant check for curses.h
tools/xenstat: Don't disable xentop when cross-compiling
tools/xenstat/Makefile | 6 ------
1 file changed, 6 deletions(-)
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v1 1/2] tools/xenstat: Remove redundant check for curses.h
2016-12-15 12:36 [PATCH v1 0/2] tools: Allow cross-compilation of xentop Edgar E. Iglesias
@ 2016-12-15 12:36 ` Edgar E. Iglesias
2016-12-15 12:36 ` [PATCH v1 2/2] tools/xenstat: Don't disable xentop when cross-compiling Edgar E. Iglesias
2016-12-16 10:44 ` [PATCH v1 0/2] tools: Allow cross-compilation of xentop Wei Liu
2 siblings, 0 replies; 4+ messages in thread
From: Edgar E. Iglesias @ 2016-12-15 12:36 UTC (permalink / raw)
To: xen-devel
Cc: edgar.iglesias, wei.liu2, julien.grall, sstabellini, ian.jackson
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
This check for curses.h does not consider cross-compilation.
It only checks host paths.
Luckily, commit 65da4913214120ddc95bd846cb3649a29f87146a
introduced proper configure checks for ncurses so we can
remove the redundant check in the Makefile.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
tools/xenstat/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/xenstat/Makefile b/tools/xenstat/Makefile
index 901be4a..09ec1b7 100644
--- a/tools/xenstat/Makefile
+++ b/tools/xenstat/Makefile
@@ -6,10 +6,8 @@ SUBDIRS += libxenstat
# This doesn't cross-compile (cross-compile environments rarely have curses)
ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
-ifeq ($(wildcard /usr/include/curses.h),/usr/include/curses.h)
SUBDIRS += xentop
endif
-endif
.PHONY: all install clean distclean
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 2/2] tools/xenstat: Don't disable xentop when cross-compiling
2016-12-15 12:36 [PATCH v1 0/2] tools: Allow cross-compilation of xentop Edgar E. Iglesias
2016-12-15 12:36 ` [PATCH v1 1/2] tools/xenstat: Remove redundant check for curses.h Edgar E. Iglesias
@ 2016-12-15 12:36 ` Edgar E. Iglesias
2016-12-16 10:44 ` [PATCH v1 0/2] tools: Allow cross-compilation of xentop Wei Liu
2 siblings, 0 replies; 4+ messages in thread
From: Edgar E. Iglesias @ 2016-12-15 12:36 UTC (permalink / raw)
To: xen-devel
Cc: edgar.iglesias, wei.liu2, julien.grall, sstabellini, ian.jackson
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
This partially reverts 16504669c5cbb8b195d20412aadc838da5c428f7
since xentop cross-compiles fine.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
tools/xenstat/Makefile | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tools/xenstat/Makefile b/tools/xenstat/Makefile
index 09ec1b7..90d033a 100644
--- a/tools/xenstat/Makefile
+++ b/tools/xenstat/Makefile
@@ -3,11 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
SUBDIRS :=
SUBDIRS += libxenstat
-
-# This doesn't cross-compile (cross-compile environments rarely have curses)
-ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
SUBDIRS += xentop
-endif
.PHONY: all install clean distclean
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 0/2] tools: Allow cross-compilation of xentop
2016-12-15 12:36 [PATCH v1 0/2] tools: Allow cross-compilation of xentop Edgar E. Iglesias
2016-12-15 12:36 ` [PATCH v1 1/2] tools/xenstat: Remove redundant check for curses.h Edgar E. Iglesias
2016-12-15 12:36 ` [PATCH v1 2/2] tools/xenstat: Don't disable xentop when cross-compiling Edgar E. Iglesias
@ 2016-12-16 10:44 ` Wei Liu
2 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2016-12-16 10:44 UTC (permalink / raw)
To: Edgar E. Iglesias
Cc: edgar.iglesias, sstabellini, wei.liu2, ian.jackson, xen-devel,
julien.grall
On Thu, Dec 15, 2016 at 01:36:07PM +0100, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> We usually cross-compile the Xen tools for ARM in Yocto, including
> support for xentop.
>
> These patches remove two blockers in the Makefiles for cross-compiled
> xentop.
>
> Cheers,
> Edgar
>
> Edgar E. Iglesias (2):
> tools/xenstat: Remove redundant check for curses.h
> tools/xenstat: Don't disable xentop when cross-compiling
Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> tools/xenstat/Makefile | 6 ------
> 1 file changed, 6 deletions(-)
>
> --
> 2.7.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-16 10:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-15 12:36 [PATCH v1 0/2] tools: Allow cross-compilation of xentop Edgar E. Iglesias
2016-12-15 12:36 ` [PATCH v1 1/2] tools/xenstat: Remove redundant check for curses.h Edgar E. Iglesias
2016-12-15 12:36 ` [PATCH v1 2/2] tools/xenstat: Don't disable xentop when cross-compiling Edgar E. Iglesias
2016-12-16 10:44 ` [PATCH v1 0/2] tools: Allow cross-compilation of xentop Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.