* [PATCH] ARM: dts: exynos: Enable DMA support for UART modules on Exynos542x SoCs @ 2016-12-16 12:27 Marek Szyprowski 2016-12-16 12:39 ` [PATCH v2] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs Marek Szyprowski 0 siblings, 1 reply; 10+ messages in thread From: Marek Szyprowski @ 2016-12-16 12:27 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz UART modules can use DMA for offloading data transfers and reducing interrupts, so enable this feature for Exynos542x boards. Tested on Odroid XU3. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 906a1a4..99c9336 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -1406,21 +1406,29 @@ &serial_0 { clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 13>, <&pdma0 14>; + dma-names = "rx", "tx"; }; &serial_1 { clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 15>, <&pdma0 16>; + dma-names = "rx", "tx"; }; &serial_2 { clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 15>, <&pdma0 16>; + dma-names = "rx", "tx"; }; &serial_3 { clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 17>, <&pdma0 18>; + dma-names = "rx", "tx"; }; &sss { -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs 2016-12-16 12:27 [PATCH] ARM: dts: exynos: Enable DMA support for UART modules on Exynos542x SoCs Marek Szyprowski @ 2016-12-16 12:39 ` Marek Szyprowski 2016-12-16 16:50 ` Krzysztof Kozlowski 2016-12-19 10:00 ` [PATCH v3] " Marek Szyprowski 0 siblings, 2 replies; 10+ messages in thread From: Marek Szyprowski @ 2016-12-16 12:39 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz UART modules can use DMA for offloading data transfers and reducing interrupts, so enable this feature for Exynos5 boards. Tested on Google ChromeBook Snow (Exynos5250) and Odroid XU3 (Exynos5422) boards. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- v2: - added Exynos5250 - fixed copy/paste typo for serial 2 and 3 --- arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++ arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 255b7c891d59..fc7ae8e557cc 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -1047,21 +1047,29 @@ &serial_0 { clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 13>, <&pdma0 14>; + dma-names = "rx", "tx"; }; &serial_1 { clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 15>, <&pdma0 16>; + dma-names = "rx", "tx"; }; &serial_2 { clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 15>, <&pdma1 16>; + dma-names = "rx", "tx"; }; &serial_3 { clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 17>, <&pdma1 18>; + dma-names = "rx", "tx"; }; #include "exynos5250-pinctrl.dtsi" diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index bb90326e53d2..f5468bbe8f13 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -1422,21 +1422,29 @@ &serial_0 { clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 13>, <&pdma0 14>; + dma-names = "rx", "tx"; }; &serial_1 { clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 15>, <&pdma0 16>; + dma-names = "rx", "tx"; }; &serial_2 { clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 15>, <&pdma1 16>; + dma-names = "rx", "tx"; }; &serial_3 { clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 17>, <&pdma1 18>; + dma-names = "rx", "tx"; }; &sss { -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs 2016-12-16 12:39 ` [PATCH v2] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs Marek Szyprowski @ 2016-12-16 16:50 ` Krzysztof Kozlowski 2016-12-19 6:37 ` Marek Szyprowski 2016-12-19 10:00 ` [PATCH v3] " Marek Szyprowski 1 sibling, 1 reply; 10+ messages in thread From: Krzysztof Kozlowski @ 2016-12-16 16:50 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-samsung-soc, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz On Fri, Dec 16, 2016 at 01:39:00PM +0100, Marek Szyprowski wrote: > UART modules can use DMA for offloading data transfers and reducing > interrupts, so enable this feature for Exynos5 boards. Tested on > Google ChromeBook Snow (Exynos5250) and Odroid XU3 (Exynos5422) boards. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > v2: > - added Exynos5250 > - fixed copy/paste typo for serial 2 and 3 > --- > arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++ > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ > 2 files changed, 16 insertions(+) > On Exynos4412 enabling DMA for serial exposed some interesting bugs so I assume here the fun will start after applying? :) Looks good, what about Exynos5410? Best regards, Krzysztof > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 255b7c891d59..fc7ae8e557cc 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -1047,21 +1047,29 @@ > &serial_0 { > clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 13>, <&pdma0 14>; > + dma-names = "rx", "tx"; > }; > > &serial_1 { > clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 15>, <&pdma0 16>; > + dma-names = "rx", "tx"; > }; > > &serial_2 { > clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 15>, <&pdma1 16>; > + dma-names = "rx", "tx"; > }; > > &serial_3 { > clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 17>, <&pdma1 18>; > + dma-names = "rx", "tx"; > }; > > #include "exynos5250-pinctrl.dtsi" > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index bb90326e53d2..f5468bbe8f13 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -1422,21 +1422,29 @@ > &serial_0 { > clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 13>, <&pdma0 14>; > + dma-names = "rx", "tx"; > }; > > &serial_1 { > clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 15>, <&pdma0 16>; > + dma-names = "rx", "tx"; > }; > > &serial_2 { > clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 15>, <&pdma1 16>; > + dma-names = "rx", "tx"; > }; > > &serial_3 { > clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 17>, <&pdma1 18>; > + dma-names = "rx", "tx"; > }; > > &sss { > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs 2016-12-16 16:50 ` Krzysztof Kozlowski @ 2016-12-19 6:37 ` Marek Szyprowski 2016-12-19 9:55 ` Marek Szyprowski 0 siblings, 1 reply; 10+ messages in thread From: Marek Szyprowski @ 2016-12-19 6:37 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-samsung-soc, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz Hi Krzysztof, On 2016-12-16 17:50, Krzysztof Kozlowski wrote: > On Fri, Dec 16, 2016 at 01:39:00PM +0100, Marek Szyprowski wrote: >> UART modules can use DMA for offloading data transfers and reducing >> interrupts, so enable this feature for Exynos5 boards. Tested on >> Google ChromeBook Snow (Exynos5250) and Odroid XU3 (Exynos5422) boards. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> v2: >> - added Exynos5250 >> - fixed copy/paste typo for serial 2 and 3 >> --- >> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++ >> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ >> 2 files changed, 16 insertions(+) >> > On Exynos4412 enabling DMA for serial exposed some interesting bugs so I > assume here the fun will start after applying? :) Enabling DMA on Exynos4412 already exposed bugs, which finally were fixed and now it works really fine there. I don't expect any issues after enabling it on Exynos5250/5422. > Looks good, what about Exynos5410? Exynos5410 will be handled separately, because it needs more patches - PL3310 DMA controllers are not yet defined nor clocks for them. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs 2016-12-19 6:37 ` Marek Szyprowski @ 2016-12-19 9:55 ` Marek Szyprowski 0 siblings, 0 replies; 10+ messages in thread From: Marek Szyprowski @ 2016-12-19 9:55 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-samsung-soc, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz Hi All, On 2016-12-19 07:37, Marek Szyprowski wrote: > Hi Krzysztof, > > > On 2016-12-16 17:50, Krzysztof Kozlowski wrote: >> On Fri, Dec 16, 2016 at 01:39:00PM +0100, Marek Szyprowski wrote: >>> UART modules can use DMA for offloading data transfers and reducing >>> interrupts, so enable this feature for Exynos5 boards. Tested on >>> Google ChromeBook Snow (Exynos5250) and Odroid XU3 (Exynos5422) boards. >>> >>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >>> --- >>> v2: >>> - added Exynos5250 >>> - fixed copy/paste typo for serial 2 and 3 >>> --- >>> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++ >>> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ >>> 2 files changed, 16 insertions(+) >>> >> On Exynos4412 enabling DMA for serial exposed some interesting bugs so I >> assume here the fun will start after applying? :) > > Enabling DMA on Exynos4412 already exposed bugs, which finally were fixed > and now it works really fine there. I don't expect any issues after > enabling > it on Exynos5250/5422. > >> Looks good, what about Exynos5410? > > Exynos5410 will be handled separately, because it needs more patches - > PL3310 > DMA controllers are not yet defined nor clocks for them. Huh, I didn't notice that this has been already in -next. I will updated the patch to cover Exynos5410 too. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs 2016-12-16 12:39 ` [PATCH v2] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs Marek Szyprowski 2016-12-16 16:50 ` Krzysztof Kozlowski @ 2016-12-19 10:00 ` Marek Szyprowski 2016-12-22 11:14 ` [v3] " Alim Akhtar 2016-12-29 14:09 ` [PATCH v3] " Krzysztof Kozlowski 1 sibling, 2 replies; 10+ messages in thread From: Marek Szyprowski @ 2016-12-19 10:00 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz UART modules can use DMA for offloading data transfers and reducing interrupts, so enable this feature for Exynos5 boards. Tested on Google ChromeBook Snow (Exynos5250), Odroid XU (Exynos5410) and Odroid XU3 (Exynos5422) boards. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- v3: - added Exynos5410 - fixed serial 1/2 again, in v2 they were incorrectly swaped as a result of my hurry in patch posting v2: - added Exynos5250 - fixed copy/paste typo for serial 2 and 3 --- arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++ arch/arm/boot/dts/exynos5410.dtsi | 8 ++++++++ arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ 3 files changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index b6d7444..0e04460 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -1043,21 +1043,29 @@ &serial_0 { clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 13>, <&pdma0 14>; + dma-names = "rx", "tx"; }; &serial_1 { clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 15>, <&pdma1 16>; + dma-names = "rx", "tx"; }; &serial_2 { clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 15>, <&pdma0 16>; + dma-names = "rx", "tx"; }; &serial_3 { clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 17>, <&pdma1 18>; + dma-names = "rx", "tx"; }; #include "exynos5250-pinctrl.dtsi" diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi index 2b6adaf..7eab4bc 100644 --- a/arch/arm/boot/dts/exynos5410.dtsi +++ b/arch/arm/boot/dts/exynos5410.dtsi @@ -340,21 +340,29 @@ &serial_0 { clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 13>, <&pdma0 14>; + dma-names = "rx", "tx"; }; &serial_1 { clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 15>, <&pdma1 16>; + dma-names = "rx", "tx"; }; &serial_2 { clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 15>, <&pdma0 16>; + dma-names = "rx", "tx"; }; &serial_3 { clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 17>, <&pdma1 18>; + dma-names = "rx", "tx"; }; &sss { diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 906a1a4..0154c2e 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -1406,21 +1406,29 @@ &serial_0 { clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 13>, <&pdma0 14>; + dma-names = "rx", "tx"; }; &serial_1 { clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 15>, <&pdma1 16>; + dma-names = "rx", "tx"; }; &serial_2 { clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma0 15>, <&pdma0 16>; + dma-names = "rx", "tx"; }; &serial_3 { clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; clock-names = "uart", "clk_uart_baud0"; + dmas = <&pdma1 17>, <&pdma1 18>; + dma-names = "rx", "tx"; }; &sss { -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [v3] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs 2016-12-19 10:00 ` [PATCH v3] " Marek Szyprowski @ 2016-12-22 11:14 ` Alim Akhtar 2016-12-22 11:18 ` Marek Szyprowski 2016-12-29 14:09 ` [PATCH v3] " Krzysztof Kozlowski 1 sibling, 1 reply; 10+ messages in thread From: Alim Akhtar @ 2016-12-22 11:14 UTC (permalink / raw) To: Marek Szyprowski, linux-samsung-soc Cc: Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz Hello, On 12/19/2016 03:30 PM, Marek Szyprowski wrote: > UART modules can use DMA for offloading data transfers and reducing > interrupts, so enable this feature for Exynos5 boards. Tested on > Google ChromeBook Snow (Exynos5250), Odroid XU (Exynos5410) and Odroid > XU3 (Exynos5422) boards. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > v3: > - added Exynos5410 make failed with this patch with below error: DTC arch/arm/boot/dts/exynos5410-odroidxu.dtb ERROR (phandle_references): Reference to non-existent node or label "pdma0" ERROR (phandle_references): Reference to non-existent node or label "pdma0" ERROR (phandle_references): Reference to non-existent node or label "pdma1" ERROR (phandle_references): Reference to non-existent node or label "pdma1" ERROR (phandle_references): Reference to non-existent node or label "pdma0" ERROR (phandle_references): Reference to non-existent node or label "pdma0" ERROR (phandle_references): Reference to non-existent node or label "pdma1" ERROR (phandle_references): Reference to non-existent node or label "pdma1" ERROR: Input tree has errors, aborting (use -f to force output) make[1]: *** [arch/arm/boot/dts/exynos5410-odroidxu.dtb] Error 2 make: *** [dtbs] Error 2 ------------------------------------- I tried building against linux-next with tag v4.9. 69973b8 Linux 4.9 2e4333c Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus ba73515 MIPS: Lantiq: Fix mask of GPE frequency Let me know if I am missing other patches. > - fixed serial 1/2 again, in v2 they were incorrectly swaped as a result > of my hurry in patch posting > > v2: > - added Exynos5250 > - fixed copy/paste typo for serial 2 and 3 > --- > arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++ > arch/arm/boot/dts/exynos5410.dtsi | 8 ++++++++ > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ > 3 files changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index b6d7444..0e04460 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -1043,21 +1043,29 @@ > &serial_0 { > clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 13>, <&pdma0 14>; > + dma-names = "rx", "tx"; > }; > > &serial_1 { > clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 15>, <&pdma1 16>; > + dma-names = "rx", "tx"; > }; > > &serial_2 { > clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 15>, <&pdma0 16>; > + dma-names = "rx", "tx"; > }; > > &serial_3 { > clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 17>, <&pdma1 18>; > + dma-names = "rx", "tx"; > }; > > #include "exynos5250-pinctrl.dtsi" > diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi > index 2b6adaf..7eab4bc 100644 > --- a/arch/arm/boot/dts/exynos5410.dtsi > +++ b/arch/arm/boot/dts/exynos5410.dtsi > @@ -340,21 +340,29 @@ > &serial_0 { > clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 13>, <&pdma0 14>; > + dma-names = "rx", "tx"; > }; > > &serial_1 { > clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 15>, <&pdma1 16>; > + dma-names = "rx", "tx"; > }; > > &serial_2 { > clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 15>, <&pdma0 16>; > + dma-names = "rx", "tx"; > }; > > &serial_3 { > clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 17>, <&pdma1 18>; > + dma-names = "rx", "tx"; > }; > > &sss { > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 906a1a4..0154c2e 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -1406,21 +1406,29 @@ > &serial_0 { > clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 13>, <&pdma0 14>; > + dma-names = "rx", "tx"; > }; > > &serial_1 { > clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 15>, <&pdma1 16>; > + dma-names = "rx", "tx"; > }; > > &serial_2 { > clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma0 15>, <&pdma0 16>; > + dma-names = "rx", "tx"; > }; > > &serial_3 { > clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; > clock-names = "uart", "clk_uart_baud0"; > + dmas = <&pdma1 17>, <&pdma1 18>; > + dma-names = "rx", "tx"; > }; > > &sss { > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [v3] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs 2016-12-22 11:14 ` [v3] " Alim Akhtar @ 2016-12-22 11:18 ` Marek Szyprowski 2016-12-22 12:07 ` Alim Akhtar 0 siblings, 1 reply; 10+ messages in thread From: Marek Szyprowski @ 2016-12-22 11:18 UTC (permalink / raw) To: Alim Akhtar, linux-samsung-soc Cc: Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz Hi Alim, On 2016-12-22 12:14, Alim Akhtar wrote: > Hello, > > On 12/19/2016 03:30 PM, Marek Szyprowski wrote: >> UART modules can use DMA for offloading data transfers and reducing >> interrupts, so enable this feature for Exynos5 boards. Tested on >> Google ChromeBook Snow (Exynos5250), Odroid XU (Exynos5410) and Odroid >> XU3 (Exynos5422) boards. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> v3: >> - added Exynos5410 > > make failed with this patch with below error: > DTC arch/arm/boot/dts/exynos5410-odroidxu.dtb > ERROR (phandle_references): Reference to non-existent node or label > "pdma0" > > ERROR (phandle_references): Reference to non-existent node or label > "pdma0" > > ERROR (phandle_references): Reference to non-existent node or label > "pdma1" > > ERROR (phandle_references): Reference to non-existent node or label > "pdma1" > > ERROR (phandle_references): Reference to non-existent node or label > "pdma0" > > ERROR (phandle_references): Reference to non-existent node or label > "pdma0" > > ERROR (phandle_references): Reference to non-existent node or label > "pdma1" > > ERROR (phandle_references): Reference to non-existent node or label > "pdma1" > > ERROR: Input tree has errors, aborting (use -f to force output) > make[1]: *** [arch/arm/boot/dts/exynos5410-odroidxu.dtb] Error 2 > make: *** [dtbs] Error 2 > ------------------------------------- > > I tried building against linux-next with tag v4.9. > > 69973b8 Linux 4.9 > 2e4333c Merge branch 'upstream' of > git://git.linux-mips.org/pub/scm/ralf/upstream-linus > ba73515 MIPS: Lantiq: Fix mask of GPE frequency > > Let me know if I am missing other patches. Please apply it on top of for-next branch from git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git > [...] Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [v3] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs 2016-12-22 11:18 ` Marek Szyprowski @ 2016-12-22 12:07 ` Alim Akhtar 0 siblings, 0 replies; 10+ messages in thread From: Alim Akhtar @ 2016-12-22 12:07 UTC (permalink / raw) To: Marek Szyprowski, linux-samsung-soc Cc: Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz On 12/22/2016 04:48 PM, Marek Szyprowski wrote: > Hi Alim, > > On 2016-12-22 12:14, Alim Akhtar wrote: >> Hello, >> >> On 12/19/2016 03:30 PM, Marek Szyprowski wrote: >>> UART modules can use DMA for offloading data transfers and reducing >>> interrupts, so enable this feature for Exynos5 boards. Tested on >>> Google ChromeBook Snow (Exynos5250), Odroid XU (Exynos5410) and Odroid >>> XU3 (Exynos5422) boards. >>> >>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >>> --- >>> v3: >>> - added Exynos5410 >> >> make failed with this patch with below error: >> DTC arch/arm/boot/dts/exynos5410-odroidxu.dtb >> ERROR (phandle_references): Reference to non-existent node or label >> "pdma0" >> >> ERROR (phandle_references): Reference to non-existent node or label >> "pdma0" >> >> ERROR (phandle_references): Reference to non-existent node or label >> "pdma1" >> >> ERROR (phandle_references): Reference to non-existent node or label >> "pdma1" >> >> ERROR (phandle_references): Reference to non-existent node or label >> "pdma0" >> >> ERROR (phandle_references): Reference to non-existent node or label >> "pdma0" >> >> ERROR (phandle_references): Reference to non-existent node or label >> "pdma1" >> >> ERROR (phandle_references): Reference to non-existent node or label >> "pdma1" >> >> ERROR: Input tree has errors, aborting (use -f to force output) >> make[1]: *** [arch/arm/boot/dts/exynos5410-odroidxu.dtb] Error 2 >> make: *** [dtbs] Error 2 >> ------------------------------------- >> >> I tried building against linux-next with tag v4.9. >> >> 69973b8 Linux 4.9 >> 2e4333c Merge branch 'upstream' of >> git://git.linux-mips.org/pub/scm/ralf/upstream-linus >> ba73515 MIPS: Lantiq: Fix mask of GPE frequency >> >> Let me know if I am missing other patches. > > Please apply it on top of for-next branch from > git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git > Thanks Marek for the above link. Tested this patch on exynos5800 peach-pi board. Tested-by: Alim Akhtar <alim.akhtar@samsung.com> > > [...] > > Best regards ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs 2016-12-19 10:00 ` [PATCH v3] " Marek Szyprowski 2016-12-22 11:14 ` [v3] " Alim Akhtar @ 2016-12-29 14:09 ` Krzysztof Kozlowski 1 sibling, 0 replies; 10+ messages in thread From: Krzysztof Kozlowski @ 2016-12-29 14:09 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-samsung-soc, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz On Mon, Dec 19, 2016 at 11:00:48AM +0100, Marek Szyprowski wrote: > UART modules can use DMA for offloading data transfers and reducing > interrupts, so enable this feature for Exynos5 boards. Tested on > Google ChromeBook Snow (Exynos5250), Odroid XU (Exynos5410) and Odroid > XU3 (Exynos5422) boards. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > v3: > - added Exynos5410 > - fixed serial 1/2 again, in v2 they were incorrectly swaped as a result > of my hurry in patch posting > > v2: > - added Exynos5250 > - fixed copy/paste typo for serial 2 and 3 > --- > arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++ > arch/arm/boot/dts/exynos5410.dtsi | 8 ++++++++ > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ > 3 files changed, 24 insertions(+) Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-12-29 14:09 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-12-16 12:27 [PATCH] ARM: dts: exynos: Enable DMA support for UART modules on Exynos542x SoCs Marek Szyprowski 2016-12-16 12:39 ` [PATCH v2] arm: dts: exynos: Enable DMA support for UART modules on Exynos5 SoCs Marek Szyprowski 2016-12-16 16:50 ` Krzysztof Kozlowski 2016-12-19 6:37 ` Marek Szyprowski 2016-12-19 9:55 ` Marek Szyprowski 2016-12-19 10:00 ` [PATCH v3] " Marek Szyprowski 2016-12-22 11:14 ` [v3] " Alim Akhtar 2016-12-22 11:18 ` Marek Szyprowski 2016-12-22 12:07 ` Alim Akhtar 2016-12-29 14:09 ` [PATCH v3] " Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.