* [PATCH] omap2: mark omap_init_rng as __init
@ 2016-12-16 9:08 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-12-16 9:08 UTC (permalink / raw)
To: Tony Lindgren
Cc: Arnd Bergmann, linux-kernel, Javier Martinez Canillas, linux-omap,
linux-arm-kernel
I found this section mismatch when building with an older
compiler release:
WARNING: vmlinux.o(.text+0x3051c): Section mismatch in reference from the function omap_init_rng() to the function .init.text:omap_device_build()
Obviously this one function should be __init as well. Normally
we don't get a warning as the function gets inlined into its
caller.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-omap2/devices.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 3fdb94599184..473951203104 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -121,7 +121,7 @@ static inline void omap_init_mcspi(void) {}
*
* Bind the RNG hwmod to the RNG omap_device. No return value.
*/
-static void omap_init_rng(void)
+static void __init omap_init_rng(void)
{
struct omap_hwmod *oh;
struct platform_device *pdev;
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] omap2: mark omap_init_rng as __init
@ 2016-12-16 9:08 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-12-16 9:08 UTC (permalink / raw)
To: linux-arm-kernel
I found this section mismatch when building with an older
compiler release:
WARNING: vmlinux.o(.text+0x3051c): Section mismatch in reference from the function omap_init_rng() to the function .init.text:omap_device_build()
Obviously this one function should be __init as well. Normally
we don't get a warning as the function gets inlined into its
caller.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-omap2/devices.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 3fdb94599184..473951203104 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -121,7 +121,7 @@ static inline void omap_init_mcspi(void) {}
*
* Bind the RNG hwmod to the RNG omap_device. No return value.
*/
-static void omap_init_rng(void)
+static void __init omap_init_rng(void)
{
struct omap_hwmod *oh;
struct platform_device *pdev;
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] omap2: mark omap_init_rng as __init
@ 2016-12-16 9:08 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-12-16 9:08 UTC (permalink / raw)
To: Tony Lindgren
Cc: Arnd Bergmann, Javier Martinez Canillas, Peter Ujfalusi,
Suman Anna, linux-arm-kernel, linux-omap, linux-kernel
I found this section mismatch when building with an older
compiler release:
WARNING: vmlinux.o(.text+0x3051c): Section mismatch in reference from the function omap_init_rng() to the function .init.text:omap_device_build()
Obviously this one function should be __init as well. Normally
we don't get a warning as the function gets inlined into its
caller.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-omap2/devices.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 3fdb94599184..473951203104 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -121,7 +121,7 @@ static inline void omap_init_mcspi(void) {}
*
* Bind the RNG hwmod to the RNG omap_device. No return value.
*/
-static void omap_init_rng(void)
+static void __init omap_init_rng(void)
{
struct omap_hwmod *oh;
struct platform_device *pdev;
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] omap2: mark omap_init_rng as __init
2016-12-16 9:08 ` Arnd Bergmann
@ 2016-12-16 17:11 ` Tony Lindgren
-1 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2016-12-16 17:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Javier Martinez Canillas, Peter Ujfalusi, Suman Anna,
linux-arm-kernel, linux-omap, linux-kernel
* Arnd Bergmann <arnd@arndb.de> [161216 01:10]:
> I found this section mismatch when building with an older
> compiler release:
>
> WARNING: vmlinux.o(.text+0x3051c): Section mismatch in reference from the function omap_init_rng() to the function .init.text:omap_device_build()
>
> Obviously this one function should be __init as well. Normally
> we don't get a warning as the function gets inlined into its
> caller.
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] omap2: mark omap_init_rng as __init
@ 2016-12-16 17:11 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2016-12-16 17:11 UTC (permalink / raw)
To: linux-arm-kernel
* Arnd Bergmann <arnd@arndb.de> [161216 01:10]:
> I found this section mismatch when building with an older
> compiler release:
>
> WARNING: vmlinux.o(.text+0x3051c): Section mismatch in reference from the function omap_init_rng() to the function .init.text:omap_device_build()
>
> Obviously this one function should be __init as well. Normally
> we don't get a warning as the function gets inlined into its
> caller.
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-16 17:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-16 9:08 [PATCH] omap2: mark omap_init_rng as __init Arnd Bergmann
2016-12-16 9:08 ` Arnd Bergmann
2016-12-16 9:08 ` Arnd Bergmann
2016-12-16 17:11 ` Tony Lindgren
2016-12-16 17:11 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.