Regression: CONFIG_IP_MULTICAST must now be defined in exynos_defconfig

Regression: CONFIG_IP_MULTICAST must now be defined in exynos_defconfig

[Robie Basak]

Kukjin/Krzysztof,

Nikolay's commit dcd87999d ("igmp: net: Move igmp namespace init to
correct file") regressed exynos_defconfig for me. In userspace (Ubuntu
14.04), I used libnss-mdns with v4.2(.x), but this commit stopped me
from being able to resolve local names (eg. "foo.local") published using
mDNS from elsewhere on the network in v4.9.

It looks like the commit adds extra conditional code based on
CONFIG_IP_MULTICAST. It turned out that exynos_defconfig doesn't have
CONFIG_IP_MULTICAST defined. Defining it solved my problem.

I'm using a Samsung ARM Chromebook.

I can define CONFIG_IP_MULTICAST myself easily enough, but shouldn't
this be defined in exynos_defconfig anyway?

Robie

Re: Regression: CONFIG_IP_MULTICAST must now be defined in exynos_defconfig

[Krzysztof Kozlowski]

On Sun, Dec 18, 2016 at 01:19:12PM +0000, Robie Basak wrote:
> Kukjin/Krzysztof,
> 
> Nikolay's commit dcd87999d ("igmp: net: Move igmp namespace init to
> correct file") regressed exynos_defconfig for me. In userspace (Ubuntu
> 14.04), I used libnss-mdns with v4.2(.x), but this commit stopped me
> from being able to resolve local names (eg. "foo.local") published using
> mDNS from elsewhere on the network in v4.9.
> 
> It looks like the commit adds extra conditional code based on
> CONFIG_IP_MULTICAST. It turned out that exynos_defconfig doesn't have
> CONFIG_IP_MULTICAST defined. Defining it solved my problem.
> 
> I'm using a Samsung ARM Chromebook.
> 
> I can define CONFIG_IP_MULTICAST myself easily enough, but shouldn't
> this be defined in exynos_defconfig anyway?

(from my correct email address)

Hi Robie,

I don't have any objections against enabling IP_MULTICAST in
exynos_defconfig. It seems indeed essential.

You are more than welcomed to send a patch for this.

If you don't want to do that, I can prepare one with your "Reported-by"
credits.

Best regards,
Krzysztof

Re: Regression: CONFIG_IP_MULTICAST must now be defined in exynos_defconfig

[Robie Basak]

Hi Krzysztof,

On Sun, Dec 18, 2016 at 06:49:45PM +0200, Krzysztof Kozlowski wrote:
> On Sun, Dec 18, 2016 at 01:19:12PM +0000, Robie Basak wrote:
> > I can define CONFIG_IP_MULTICAST myself easily enough, but shouldn't
> > this be defined in exynos_defconfig anyway?
> 
> (from my correct email address)

Ah, sorry. I failed to update to the current MAINTAINERS file.

> You are more than welcomed to send a patch for this.

Patch to follow. Thanks!

Robie

[PATCH] ARM: exynos_defconfig: enable IP multicast

[Robie Basak]

Prior to Nikolay's commit dcd87999d, libnss-mdns (eg. to resolve
"foo.local" on the LAN using mDNS) worked without CONFIG_IP_MULTICAST
defined, but dcd87999d caused it to stop working without having
CONFIG_IP_MULTICAST defined explicitly.

Since exynos_defconfig did not previously define CONFIG_IP_MULTICAST,
mDNS used to work for users building with just exynos_defconfig, but
stopped working from dcd87999d.

Define CONFIG_IP_MULTICAST explicitly in exynos_defconfig as it appears
essential anyway.

Signed-off-by: Robie Basak <robie@justgohome.co.uk>
---
 arch/arm/configs/exynos_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 79c415c..12b8f69 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -43,6 +43,7 @@ CONFIG_PACKET=y
 CONFIG_UNIX=y
 CONFIG_NET_KEY=y
 CONFIG_INET=y
+CONFIG_IP_MULTICAST=y
 CONFIG_IP_PNP=y
 CONFIG_IP_PNP_DHCP=y
 CONFIG_IP_PNP_BOOTP=y
-- 
2.7.4

Re: [PATCH] ARM: exynos_defconfig: enable IP multicast

[Krzysztof Kozlowski]

On Mon, Dec 19, 2016 at 12:56:37AM +0000, Robie Basak wrote:
> Prior to Nikolay's commit dcd87999d, libnss-mdns (eg. to resolve
> "foo.local" on the LAN using mDNS) worked without CONFIG_IP_MULTICAST
> defined, but dcd87999d caused it to stop working without having
> CONFIG_IP_MULTICAST defined explicitly.
> 
> Since exynos_defconfig did not previously define CONFIG_IP_MULTICAST,
> mDNS used to work for users building with just exynos_defconfig, but
> stopped working from dcd87999d.
> 
> Define CONFIG_IP_MULTICAST explicitly in exynos_defconfig as it appears
> essential anyway.
> 
> Signed-off-by: Robie Basak <robie@justgohome.co.uk>
> ---
>  arch/arm/configs/exynos_defconfig | 1 +
>  1 file changed, 1 insertion(+)

Thanks, applied.

Best regards,
Krzysztof