* Fwd: Build failed in Jenkins: ceph-master #94 [not found] <2025831951.53.1481945498160.JavaMail.jenkins@cephdev.digiware.nl> @ 2016-12-17 12:34 ` Willem Jan Withagen 2016-12-19 7:02 ` Mykola Golub 0 siblings, 1 reply; 5+ messages in thread From: Willem Jan Withagen @ 2016-12-17 12:34 UTC (permalink / raw) To: Ceph Development Hi, My FreeBSD builder starts to complain during compilation about the error repeated below. --WjW n file included from /home/jenkins/workspace/ceph-master/src/common/config.cc:15: In file included from /home/jenkins/workspace/ceph-master/src/auth/Auth.h:18: In file included from /home/jenkins/workspace/ceph-master/src/auth/Crypto.h:18: In file included from /home/jenkins/workspace/ceph-master/src/include/types.h:21: In file included from /home/jenkins/workspace/ceph-master/src/include/uuid.h:8: In file included from /home/jenkins/workspace/ceph-master/src/include/encoding.h:19: In file included from /home/jenkins/workspace/ceph-master/src/include/rados/memory.h:4: In file included from /usr/include/c++/v1/memory:599: /usr/include/c++/v1/type_traits:2857:38: error: incomplete type 'md_config_t::option_host_t' used in type trait expression : public integral_constant<bool, __is_constructible(_Tp, _Args...)> ^ /home/jenkins/workspace/ceph-master/src/common/config.cc:110:31: note: in instantiation of template class 'std::__1::is_constructible<md_config_t::option_host_t>' requested here typename std::enable_if<!std::is_constructible<T>::value, ^ /home/jenkins/workspace/ceph-master/src/common/config_opts.h:16:1: note: while substituting explicitly-specified template arguments into function template 'create_validator' OPTION(host, OPT_STR, "localhost") ^ /home/jenkins/workspace/ceph-master/src/common/config.cc:168:37: note: expanded from macro 'OPTION' #define OPTION(name, type, def_val) OPTION4(name, type, def_val, false) ^ /home/jenkins/workspace/ceph-master/src/common/config.cc:167:24: note: expanded from macro 'OPTION4' create_validator<option_##name##_t>() }, ^ /home/jenkins/workspace/ceph-master/src/common/config_opts.h:16:1: note: forward declaration of 'md_config_t::option_host_t' OPTION(host, OPT_STR, "localhost") ^ /home/jenkins/workspace/ceph-master/src/common/config.h:321:12: note: expanded from macro 'OPTION' struct option_##name##_t; ^ <scratch space>:51:1: note: expanded from here option_host_t ^ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fwd: Build failed in Jenkins: ceph-master #94 2016-12-17 12:34 ` Fwd: Build failed in Jenkins: ceph-master #94 Willem Jan Withagen @ 2016-12-19 7:02 ` Mykola Golub 2016-12-19 15:43 ` Willem Jan Withagen 0 siblings, 1 reply; 5+ messages in thread From: Mykola Golub @ 2016-12-19 7:02 UTC (permalink / raw) To: Willem Jan Withagen; +Cc: Ceph Development, Jason Dillaman This is due to the recently added config option validators [1] (aimed to solve the API issue with rbd_default_features option). It uses std::is_constructible to check if a type exists or just forward declared. Apparently, it does not work for clang. Using std::is_destructible instead looks like work [2]. [1] https://github.com/ceph/ceph/pull/12486 [2] https://github.com/trociny/ceph/commit/bd584fe797e30d666800cd4d9b440d4b51d1d27e On Sat, Dec 17, 2016 at 01:34:48PM +0100, Willem Jan Withagen wrote: > Hi, > > My FreeBSD builder starts to complain during compilation about > the error repeated below. > > > --WjW > > n file included from > /home/jenkins/workspace/ceph-master/src/common/config.cc:15: > In file included from > /home/jenkins/workspace/ceph-master/src/auth/Auth.h:18: > In file included from > /home/jenkins/workspace/ceph-master/src/auth/Crypto.h:18: > In file included from > /home/jenkins/workspace/ceph-master/src/include/types.h:21: > In file included from > /home/jenkins/workspace/ceph-master/src/include/uuid.h:8: > In file included from > /home/jenkins/workspace/ceph-master/src/include/encoding.h:19: > In file included from > /home/jenkins/workspace/ceph-master/src/include/rados/memory.h:4: > In file included from /usr/include/c++/v1/memory:599: > /usr/include/c++/v1/type_traits:2857:38: error: incomplete type > 'md_config_t::option_host_t' used in type trait expression > : public integral_constant<bool, __is_constructible(_Tp, _Args...)> > ^ > /home/jenkins/workspace/ceph-master/src/common/config.cc:110:31: note: > in instantiation of template class > 'std::__1::is_constructible<md_config_t::option_host_t>' requested here > typename std::enable_if<!std::is_constructible<T>::value, > ^ > /home/jenkins/workspace/ceph-master/src/common/config_opts.h:16:1: note: > while substituting explicitly-specified template arguments into function > template 'create_validator' > OPTION(host, OPT_STR, "localhost") > ^ > /home/jenkins/workspace/ceph-master/src/common/config.cc:168:37: note: > expanded from macro 'OPTION' > #define OPTION(name, type, def_val) OPTION4(name, type, def_val, false) > ^ > /home/jenkins/workspace/ceph-master/src/common/config.cc:167:24: note: > expanded from macro 'OPTION4' > create_validator<option_##name##_t>() }, > ^ > /home/jenkins/workspace/ceph-master/src/common/config_opts.h:16:1: note: > forward declaration of 'md_config_t::option_host_t' > OPTION(host, OPT_STR, "localhost") > ^ > /home/jenkins/workspace/ceph-master/src/common/config.h:321:12: note: > expanded from macro 'OPTION' > struct option_##name##_t; > ^ > <scratch space>:51:1: note: expanded from here > option_host_t > ^ > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Mykola Golub ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fwd: Build failed in Jenkins: ceph-master #94 2016-12-19 7:02 ` Mykola Golub @ 2016-12-19 15:43 ` Willem Jan Withagen 2016-12-19 15:45 ` Jason Dillaman 0 siblings, 1 reply; 5+ messages in thread From: Willem Jan Withagen @ 2016-12-19 15:43 UTC (permalink / raw) To: Mykola Golub; +Cc: Ceph Development, Jason Dillaman On 19-12-2016 08:02, Mykola Golub wrote: > This is due to the recently added config option validators [1] (aimed > to solve the API issue with rbd_default_features option). > > It uses std::is_constructible to check if a type exists or just > forward declared. Apparently, it does not work for clang. Using > std::is_destructible instead looks like work [2]. > > [1] https://github.com/ceph/ceph/pull/12486 > [2] https://github.com/trociny/ceph/commit/bd584fe797e30d666800cd4d9b440d4b51d1d27e Hi Mykola, This seems to be a nice workaround. I'll submit a PR. --WjW ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fwd: Build failed in Jenkins: ceph-master #94 2016-12-19 15:43 ` Willem Jan Withagen @ 2016-12-19 15:45 ` Jason Dillaman 2016-12-19 17:07 ` Willem Jan Withagen 0 siblings, 1 reply; 5+ messages in thread From: Jason Dillaman @ 2016-12-19 15:45 UTC (permalink / raw) To: Willem Jan Withagen; +Cc: Mykola Golub, Ceph Development Actually, it's already merged into the master branch [1]. Thanks. [1] https://github.com/ceph/ceph/pull/12565 On Mon, Dec 19, 2016 at 10:43 AM, Willem Jan Withagen <wjw@digiware.nl> wrote: > On 19-12-2016 08:02, Mykola Golub wrote: >> This is due to the recently added config option validators [1] (aimed >> to solve the API issue with rbd_default_features option). >> >> It uses std::is_constructible to check if a type exists or just >> forward declared. Apparently, it does not work for clang. Using >> std::is_destructible instead looks like work [2]. >> >> [1] https://github.com/ceph/ceph/pull/12486 >> [2] https://github.com/trociny/ceph/commit/bd584fe797e30d666800cd4d9b440d4b51d1d27e > > Hi Mykola, > > This seems to be a nice workaround. > I'll submit a PR. > > --WjW > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jason ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fwd: Build failed in Jenkins: ceph-master #94 2016-12-19 15:45 ` Jason Dillaman @ 2016-12-19 17:07 ` Willem Jan Withagen 0 siblings, 0 replies; 5+ messages in thread From: Willem Jan Withagen @ 2016-12-19 17:07 UTC (permalink / raw) To: dillaman; +Cc: Mykola Golub, Ceph Development On 19-12-2016 16:45, Jason Dillaman wrote: > Actually, it's already merged into the master branch [1]. Thanks. > > [1] https://github.com/ceph/ceph/pull/12565 Yup, I saw... Thanx for the speedy patch. in the mean time also submitted: Clang/str_list.h: fix clang warning about std::move #12570 So I guess we're working out the odd bits and pieces that Clang brings with it. --WjW > On Mon, Dec 19, 2016 at 10:43 AM, Willem Jan Withagen <wjw@digiware.nl> wrote: >> On 19-12-2016 08:02, Mykola Golub wrote: >>> This is due to the recently added config option validators [1] (aimed >>> to solve the API issue with rbd_default_features option). >>> >>> It uses std::is_constructible to check if a type exists or just >>> forward declared. Apparently, it does not work for clang. Using >>> std::is_destructible instead looks like work [2]. >>> >>> [1] https://github.com/ceph/ceph/pull/12486 >>> [2] https://github.com/trociny/ceph/commit/bd584fe797e30d666800cd4d9b440d4b51d1d27e >> >> Hi Mykola, >> >> This seems to be a nice workaround. >> I'll submit a PR. >> >> --WjW >> >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-19 17:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2025831951.53.1481945498160.JavaMail.jenkins@cephdev.digiware.nl>
2016-12-17 12:34 ` Fwd: Build failed in Jenkins: ceph-master #94 Willem Jan Withagen
2016-12-19 7:02 ` Mykola Golub
2016-12-19 15:43 ` Willem Jan Withagen
2016-12-19 15:45 ` Jason Dillaman
2016-12-19 17:07 ` Willem Jan Withagen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.